All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Dmitry Osipenko <digetx@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Zhang Rui <rui.zhang@intel.com>, Amit Kucheria <amitk@kernel.org>,
	Andreas Westman Dorcsak <hedmoo@yahoo.com>,
	Maxim Schwalm <maxim.schwalm@gmail.com>,
	Svyatoslav Ryhel <clamor95@gmail.com>,
	Ihor Didenko <tailormoon@rambler.ru>,
	Ion Agorria <ion@agorria.com>,
	Matt Merhar <mattmerhar@protonmail.com>,
	Peter Geis <pgwipeout@gmail.com>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v4 0/6] Add driver for NVIDIA Tegra30 SoC Thermal sensor
Date: Mon, 21 Jun 2021 19:13:33 +0200	[thread overview]
Message-ID: <e1e3816a-ddf4-be13-0410-0b929f3be60b@linaro.org> (raw)
In-Reply-To: <20210616190417.32214-1-digetx@gmail.com>


Hi Dmitry,

I compiled the your series and got these unresolved.

arm-linux-gnueabi-ld: drivers/thermal/tegra/soctherm-fuse.o: in function
`tegra_calc_shared_calib':
soctherm-fuse.c:(.text+0x60): undefined reference to `tegra_fuse_readl'
arm-linux-gnueabi-ld: soctherm-fuse.c:(.text+0xf0): undefined reference
to `tegra_fuse_readl'
arm-linux-gnueabi-ld: drivers/thermal/tegra/soctherm-fuse.o: in function
`tegra_calc_tsensor_calib':
soctherm-fuse.c:(.text+0x144): undefined reference to `tegra_fuse_readl'
arm-linux-gnueabi-ld: drivers/thermal/tegra/tegra30-tsensor.o: in
function `tegra_tsensor_fuse_read_spare':
tegra30-tsensor.c:(.text+0x364): undefined reference to `tegra_fuse_readl'
arm-linux-gnueabi-ld: drivers/thermal/tegra/tegra30-tsensor.o: in
function `tegra_tsensor_probe':
tegra30-tsensor.c:(.text+0x874): undefined reference to `tegra_fuse_readl'
arm-linux-gnueabi-ld:
drivers/thermal/tegra/tegra30-tsensor.o:tegra30-tsensor.c:(.text+0x904):
more undefined references to `tegra_fuse_readl' follow
make[1]: *** [/home/dlezcano/Work/src/linux/Makefile:1196: vmlinux] Error 1
make: *** [/home/dlezcano/Work/src/linux/Makefile:215: __sub-make] Error 2



On 16/06/2021 21:04, Dmitry Osipenko wrote:
> Hi,
> 
> This series adds support for the thermal sensor that is found on NVIDIA
> Tegra30 SoC. Sensor monitors temperature and voltage of the SoC, it also
> emits signals to the power management and clock controllers that are
> performing the emergency shut down and the CPU frequency throttling
> when a pre-programmed temperature levels are reached.
> 
> Changelog:
> 
> v4: - Removed DIV2 CPU frequency throttling and cooling device part as was
>       suggested by Daniel Lezcano since we need to notify cpufreq about the
>       updated frequency and change the thermal pressure. The thermal pressure
>       change should co-exists with the cpufreq_cooling. This all needs some
>       more thought, so the DIV2 mitigation will come sometime later.
> 
>     - Added ack from Thierry Reding.
> 
>     - Changed default TZ trips in the device-tree to the silicon temperature
>       levels, instead of the average device levels.
> 
> v3: - No code changes. CC'ed linux-pm, which was previously missed by accident.
>       Not sure how much that is important for the thermal patches, but won't
>       hurt to re-send since only DT binding was reviewed so far.
> 
> v2: - Made a very minor improvement to one error message, it now prints
>       number of channel at which error occurred.
> 
>     - Added r-b from Rob Herring to the binding.
> 
> Dmitry Osipenko (6):
>   dt-bindings: thermal: Add binding for Tegra30 thermal sensor
>   thermal: thermal_of: Stop zone device before unregistering it
>   thermal/drivers/tegra: Add driver for Tegra30 thermal sensor
>   ARM: tegra_defconfig: Enable CONFIG_TEGRA30_TSENSOR
>   ARM: multi_v7_defconfig: Enable CONFIG_TEGRA30_TSENSOR
>   ARM: tegra: Add SoC thermal sensor to Tegra30 device-trees
> 
>  .../thermal/nvidia,tegra30-tsensor.yaml       |  73 ++
>  arch/arm/boot/dts/tegra30.dtsi                |  87 ++-
>  arch/arm/configs/multi_v7_defconfig           |   1 +
>  arch/arm/configs/tegra_defconfig              |   1 +
>  drivers/thermal/tegra/Kconfig                 |   7 +
>  drivers/thermal/tegra/Makefile                |   1 +
>  drivers/thermal/tegra/tegra30-tsensor.c       | 673 ++++++++++++++++++
>  drivers/thermal/thermal_of.c                  |   3 +
>  8 files changed, 842 insertions(+), 4 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/thermal/nvidia,tegra30-tsensor.yaml
>  create mode 100644 drivers/thermal/tegra/tegra30-tsensor.c
> 


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  parent reply	other threads:[~2021-06-21 17:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 19:04 Dmitry Osipenko
2021-06-16 19:04 ` [PATCH v4 1/6] dt-bindings: thermal: Add binding for Tegra30 thermal sensor Dmitry Osipenko
2021-06-21  9:46   ` [thermal: thermal/next] " thermal-bot for Dmitry Osipenko
2021-07-04 18:02   ` thermal-bot for Dmitry Osipenko
2021-06-16 19:04 ` [PATCH v4 2/6] thermal: thermal_of: Stop zone device before unregistering it Dmitry Osipenko
2021-06-21  9:46   ` [thermal: thermal/next] thermal/core/thermal_of: " thermal-bot for Dmitry Osipenko
2021-07-04 18:02   ` thermal-bot for Dmitry Osipenko
2021-06-16 19:04 ` [PATCH v4 3/6] thermal/drivers/tegra: Add driver for Tegra30 thermal sensor Dmitry Osipenko
2021-06-21  9:46   ` [thermal: thermal/next] " thermal-bot for Dmitry Osipenko
2021-09-09 14:38   ` thermal-bot for Dmitry Osipenko
2021-06-16 19:04 ` [PATCH v4 4/6] ARM: tegra_defconfig: Enable CONFIG_TEGRA30_TSENSOR Dmitry Osipenko
2021-06-16 19:04 ` [PATCH v4 5/6] ARM: multi_v7_defconfig: " Dmitry Osipenko
2021-06-16 19:04 ` [PATCH v4 6/6] ARM: tegra: Add SoC thermal sensor to Tegra30 device-trees Dmitry Osipenko
2021-06-21 17:13 ` Daniel Lezcano [this message]
2021-06-21 17:26   ` [PATCH v4 0/6] Add driver for NVIDIA Tegra30 SoC Thermal sensor Dmitry Osipenko
2021-06-21 18:16     ` Daniel Lezcano
2021-06-21 18:25       ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1e3816a-ddf4-be13-0410-0b929f3be60b@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=amitk@kernel.org \
    --cc=clamor95@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=digetx@gmail.com \
    --cc=hedmoo@yahoo.com \
    --cc=ion@agorria.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mattmerhar@protonmail.com \
    --cc=maxim.schwalm@gmail.com \
    --cc=pgwipeout@gmail.com \
    --cc=rui.zhang@intel.com \
    --cc=tailormoon@rambler.ru \
    --cc=thierry.reding@gmail.com \
    --subject='Re: [PATCH v4 0/6] Add driver for NVIDIA Tegra30 SoC Thermal sensor' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.