From: Neil Armstrong <narmstrong@baylibre.com>
To: Robin Murphy <robin.murphy@arm.com>,
will@kernel.org, robh@kernel.org, tomeu.vizoso@collabora.com,
steven.price@arm.com, alyssa.rosenzweig@collabora.com,
khilman@baylibre.com, jbrunet@baylibre.com
Cc: linux-amlogic@lists.infradead.org,
iommu@lists.linux-foundation.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64: dts: meson: Describe G12b GPU as coherent
Date: Wed, 16 Sep 2020 10:26:43 +0200 [thread overview]
Message-ID: <e218b95e-39bc-e773-00fb-bcb5f1f835ea@baylibre.com> (raw)
In-Reply-To: <ba61c76654349d3dfcd14c1e24c5aed39ebe3cf7.1600213517.git.robin.murphy@arm.com>
Hi Robin,
On 16/09/2020 01:51, Robin Murphy wrote:
> According to a downstream commit I found in the Khadas vendor kernel,
> the GPU on G12b is wired up for ACE-lite, so (now that Panfrost knows
> how to handle this properly) we should describe it as such. Otherwise
> the mismatch leads to all manner of fun with mismatched attributes and
> inadvertently snooping stale data from caches, which would account for
> at least some of the brokenness observed on this platform.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi
> index 9b8548e5f6e5..ee8fcae9f9f0 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi
> @@ -135,3 +135,7 @@ map1 {
> };
> };
> };
> +
> +&mali {
> + dma-coherent;
> +};
>
Thanks a lot for digging, I'll run a test to confirm it fixes the issue !
Neil
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Robin Murphy <robin.murphy@arm.com>,
will@kernel.org, robh@kernel.org, tomeu.vizoso@collabora.com,
steven.price@arm.com, alyssa.rosenzweig@collabora.com,
khilman@baylibre.com, jbrunet@baylibre.com
Cc: linux-amlogic@lists.infradead.org,
iommu@lists.linux-foundation.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64: dts: meson: Describe G12b GPU as coherent
Date: Wed, 16 Sep 2020 10:26:43 +0200 [thread overview]
Message-ID: <e218b95e-39bc-e773-00fb-bcb5f1f835ea@baylibre.com> (raw)
In-Reply-To: <ba61c76654349d3dfcd14c1e24c5aed39ebe3cf7.1600213517.git.robin.murphy@arm.com>
Hi Robin,
On 16/09/2020 01:51, Robin Murphy wrote:
> According to a downstream commit I found in the Khadas vendor kernel,
> the GPU on G12b is wired up for ACE-lite, so (now that Panfrost knows
> how to handle this properly) we should describe it as such. Otherwise
> the mismatch leads to all manner of fun with mismatched attributes and
> inadvertently snooping stale data from caches, which would account for
> at least some of the brokenness observed on this platform.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi
> index 9b8548e5f6e5..ee8fcae9f9f0 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi
> @@ -135,3 +135,7 @@ map1 {
> };
> };
> };
> +
> +&mali {
> + dma-coherent;
> +};
>
Thanks a lot for digging, I'll run a test to confirm it fixes the issue !
Neil
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Robin Murphy <robin.murphy@arm.com>,
will@kernel.org, robh@kernel.org, tomeu.vizoso@collabora.com,
steven.price@arm.com, alyssa.rosenzweig@collabora.com,
khilman@baylibre.com, jbrunet@baylibre.com
Cc: linux-amlogic@lists.infradead.org,
iommu@lists.linux-foundation.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64: dts: meson: Describe G12b GPU as coherent
Date: Wed, 16 Sep 2020 10:26:43 +0200 [thread overview]
Message-ID: <e218b95e-39bc-e773-00fb-bcb5f1f835ea@baylibre.com> (raw)
In-Reply-To: <ba61c76654349d3dfcd14c1e24c5aed39ebe3cf7.1600213517.git.robin.murphy@arm.com>
Hi Robin,
On 16/09/2020 01:51, Robin Murphy wrote:
> According to a downstream commit I found in the Khadas vendor kernel,
> the GPU on G12b is wired up for ACE-lite, so (now that Panfrost knows
> how to handle this properly) we should describe it as such. Otherwise
> the mismatch leads to all manner of fun with mismatched attributes and
> inadvertently snooping stale data from caches, which would account for
> at least some of the brokenness observed on this platform.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi
> index 9b8548e5f6e5..ee8fcae9f9f0 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi
> @@ -135,3 +135,7 @@ map1 {
> };
> };
> };
> +
> +&mali {
> + dma-coherent;
> +};
>
Thanks a lot for digging, I'll run a test to confirm it fixes the issue !
Neil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Robin Murphy <robin.murphy@arm.com>,
will@kernel.org, robh@kernel.org, tomeu.vizoso@collabora.com,
steven.price@arm.com, alyssa.rosenzweig@collabora.com,
khilman@baylibre.com, jbrunet@baylibre.com
Cc: linux-amlogic@lists.infradead.org,
iommu@lists.linux-foundation.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64: dts: meson: Describe G12b GPU as coherent
Date: Wed, 16 Sep 2020 10:26:43 +0200 [thread overview]
Message-ID: <e218b95e-39bc-e773-00fb-bcb5f1f835ea@baylibre.com> (raw)
In-Reply-To: <ba61c76654349d3dfcd14c1e24c5aed39ebe3cf7.1600213517.git.robin.murphy@arm.com>
Hi Robin,
On 16/09/2020 01:51, Robin Murphy wrote:
> According to a downstream commit I found in the Khadas vendor kernel,
> the GPU on G12b is wired up for ACE-lite, so (now that Panfrost knows
> how to handle this properly) we should describe it as such. Otherwise
> the mismatch leads to all manner of fun with mismatched attributes and
> inadvertently snooping stale data from caches, which would account for
> at least some of the brokenness observed on this platform.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi
> index 9b8548e5f6e5..ee8fcae9f9f0 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi
> @@ -135,3 +135,7 @@ map1 {
> };
> };
> };
> +
> +&mali {
> + dma-coherent;
> +};
>
Thanks a lot for digging, I'll run a test to confirm it fixes the issue !
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-09-16 8:32 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 23:51 [PATCH 0/3] drm: panfrost: Coherency support Robin Murphy
2020-09-15 23:51 ` Robin Murphy
2020-09-15 23:51 ` Robin Murphy
2020-09-15 23:51 ` Robin Murphy
2020-09-15 23:51 ` [PATCH 1/3] iommu/io-pgtable-arm: Support coherency for Mali LPAE Robin Murphy
2020-09-15 23:51 ` Robin Murphy
2020-09-15 23:51 ` Robin Murphy
2020-09-15 23:51 ` Robin Murphy
2020-09-21 17:57 ` Will Deacon
2020-09-21 17:57 ` Will Deacon
2020-09-21 17:57 ` Will Deacon
2020-09-21 17:57 ` Will Deacon
2020-09-21 21:53 ` Robin Murphy
2020-09-21 21:53 ` Robin Murphy
2020-09-21 21:53 ` Robin Murphy
2020-09-21 21:53 ` Robin Murphy
2020-09-21 22:24 ` Will Deacon
2020-09-21 22:24 ` Will Deacon
2020-09-21 22:24 ` Will Deacon
2020-09-21 22:24 ` Will Deacon
2020-09-15 23:51 ` [PATCH 2/3] drm/panfrost: Support cache-coherent integrations Robin Murphy
2020-09-15 23:51 ` Robin Murphy
2020-09-15 23:51 ` Robin Murphy
2020-09-15 23:51 ` Robin Murphy
2020-09-17 10:37 ` Steven Price
2020-09-17 10:37 ` Steven Price
2020-09-17 10:37 ` Steven Price
2020-09-17 10:37 ` Steven Price
2020-09-15 23:51 ` [PATCH 3/3] arm64: dts: meson: Describe G12b GPU as coherent Robin Murphy
2020-09-15 23:51 ` Robin Murphy
2020-09-15 23:51 ` Robin Murphy
2020-09-15 23:51 ` Robin Murphy
2020-09-16 8:26 ` Neil Armstrong [this message]
2020-09-16 8:26 ` Neil Armstrong
2020-09-16 8:26 ` Neil Armstrong
2020-09-16 8:26 ` Neil Armstrong
2020-10-05 8:15 ` Boris Brezillon
2020-10-05 8:15 ` Boris Brezillon
2020-10-05 8:15 ` Boris Brezillon
2020-10-05 8:15 ` Boris Brezillon
2020-10-05 8:34 ` Steven Price
2020-10-05 8:34 ` Steven Price
2020-10-05 8:34 ` Steven Price
2020-10-05 8:34 ` Steven Price
2020-10-05 8:39 ` Boris Brezillon
2020-10-05 8:39 ` Boris Brezillon
2020-10-05 8:39 ` Boris Brezillon
2020-10-05 8:39 ` Boris Brezillon
2020-10-05 10:05 ` Steven Price
2020-10-05 10:05 ` Steven Price
2020-10-05 10:05 ` Steven Price
2020-10-05 10:05 ` Steven Price
2020-09-16 14:54 ` Neil Armstrong
2020-09-16 14:54 ` Neil Armstrong
2020-09-16 14:54 ` Neil Armstrong
2020-09-16 14:54 ` Neil Armstrong
2020-09-16 14:54 ` [PATCH 0/3] drm: panfrost: Coherency support Neil Armstrong
2020-09-16 14:54 ` Neil Armstrong
2020-09-16 14:54 ` Neil Armstrong
2020-09-16 14:54 ` Neil Armstrong
2020-09-16 17:04 ` Alyssa Rosenzweig
2020-09-16 17:04 ` Alyssa Rosenzweig
2020-09-16 17:04 ` Alyssa Rosenzweig
2020-09-16 17:04 ` Alyssa Rosenzweig
2020-09-16 17:46 ` Rob Herring
2020-09-16 17:46 ` Rob Herring
2020-09-16 17:46 ` Rob Herring
2020-09-16 17:46 ` Rob Herring
2020-09-17 10:38 ` Steven Price
2020-09-17 10:38 ` Steven Price
2020-09-17 10:38 ` Steven Price
2020-09-17 10:38 ` Steven Price
2020-09-17 10:51 ` Tomeu Vizoso
2020-09-17 10:51 ` Tomeu Vizoso
2020-09-17 10:51 ` Tomeu Vizoso
2020-09-17 10:51 ` Tomeu Vizoso
2020-09-17 11:00 ` Steven Price
2020-09-17 11:00 ` Steven Price
2020-09-17 11:00 ` Steven Price
2020-09-17 11:00 ` Steven Price
2020-09-17 12:03 ` Alyssa Rosenzweig
2020-09-17 12:03 ` Alyssa Rosenzweig
2020-09-17 12:03 ` Alyssa Rosenzweig
2020-09-17 12:03 ` Alyssa Rosenzweig
2020-09-17 12:38 ` Robin Murphy
2020-09-17 12:38 ` Robin Murphy
2020-09-17 12:38 ` Robin Murphy
2020-09-17 12:38 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e218b95e-39bc-e773-00fb-bcb5f1f835ea@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.