All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: Tong Zhang <ztong0001@gmail.com>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Alexander A. Klimov" <grandmaster@al2klimov.de>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: comedi: cb_pcidas: fix request_irq() warn
Date: Tue, 16 Mar 2021 10:30:43 +0000	[thread overview]
Message-ID: <e33c1059-cb89-5798-1030-bb1c13994198@mev.co.uk> (raw)
In-Reply-To: <20210315195914.4801-1-ztong0001@gmail.com>

On 15/03/2021 19:59, Tong Zhang wrote:
> request_irq() wont accept a name which contains slash so we need to
> repalce it with something else -- otherwise it will trigger a warning
> and the entry in /proc/irq/ will not be created
> since the .name might be used by userspace and we don't want to break
> userspace, so we are changing the parameters passed to request_irq()
> 
> [    1.630764] name 'pci-das1602/16'
> [    1.630950] WARNING: CPU: 0 PID: 181 at fs/proc/generic.c:180 __xlate_proc_name+0x93/0xb0
> [    1.634009] RIP: 0010:__xlate_proc_name+0x93/0xb0
> [    1.639441] Call Trace:
> [    1.639976]  proc_mkdir+0x18/0x20
> [    1.641946]  request_threaded_irq+0xfe/0x160
> [    1.642186]  cb_pcidas_auto_attach+0xf4/0x610 [cb_pcidas]
> 
> Suggested-by: Ian Abbott <abbotti@mev.co.uk>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
> ---
> v2: revert changes to .name field so that we dont break userspace
> 
>   drivers/staging/comedi/drivers/cb_pcidas.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c b/drivers/staging/comedi/drivers/cb_pcidas.c
> index d740c4782775..2f20bd56ec6c 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas.c
> @@ -1281,7 +1281,7 @@ static int cb_pcidas_auto_attach(struct comedi_device *dev,
>   	     devpriv->amcc + AMCC_OP_REG_INTCSR);
>   
>   	ret = request_irq(pcidev->irq, cb_pcidas_interrupt, IRQF_SHARED,
> -			  dev->board_name, dev);
> +			  "cb_pcidas", dev);
>   	if (ret) {
>   		dev_dbg(dev->class_dev, "unable to allocate irq %d\n",
>   			pcidev->irq);
> 

Looks good.

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-

WARNING: multiple messages have this Message-ID (diff)
From: Ian Abbott <abbotti@mev.co.uk>
To: Tong Zhang <ztong0001@gmail.com>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Alexander A. Klimov" <grandmaster@al2klimov.de>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: comedi: cb_pcidas: fix request_irq() warn
Date: Tue, 16 Mar 2021 10:30:43 +0000	[thread overview]
Message-ID: <e33c1059-cb89-5798-1030-bb1c13994198@mev.co.uk> (raw)
In-Reply-To: <20210315195914.4801-1-ztong0001@gmail.com>

On 15/03/2021 19:59, Tong Zhang wrote:
> request_irq() wont accept a name which contains slash so we need to
> repalce it with something else -- otherwise it will trigger a warning
> and the entry in /proc/irq/ will not be created
> since the .name might be used by userspace and we don't want to break
> userspace, so we are changing the parameters passed to request_irq()
> 
> [    1.630764] name 'pci-das1602/16'
> [    1.630950] WARNING: CPU: 0 PID: 181 at fs/proc/generic.c:180 __xlate_proc_name+0x93/0xb0
> [    1.634009] RIP: 0010:__xlate_proc_name+0x93/0xb0
> [    1.639441] Call Trace:
> [    1.639976]  proc_mkdir+0x18/0x20
> [    1.641946]  request_threaded_irq+0xfe/0x160
> [    1.642186]  cb_pcidas_auto_attach+0xf4/0x610 [cb_pcidas]
> 
> Suggested-by: Ian Abbott <abbotti@mev.co.uk>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
> ---
> v2: revert changes to .name field so that we dont break userspace
> 
>   drivers/staging/comedi/drivers/cb_pcidas.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c b/drivers/staging/comedi/drivers/cb_pcidas.c
> index d740c4782775..2f20bd56ec6c 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas.c
> @@ -1281,7 +1281,7 @@ static int cb_pcidas_auto_attach(struct comedi_device *dev,
>   	     devpriv->amcc + AMCC_OP_REG_INTCSR);
>   
>   	ret = request_irq(pcidev->irq, cb_pcidas_interrupt, IRQF_SHARED,
> -			  dev->board_name, dev);
> +			  "cb_pcidas", dev);
>   	if (ret) {
>   		dev_dbg(dev->class_dev, "unable to allocate irq %d\n",
>   			pcidev->irq);
> 

Looks good.

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2021-03-16 10:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-14  4:02 [PATCH] staging: comedi: cb_pcidas: replace slash in name Tong Zhang
2021-03-14  4:02 ` Tong Zhang
2021-03-15 10:50 ` Ian Abbott
2021-03-15 10:50   ` Ian Abbott
2021-03-15 19:59   ` [PATCH v2] staging: comedi: cb_pcidas: fix request_irq() warn Tong Zhang
2021-03-15 19:59     ` Tong Zhang
2021-03-16 10:30     ` Ian Abbott [this message]
2021-03-16 10:30       ` Ian Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e33c1059-cb89-5798-1030-bb1c13994198@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=grandmaster@al2klimov.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ztong0001@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.