* [PATCH] target/mips: Remove obsolete FCR0_HAS2008 comment on P5600 CPU
@ 2021-10-28 21:21 Philippe Mathieu-Daudé
2021-10-29 11:40 ` Jiaxun Yang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-10-28 21:21 UTC (permalink / raw)
To: qemu-devel
Cc: Aleksandar Rikalo, Richard Henderson, Philippe Mathieu-Daudé,
Aurelien Jarno
FCR0_HAS2008 flag has been enabled in commit ba5c79f2622
("target-mips: indicate presence of IEEE 754-2008 FPU in
R6/R5+MSA CPUs"), so remove the obsolete FIXME comment.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/mips/cpu-defs.c.inc | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/mips/cpu-defs.c.inc b/target/mips/cpu-defs.c.inc
index cbc45fcb0e8..b946f8f957f 100644
--- a/target/mips/cpu-defs.c.inc
+++ b/target/mips/cpu-defs.c.inc
@@ -369,7 +369,6 @@ const mips_def_t mips_defs[] =
* Config3: VZ, CTXTC, CDMM, TL
* Config4: MMUExtDef
* Config5: MRP
- * FIR(FCR0): Has2008
* */
.name = "P5600",
.CP0_PRid = 0x0001A800,
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] target/mips: Remove obsolete FCR0_HAS2008 comment on P5600 CPU
2021-10-28 21:21 [PATCH] target/mips: Remove obsolete FCR0_HAS2008 comment on P5600 CPU Philippe Mathieu-Daudé
@ 2021-10-29 11:40 ` Jiaxun Yang
2021-10-29 16:55 ` Richard Henderson
2021-10-29 18:01 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Jiaxun Yang @ 2021-10-29 11:40 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Aleksandar Rikalo, Richard Henderson, Aurelien Jarno
在 2021/10/28 22:21, Philippe Mathieu-Daudé 写道:
> FCR0_HAS2008 flag has been enabled in commit ba5c79f2622
> ("target-mips: indicate presence of IEEE 754-2008 FPU in
> R6/R5+MSA CPUs"), so remove the obsolete FIXME comment.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Thanks.
- Jiaxun
> ---
> target/mips/cpu-defs.c.inc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/mips/cpu-defs.c.inc b/target/mips/cpu-defs.c.inc
> index cbc45fcb0e8..b946f8f957f 100644
> --- a/target/mips/cpu-defs.c.inc
> +++ b/target/mips/cpu-defs.c.inc
> @@ -369,7 +369,6 @@ const mips_def_t mips_defs[] =
> * Config3: VZ, CTXTC, CDMM, TL
> * Config4: MMUExtDef
> * Config5: MRP
> - * FIR(FCR0): Has2008
> * */
> .name = "P5600",
> .CP0_PRid = 0x0001A800,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] target/mips: Remove obsolete FCR0_HAS2008 comment on P5600 CPU
2021-10-28 21:21 [PATCH] target/mips: Remove obsolete FCR0_HAS2008 comment on P5600 CPU Philippe Mathieu-Daudé
2021-10-29 11:40 ` Jiaxun Yang
@ 2021-10-29 16:55 ` Richard Henderson
2021-10-29 18:01 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2021-10-29 16:55 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Aleksandar Rikalo, Aurelien Jarno
On 10/28/21 2:21 PM, Philippe Mathieu-Daudé wrote:
> FCR0_HAS2008 flag has been enabled in commit ba5c79f2622
> ("target-mips: indicate presence of IEEE 754-2008 FPU in
> R6/R5+MSA CPUs"), so remove the obsolete FIXME comment.
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> target/mips/cpu-defs.c.inc | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] target/mips: Remove obsolete FCR0_HAS2008 comment on P5600 CPU
2021-10-28 21:21 [PATCH] target/mips: Remove obsolete FCR0_HAS2008 comment on P5600 CPU Philippe Mathieu-Daudé
2021-10-29 11:40 ` Jiaxun Yang
2021-10-29 16:55 ` Richard Henderson
@ 2021-10-29 18:01 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-10-29 18:01 UTC (permalink / raw)
To: qemu-devel; +Cc: Aleksandar Rikalo, Richard Henderson, Aurelien Jarno
On 10/28/21 23:21, Philippe Mathieu-Daudé wrote:
> FCR0_HAS2008 flag has been enabled in commit ba5c79f2622
> ("target-mips: indicate presence of IEEE 754-2008 FPU in
> R6/R5+MSA CPUs"), so remove the obsolete FIXME comment.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/mips/cpu-defs.c.inc | 1 -
> 1 file changed, 1 deletion(-)
Thanks, applied to mips-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-29 18:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-28 21:21 [PATCH] target/mips: Remove obsolete FCR0_HAS2008 comment on P5600 CPU Philippe Mathieu-Daudé
2021-10-29 11:40 ` Jiaxun Yang
2021-10-29 16:55 ` Richard Henderson
2021-10-29 18:01 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.