[PATCH] target/mips: Remove obsolete FCR0_HAS2008 comment on P5600 CPU

[PATCH] target/mips: Remove obsolete FCR0_HAS2008 comment on P5600 CPU

[Philippe Mathieu-Daudé]

FCR0_HAS2008 flag has been enabled in commit ba5c79f2622
("target-mips: indicate presence of IEEE 754-2008 FPU in
R6/R5+MSA CPUs"), so remove the obsolete FIXME comment.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/mips/cpu-defs.c.inc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/mips/cpu-defs.c.inc b/target/mips/cpu-defs.c.inc
index cbc45fcb0e8..b946f8f957f 100644
--- a/target/mips/cpu-defs.c.inc
+++ b/target/mips/cpu-defs.c.inc
@@ -369,7 +369,6 @@ const mips_def_t mips_defs[] =
          * Config3: VZ, CTXTC, CDMM, TL
          * Config4: MMUExtDef
          * Config5: MRP
-         * FIR(FCR0): Has2008
          * */
         .name = "P5600",
         .CP0_PRid = 0x0001A800,
-- 
2.31.1

Re: [PATCH] target/mips: Remove obsolete FCR0_HAS2008 comment on P5600 CPU

[Jiaxun Yang]

在 2021/10/28 22:21, Philippe Mathieu-Daudé 写道:
> FCR0_HAS2008 flag has been enabled in commit ba5c79f2622
> ("target-mips: indicate presence of IEEE 754-2008 FPU in
> R6/R5+MSA CPUs"), so remove the obsolete FIXME comment.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Thanks.

- Jiaxun

> ---
>   target/mips/cpu-defs.c.inc | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/target/mips/cpu-defs.c.inc b/target/mips/cpu-defs.c.inc
> index cbc45fcb0e8..b946f8f957f 100644
> --- a/target/mips/cpu-defs.c.inc
> +++ b/target/mips/cpu-defs.c.inc
> @@ -369,7 +369,6 @@ const mips_def_t mips_defs[] =
>            * Config3: VZ, CTXTC, CDMM, TL
>            * Config4: MMUExtDef
>            * Config5: MRP
> -         * FIR(FCR0): Has2008
>            * */
>           .name = "P5600",
>           .CP0_PRid = 0x0001A800,

Re: [PATCH] target/mips: Remove obsolete FCR0_HAS2008 comment on P5600 CPU

[Richard Henderson]

On 10/28/21 2:21 PM, Philippe Mathieu-Daudé wrote:
> FCR0_HAS2008 flag has been enabled in commit ba5c79f2622
> ("target-mips: indicate presence of IEEE 754-2008 FPU in
> R6/R5+MSA CPUs"), so remove the obsolete FIXME comment.
> 
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   target/mips/cpu-defs.c.inc | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH] target/mips: Remove obsolete FCR0_HAS2008 comment on P5600 CPU

[Philippe Mathieu-Daudé]

On 10/28/21 23:21, Philippe Mathieu-Daudé wrote:
> FCR0_HAS2008 flag has been enabled in commit ba5c79f2622
> ("target-mips: indicate presence of IEEE 754-2008 FPU in
> R6/R5+MSA CPUs"), so remove the obsolete FIXME comment.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/mips/cpu-defs.c.inc | 1 -
>  1 file changed, 1 deletion(-)

Thanks, applied to mips-next.