All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	Bart Van Assche <Bart.VanAssche@wdc.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Stanislav Nijnikov <stanislav.nijnikov@wdc.com>,
	Evan Green <evgreen@chromium.org>,
	Vinayak Holikatti <vinholikatti@gmail.com>,
	Janek Kotas <jank@cadence.com>,
	Vivek Gautam <vivek.gautam@codeaurora.org>,
	Asutosh Das <asutoshd@codeaurora.org>,
	Subhash Jadavani <subhashj@codeaurora.org>,
	Sayali Lokhande <sayalil@codeaurora.org>,
	Li Wei <liwei213@huawei.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Jaegeuk Kim <jaegeuk@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Alex Lemberg <Alex.Lemberg@sandisk.com>
Subject: Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now
Date: Thu, 13 Sep 2018 15:15:39 +0300	[thread overview]
Message-ID: <e4d0c716-006a-72cb-0240-4ae5749b21b8@intel.com> (raw)
In-Reply-To: <20180913120459.GA4965@ming.t460p>

On 13/09/18 15:05, Ming Lei wrote:
> On Thu, Sep 13, 2018 at 02:28:48PM +0300, Adrian Hunter wrote:
>> blk-mq does not support runtime pm, so disable blk-mq support for now.
> 
> So could you describe a bit what the issue you are trying to fix?

UFS is a low-power solution, so we must be able to runtime suspend.

> 
> This is host level runtime PM you are trying to address, and if blk-mq
> runtime isn't enabled, I guess the host won't be runtime suspended at all
> because some of its descendant are always active.
> 
> So seems we need to do nothing for preventing the host controller from
> entering runtime suspend.

We don't want to prevent the host controller from runtime suspending, quite
the opposite.

WARNING: multiple messages have this Message-ID (diff)
From: Adrian Hunter <adrian.hunter@intel.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	Bart Van Assche <Bart.VanAssche@wdc.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Stanislav Nijnikov <stanislav.nijnikov@wdc.com>,
	Evan Green <evgreen@chromium.org>,
	Vinayak Holikatti <vinholikatti@gmail.com>,
	Janek Kotas <jank@cadence.com>,
	Vivek Gautam <vivek.gautam@codeaurora.org>,
	Asutosh Das <asutoshd@codeaurora.org>,
	Subhash Jadavani <subhashj@codeaurora.org>,
	Sayali Lokhande <sayalil@codeaurora.org>,
	Li Wei <liwei213@huawei.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now
Date: Thu, 13 Sep 2018 15:15:39 +0300	[thread overview]
Message-ID: <e4d0c716-006a-72cb-0240-4ae5749b21b8@intel.com> (raw)
In-Reply-To: <20180913120459.GA4965@ming.t460p>

On 13/09/18 15:05, Ming Lei wrote:
> On Thu, Sep 13, 2018 at 02:28:48PM +0300, Adrian Hunter wrote:
>> blk-mq does not support runtime pm, so disable blk-mq support for now.
> 
> So could you describe a bit what the issue you are trying to fix?

UFS is a low-power solution, so we must be able to runtime suspend.

> 
> This is host level runtime PM you are trying to address, and if blk-mq
> runtime isn't enabled, I guess the host won't be runtime suspended at all
> because some of its descendant are always active.
> 
> So seems we need to do nothing for preventing the host controller from
> entering runtime suspend.

We don't want to prevent the host controller from runtime suspending, quite
the opposite.

  reply	other threads:[~2018-09-13 12:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-13 11:28 [PATCH RFC] scsi: ufs: Disable blk-mq for now Adrian Hunter
2018-09-13 12:05 ` Ming Lei
2018-09-13 12:05   ` Ming Lei
2018-09-13 12:15   ` Adrian Hunter [this message]
2018-09-13 12:15     ` Adrian Hunter
2018-09-14  1:52     ` Ming Lei
2018-09-14  1:52       ` Ming Lei
2018-09-14  6:17       ` Adrian Hunter
2018-09-14  6:17         ` Adrian Hunter
2018-09-14 13:03         ` Adrian Hunter
2018-09-14 13:03           ` Adrian Hunter
2018-09-20  6:58       ` Christoph Hellwig
2018-09-20  6:58         ` Christoph Hellwig
2018-09-21  1:59 ` Martin K. Petersen
2018-09-21  1:59   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4d0c716-006a-72cb-0240-4ae5749b21b8@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=Alex.Lemberg@sandisk.com \
    --cc=Bart.VanAssche@wdc.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=axboe@kernel.dk \
    --cc=bjorn.andersson@linaro.org \
    --cc=evgreen@chromium.org \
    --cc=hch@lst.de \
    --cc=jaegeuk@kernel.org \
    --cc=jank@cadence.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=liwei213@huawei.com \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    --cc=sayalil@codeaurora.org \
    --cc=stanislav.nijnikov@wdc.com \
    --cc=subhashj@codeaurora.org \
    --cc=vinholikatti@gmail.com \
    --cc=vivek.gautam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.