All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	Bart Van Assche <Bart.VanAssche@wdc.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Stanislav Nijnikov <stanislav.nijnikov@wdc.com>,
	Evan Green <evgreen@chromium.org>,
	Vinayak Holikatti <vinholikatti@gmail.com>,
	Janek Kotas <jank@cadence.com>,
	Vivek Gautam <vivek.gautam@codeaurora.org>,
	Asutosh Das <asutoshd@codeaurora.org>,
	Subhash Jadavani <subhashj@codeaurora.org>,
	Sayali Lokhande <sayalil@codeaurora.org>,
	Li Wei <liwei213@huawei.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Jaegeuk Kim <jaegeuk@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Alex Lemberg <Alex.Lemberg@sandisk.com>
Subject: Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now
Date: Thu, 20 Sep 2018 08:58:04 +0200	[thread overview]
Message-ID: <20180920065804.GC13761@lst.de> (raw)
In-Reply-To: <20180914015237.GC11059@ming.t460p>

On Fri, Sep 14, 2018 at 09:52:38AM +0800, Ming Lei wrote:
> However, in previous discussion, it is strongly objected to use
> per-driver/device .use_blk_mq switch, so not sure if this way can
> be accepted.

I don't like the per-driver switch as module_parameter at all and
we should never do that.  We had some exceptions for drivers to force
blk_mq (e.g. virtio), and given that I don't think we'll solve the
blk-mq runtime-pm issue for 4.19 and also don't want to revert the
default I think this patch is the best compromise for 4.19, with
a revert in 4.20 once we have runtime-pm for blk-mq.

So:

Acked-by: Christoph Hellwig <hch@lst.de>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	Bart Van Assche <Bart.VanAssche@wdc.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Stanislav Nijnikov <stanislav.nijnikov@wdc.com>,
	Evan Green <evgreen@chromium.org>,
	Vinayak Holikatti <vinholikatti@gmail.com>,
	Janek Kotas <jank@cadence.com>,
	Vivek Gautam <vivek.gautam@codeaurora.org>,
	Asutosh Das <asutoshd@codeaurora.org>,
	Subhash Jadavani <subhashj@codeaurora.org>,
	Sayali Lokhande <sayalil@codeaurora.org>,
	Li Wei <liwei213@huawei.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Jaegeu
Subject: Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now
Date: Thu, 20 Sep 2018 08:58:04 +0200	[thread overview]
Message-ID: <20180920065804.GC13761@lst.de> (raw)
In-Reply-To: <20180914015237.GC11059@ming.t460p>

On Fri, Sep 14, 2018 at 09:52:38AM +0800, Ming Lei wrote:
> However, in previous discussion, it is strongly objected to use
> per-driver/device .use_blk_mq switch, so not sure if this way can
> be accepted.

I don't like the per-driver switch as module_parameter at all and
we should never do that.  We had some exceptions for drivers to force
blk_mq (e.g. virtio), and given that I don't think we'll solve the
blk-mq runtime-pm issue for 4.19 and also don't want to revert the
default I think this patch is the best compromise for 4.19, with
a revert in 4.20 once we have runtime-pm for blk-mq.

So:

Acked-by: Christoph Hellwig <hch@lst.de>

  parent reply	other threads:[~2018-09-20  6:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-13 11:28 [PATCH RFC] scsi: ufs: Disable blk-mq for now Adrian Hunter
2018-09-13 12:05 ` Ming Lei
2018-09-13 12:05   ` Ming Lei
2018-09-13 12:15   ` Adrian Hunter
2018-09-13 12:15     ` Adrian Hunter
2018-09-14  1:52     ` Ming Lei
2018-09-14  1:52       ` Ming Lei
2018-09-14  6:17       ` Adrian Hunter
2018-09-14  6:17         ` Adrian Hunter
2018-09-14 13:03         ` Adrian Hunter
2018-09-14 13:03           ` Adrian Hunter
2018-09-20  6:58       ` Christoph Hellwig [this message]
2018-09-20  6:58         ` Christoph Hellwig
2018-09-21  1:59 ` Martin K. Petersen
2018-09-21  1:59   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180920065804.GC13761@lst.de \
    --to=hch@lst.de \
    --cc=Alex.Lemberg@sandisk.com \
    --cc=Bart.VanAssche@wdc.com \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=axboe@kernel.dk \
    --cc=bjorn.andersson@linaro.org \
    --cc=evgreen@chromium.org \
    --cc=jaegeuk@kernel.org \
    --cc=jank@cadence.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=liwei213@huawei.com \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    --cc=sayalil@codeaurora.org \
    --cc=stanislav.nijnikov@wdc.com \
    --cc=subhashj@codeaurora.org \
    --cc=vinholikatti@gmail.com \
    --cc=vivek.gautam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.