From: Daniel Lezcano <daniel.lezcano@linaro.org> To: Damien Le Moal <damien.lemoal@opensource.wdc.com>, Daniel Lezcano <daniel.lezcano@linexp.org>, rafael@kernel.org Cc: rui.zhang@intel.com, khilman@baylibre.com, abailon@baylibre.com, amitk@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" <linux-ide@vger.kernel.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v1 25/33] ata/drivers/ahci_imx: Switch to new of thermal API Date: Mon, 11 Jul 2022 11:14:06 +0200 [thread overview] Message-ID: <e50842cf-0179-7b70-3925-dacb4ce728ea@linaro.org> (raw) In-Reply-To: <a424890d-8647-48c5-68ab-742a95bb6865@opensource.wdc.com> On 11/07/2022 01:18, Damien Le Moal wrote: > On 7/11/22 06:24, Daniel Lezcano wrote: >> The thermal OF code has a new API allowing to migrate the OF >> initialization to a simpler approach. >> >> Use this new API. >> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linexp.org> >> --- >> drivers/ata/ahci_imx.c | 15 ++++++++++----- >> 1 file changed, 10 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c >> index 79aa9f285312..5ad9a890e71a 100644 >> --- a/drivers/ata/ahci_imx.c >> +++ b/drivers/ata/ahci_imx.c >> @@ -327,7 +327,7 @@ static int read_adc_sum(void *dev, u16 rtune_ctl_reg, void __iomem * mmio) >> } >> >> /* SATA AHCI temperature monitor */ >> -static int sata_ahci_read_temperature(void *dev, int *temp) >> +static int __sata_ahci_read_temperature(void *dev, int *temp) >> { >> u16 mpll_test_reg, rtune_ctl_reg, dac_ctl_reg, read_sum; >> u32 str1, str2, str3, str4; >> @@ -416,6 +416,11 @@ static int sata_ahci_read_temperature(void *dev, int *temp) >> return 0; >> } >> >> +static int sata_ahci_read_temperature(struct thermal_zone_device *tz, int *temp) >> +{ >> + return __sata_ahci_read_temperature(tz->devdata, temp); >> +} >> + >> static ssize_t sata_ahci_show_temp(struct device *dev, >> struct device_attribute *da, >> char *buf) >> @@ -423,14 +428,14 @@ static ssize_t sata_ahci_show_temp(struct device *dev, >> unsigned int temp = 0; >> int err; >> >> - err = sata_ahci_read_temperature(dev, &temp); >> + err = __sata_ahci_read_temperature(dev, &temp); >> if (err < 0) >> return err; >> >> return sprintf(buf, "%u\n", temp); >> } > > I do not see why the above changes are necessary. Please explain. sata_ahci_read_temperature() is used by sata_ahci_show_temp() also. So in order to change the function prototype for the get_temp ops which does not take a void* but a thermal_zone_device* structure, this function wraps the call. Do you prefer sata_ahci_read_temperature() becomes sata_ahci_get_temp() and keep __sata_ahci_read_temperature() name untouched ? >> >> -static const struct thermal_zone_of_device_ops fsl_sata_ahci_of_thermal_ops = { >> +static struct thermal_zone_device_ops fsl_sata_ahci_of_thermal_ops = { > > Why remove the const ? > >> .get_temp = sata_ahci_read_temperature, >> }; >> >> @@ -1131,8 +1136,8 @@ static int imx_ahci_probe(struct platform_device *pdev) >> ret = PTR_ERR(hwmon_dev); >> goto disable_clk; >> } >> - devm_thermal_zone_of_sensor_register(hwmon_dev, 0, hwmon_dev, >> - &fsl_sata_ahci_of_thermal_ops); >> + devm_thermal_of_zone_register(hwmon_dev, 0, hwmon_dev, >> + &fsl_sata_ahci_of_thermal_ops); > > This is the only change that seems necessary. > >> dev_info(dev, "%s: sensor 'sata_ahci'\n", dev_name(hwmon_dev)); >> } >> > > And it is hard to review a patch without the full series for context. > Please send all patches next time. > > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org> To: Damien Le Moal <damien.lemoal@opensource.wdc.com>, Daniel Lezcano <daniel.lezcano@linexp.org>, rafael@kernel.org Cc: rui.zhang@intel.com, khilman@baylibre.com, abailon@baylibre.com, amitk@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" <linux-ide@vger.kernel.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v1 25/33] ata/drivers/ahci_imx: Switch to new of thermal API Date: Mon, 11 Jul 2022 11:14:06 +0200 [thread overview] Message-ID: <e50842cf-0179-7b70-3925-dacb4ce728ea@linaro.org> (raw) In-Reply-To: <a424890d-8647-48c5-68ab-742a95bb6865@opensource.wdc.com> On 11/07/2022 01:18, Damien Le Moal wrote: > On 7/11/22 06:24, Daniel Lezcano wrote: >> The thermal OF code has a new API allowing to migrate the OF >> initialization to a simpler approach. >> >> Use this new API. >> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linexp.org> >> --- >> drivers/ata/ahci_imx.c | 15 ++++++++++----- >> 1 file changed, 10 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c >> index 79aa9f285312..5ad9a890e71a 100644 >> --- a/drivers/ata/ahci_imx.c >> +++ b/drivers/ata/ahci_imx.c >> @@ -327,7 +327,7 @@ static int read_adc_sum(void *dev, u16 rtune_ctl_reg, void __iomem * mmio) >> } >> >> /* SATA AHCI temperature monitor */ >> -static int sata_ahci_read_temperature(void *dev, int *temp) >> +static int __sata_ahci_read_temperature(void *dev, int *temp) >> { >> u16 mpll_test_reg, rtune_ctl_reg, dac_ctl_reg, read_sum; >> u32 str1, str2, str3, str4; >> @@ -416,6 +416,11 @@ static int sata_ahci_read_temperature(void *dev, int *temp) >> return 0; >> } >> >> +static int sata_ahci_read_temperature(struct thermal_zone_device *tz, int *temp) >> +{ >> + return __sata_ahci_read_temperature(tz->devdata, temp); >> +} >> + >> static ssize_t sata_ahci_show_temp(struct device *dev, >> struct device_attribute *da, >> char *buf) >> @@ -423,14 +428,14 @@ static ssize_t sata_ahci_show_temp(struct device *dev, >> unsigned int temp = 0; >> int err; >> >> - err = sata_ahci_read_temperature(dev, &temp); >> + err = __sata_ahci_read_temperature(dev, &temp); >> if (err < 0) >> return err; >> >> return sprintf(buf, "%u\n", temp); >> } > > I do not see why the above changes are necessary. Please explain. sata_ahci_read_temperature() is used by sata_ahci_show_temp() also. So in order to change the function prototype for the get_temp ops which does not take a void* but a thermal_zone_device* structure, this function wraps the call. Do you prefer sata_ahci_read_temperature() becomes sata_ahci_get_temp() and keep __sata_ahci_read_temperature() name untouched ? >> >> -static const struct thermal_zone_of_device_ops fsl_sata_ahci_of_thermal_ops = { >> +static struct thermal_zone_device_ops fsl_sata_ahci_of_thermal_ops = { > > Why remove the const ? > >> .get_temp = sata_ahci_read_temperature, >> }; >> >> @@ -1131,8 +1136,8 @@ static int imx_ahci_probe(struct platform_device *pdev) >> ret = PTR_ERR(hwmon_dev); >> goto disable_clk; >> } >> - devm_thermal_zone_of_sensor_register(hwmon_dev, 0, hwmon_dev, >> - &fsl_sata_ahci_of_thermal_ops); >> + devm_thermal_of_zone_register(hwmon_dev, 0, hwmon_dev, >> + &fsl_sata_ahci_of_thermal_ops); > > This is the only change that seems necessary. > >> dev_info(dev, "%s: sensor 'sata_ahci'\n", dev_name(hwmon_dev)); >> } >> > > And it is hard to review a patch without the full series for context. > Please send all patches next time. > > -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2022-07-11 9:15 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-10 21:23 [PATCH v1 00/33] New thermal OF code Daniel Lezcano 2022-07-10 21:23 ` [PATCH v1 01/33] thermal/of: Rework the thermal device tree initialization Daniel Lezcano 2022-07-12 2:40 ` Guenter Roeck 2022-07-10 21:23 ` [PATCH v1 02/33] thermal/of: Make new code and old code co-exist Daniel Lezcano 2022-07-10 21:23 ` [PATCH v1 03/33] thermal/drivers/rockchip: Switch to new of API Daniel Lezcano 2022-07-10 21:23 ` Daniel Lezcano 2022-07-10 21:23 ` Daniel Lezcano 2022-07-10 21:23 ` [PATCH v1 04/33] thermal/drivers/uniphier: " Daniel Lezcano 2022-07-10 21:23 ` Daniel Lezcano 2022-07-10 21:23 ` [PATCH v1 05/33] thermal/drivers/generic-adc: " Daniel Lezcano 2022-07-10 21:23 ` [PATCH v1 06/33] thermal/drivers/mmio: " Daniel Lezcano 2022-07-10 21:23 ` [PATCH v1 07/33] thermal/drivers/tegra: " Daniel Lezcano 2022-07-10 21:23 ` [PATCH v1 08/33] thermal/drivers/sun8i: " Daniel Lezcano 2022-07-10 21:23 ` Daniel Lezcano 2022-07-10 21:23 ` [PATCH v1 09/33] thermal/drivers/sprd: " Daniel Lezcano 2022-07-10 21:24 ` [PATCH v1 10/33] thermal/drivers/broadcom: " Daniel Lezcano 2022-07-10 21:24 ` Daniel Lezcano 2022-07-11 2:37 ` Florian Fainelli 2022-07-11 2:37 ` Florian Fainelli 2022-07-10 21:24 ` [PATCH v1 11/33] thermal/drivers/qcom: " Daniel Lezcano 2022-07-10 21:24 ` [PATCH v1 12/33] thermal/drivers/st: " Daniel Lezcano 2022-07-10 21:24 ` Daniel Lezcano 2022-07-10 21:24 ` [PATCH v1 13/33] thermal/drivers/amlogic: " Daniel Lezcano 2022-07-10 21:24 ` Daniel Lezcano 2022-07-10 21:24 ` [PATCH v1 14/33] thermal/drivers/armada: " Daniel Lezcano 2022-07-10 21:24 ` [PATCH v1 15/33] thermal/drivers/db8500: " Daniel Lezcano 2022-07-10 21:24 ` [PATCH v1 16/33] thermal/drivers/imx: " Daniel Lezcano 2022-07-10 21:24 ` Daniel Lezcano 2022-07-10 21:24 ` [PATCH v1 17/33] thermal/drivers/rcar: " Daniel Lezcano 2022-07-19 9:10 ` Niklas Söderlund 2022-07-22 19:34 ` Daniel Lezcano 2022-07-24 18:27 ` Daniel Lezcano 2022-07-24 19:00 ` Niklas Söderlund 2022-07-24 21:11 ` Daniel Lezcano 2022-07-24 22:39 ` Niklas Söderlund 2022-07-24 23:28 ` Niklas Söderlund 2022-07-25 10:00 ` Daniel Lezcano 2022-07-25 10:38 ` Niklas Söderlund 2022-07-25 21:09 ` Daniel Lezcano 2022-07-10 21:24 ` [PATCH v1 18/33] thermal/drivers/rzg2l: " Daniel Lezcano 2022-07-10 21:24 ` [PATCH v1 19/33] thermal/drivers/qoriq: " Daniel Lezcano 2022-07-10 21:24 ` [PATCH v1 20/33] thermal/drivers/mtk: " Daniel Lezcano 2022-07-10 21:24 ` Daniel Lezcano 2022-07-10 21:24 ` [PATCH v1 21/33] thermal/drivers/banggap: " Daniel Lezcano 2022-07-10 21:24 ` [PATCH v1 22/33] thermal/drivers/maxim: " Daniel Lezcano 2022-07-10 21:24 ` [PATCH v1 23/33] thermal/drivers/hisilicon: " Daniel Lezcano 2022-07-10 21:24 ` [PATCH v1 24/33] thermal/drivers/ti-soc: " Daniel Lezcano 2022-07-10 21:24 ` [PATCH v1 25/33] ata/drivers/ahci_imx: Switch to new of thermal API Daniel Lezcano 2022-07-10 21:24 ` Daniel Lezcano 2022-07-10 23:18 ` Damien Le Moal 2022-07-10 23:18 ` Damien Le Moal 2022-07-11 9:14 ` Daniel Lezcano [this message] 2022-07-11 9:14 ` Daniel Lezcano 2022-07-11 10:37 ` Damien Le Moal 2022-07-11 10:37 ` Damien Le Moal 2022-07-10 21:24 ` [PATCH v1 26/33] hwmon/drivers: " Daniel Lezcano 2022-07-13 13:43 ` Guenter Roeck 2022-07-10 21:24 ` [PATCH v1 27/33] iio/drivers/sun4i_gpadc: " Daniel Lezcano 2022-07-10 21:24 ` Daniel Lezcano 2022-07-11 7:52 ` Lars-Peter Clausen 2022-07-11 7:52 ` Lars-Peter Clausen 2022-07-10 21:24 ` [PATCH v1 28/33] input/drivers/touchscreen_sun4i: " Daniel Lezcano 2022-07-10 21:24 ` Daniel Lezcano 2022-07-10 21:24 ` Daniel Lezcano 2022-07-11 3:28 ` Dmitry Torokhov 2022-07-11 3:28 ` Dmitry Torokhov 2022-07-10 21:24 ` [PATCH v1 29/33] regulator/drivers/max8976: " Daniel Lezcano 2022-07-11 11:02 ` Mark Brown 2022-07-10 21:24 ` [PATCH v1 30/33] thermal/drivers/bcm2835: " Daniel Lezcano 2022-07-10 21:24 ` Daniel Lezcano 2022-07-11 2:40 ` Florian Fainelli 2022-07-11 2:40 ` Florian Fainelli 2022-07-10 21:24 ` [PATCH v1 31/33] thermal/drivers/samsung: " Daniel Lezcano 2022-07-10 21:24 ` Daniel Lezcano 2022-07-11 10:41 ` Krzysztof Kozlowski 2022-07-11 10:41 ` Krzysztof Kozlowski 2022-07-10 21:24 ` [PATCH v1 32/33] thermal/core: Move set_trip_temp ops to the sysfs code Daniel Lezcano 2022-07-10 21:24 ` [PATCH v1 33/33] thermal/of: Remove old OF code Daniel Lezcano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e50842cf-0179-7b70-3925-dacb4ce728ea@linaro.org \ --to=daniel.lezcano@linaro.org \ --cc=abailon@baylibre.com \ --cc=amitk@kernel.org \ --cc=damien.lemoal@opensource.wdc.com \ --cc=daniel.lezcano@linexp.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=khilman@baylibre.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=rafael@kernel.org \ --cc=rui.zhang@intel.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.