* [PATCH] soc/tegra: flowctrl: Fix error handling
@ 2017-04-11 3:40 ` Christophe JAILLET
0 siblings, 0 replies; 8+ messages in thread
From: Christophe JAILLET @ 2017-04-11 3:40 UTC (permalink / raw)
To: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w, jonathanh-DDmLM1+adcrQT0dZR+AlfA
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Christophe JAILLET
It is likely that returning returned by 'devm_ioremap_resource()' is
expected here instead of something related to 'base' which should be a
valid pointer at this point.
Fixes: 841fd94c43a4 ("soc/tegra: flowctrl: Add basic platform driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/soc/tegra/flowctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/tegra/flowctrl.c b/drivers/soc/tegra/flowctrl.c
index 0e345c05fc65..5433cc7a043e 100644
--- a/drivers/soc/tegra/flowctrl.c
+++ b/drivers/soc/tegra/flowctrl.c
@@ -157,7 +157,7 @@ static int tegra_flowctrl_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
tegra_flowctrl_base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(tegra_flowctrl_base))
- return PTR_ERR(base);
+ return PTR_ERR(tegra_flowctrl_base);
iounmap(base);
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] soc/tegra: flowctrl: Fix error handling
@ 2017-04-11 3:40 ` Christophe JAILLET
0 siblings, 0 replies; 8+ messages in thread
From: Christophe JAILLET @ 2017-04-11 3:40 UTC (permalink / raw)
To: thierry.reding, jonathanh
Cc: linux-tegra, linux-kernel, kernel-janitors, Christophe JAILLET
It is likely that returning returned by 'devm_ioremap_resource()' is
expected here instead of something related to 'base' which should be a
valid pointer at this point.
Fixes: 841fd94c43a4 ("soc/tegra: flowctrl: Add basic platform driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/soc/tegra/flowctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/tegra/flowctrl.c b/drivers/soc/tegra/flowctrl.c
index 0e345c05fc65..5433cc7a043e 100644
--- a/drivers/soc/tegra/flowctrl.c
+++ b/drivers/soc/tegra/flowctrl.c
@@ -157,7 +157,7 @@ static int tegra_flowctrl_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
tegra_flowctrl_base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(tegra_flowctrl_base))
- return PTR_ERR(base);
+ return PTR_ERR(tegra_flowctrl_base);
iounmap(base);
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] soc/tegra: flowctrl: Fix error handling
2017-04-11 3:40 ` Christophe JAILLET
(?)
@ 2017-04-11 7:15 ` Jon Hunter
-1 siblings, 0 replies; 8+ messages in thread
From: Jon Hunter @ 2017-04-11 7:15 UTC (permalink / raw)
To: Christophe JAILLET, thierry.reding
Cc: linux-tegra, linux-kernel, kernel-janitors
On 11/04/17 04:40, Christophe JAILLET wrote:
> It is likely that returning returned by 'devm_ioremap_resource()' is
> expected here instead of something related to 'base' which should be a
> valid pointer at this point.
>
> Fixes: 841fd94c43a4 ("soc/tegra: flowctrl: Add basic platform driver")
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/soc/tegra/flowctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/tegra/flowctrl.c b/drivers/soc/tegra/flowctrl.c
> index 0e345c05fc65..5433cc7a043e 100644
> --- a/drivers/soc/tegra/flowctrl.c
> +++ b/drivers/soc/tegra/flowctrl.c
> @@ -157,7 +157,7 @@ static int tegra_flowctrl_probe(struct platform_device *pdev)
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> tegra_flowctrl_base = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(tegra_flowctrl_base))
> - return PTR_ERR(base);
> + return PTR_ERR(tegra_flowctrl_base);
>
> iounmap(base);
Oops! Thanks for the fix.
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] soc/tegra: flowctrl: Fix error handling
@ 2017-04-11 7:15 ` Jon Hunter
0 siblings, 0 replies; 8+ messages in thread
From: Jon Hunter @ 2017-04-11 7:15 UTC (permalink / raw)
To: Christophe JAILLET, thierry.reding
Cc: linux-tegra, linux-kernel, kernel-janitors
On 11/04/17 04:40, Christophe JAILLET wrote:
> It is likely that returning returned by 'devm_ioremap_resource()' is
> expected here instead of something related to 'base' which should be a
> valid pointer at this point.
>
> Fixes: 841fd94c43a4 ("soc/tegra: flowctrl: Add basic platform driver")
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/soc/tegra/flowctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/tegra/flowctrl.c b/drivers/soc/tegra/flowctrl.c
> index 0e345c05fc65..5433cc7a043e 100644
> --- a/drivers/soc/tegra/flowctrl.c
> +++ b/drivers/soc/tegra/flowctrl.c
> @@ -157,7 +157,7 @@ static int tegra_flowctrl_probe(struct platform_device *pdev)
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> tegra_flowctrl_base = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(tegra_flowctrl_base))
> - return PTR_ERR(base);
> + return PTR_ERR(tegra_flowctrl_base);
>
> iounmap(base);
Oops! Thanks for the fix.
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] soc/tegra: flowctrl: Fix error handling
@ 2017-04-11 7:15 ` Jon Hunter
0 siblings, 0 replies; 8+ messages in thread
From: Jon Hunter @ 2017-04-11 7:15 UTC (permalink / raw)
To: Christophe JAILLET, thierry.reding
Cc: linux-tegra, linux-kernel, kernel-janitors
On 11/04/17 04:40, Christophe JAILLET wrote:
> It is likely that returning returned by 'devm_ioremap_resource()' is
> expected here instead of something related to 'base' which should be a
> valid pointer at this point.
>
> Fixes: 841fd94c43a4 ("soc/tegra: flowctrl: Add basic platform driver")
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/soc/tegra/flowctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/tegra/flowctrl.c b/drivers/soc/tegra/flowctrl.c
> index 0e345c05fc65..5433cc7a043e 100644
> --- a/drivers/soc/tegra/flowctrl.c
> +++ b/drivers/soc/tegra/flowctrl.c
> @@ -157,7 +157,7 @@ static int tegra_flowctrl_probe(struct platform_device *pdev)
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> tegra_flowctrl_base = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(tegra_flowctrl_base))
> - return PTR_ERR(base);
> + return PTR_ERR(tegra_flowctrl_base);
>
> iounmap(base);
Oops! Thanks for the fix.
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] soc/tegra: flowctrl: Fix error handling
2017-04-11 3:40 ` Christophe JAILLET
@ 2017-06-13 14:48 ` Thierry Reding
-1 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2017-06-13 14:48 UTC (permalink / raw)
To: Christophe JAILLET; +Cc: jonathanh, linux-tegra, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
On Tue, Apr 11, 2017 at 05:40:41AM +0200, Christophe JAILLET wrote:
> It is likely that returning returned by 'devm_ioremap_resource()' is
> expected here instead of something related to 'base' which should be a
> valid pointer at this point.
>
> Fixes: 841fd94c43a4 ("soc/tegra: flowctrl: Add basic platform driver")
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/soc/tegra/flowctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] soc/tegra: flowctrl: Fix error handling
@ 2017-06-13 14:48 ` Thierry Reding
0 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2017-06-13 14:48 UTC (permalink / raw)
To: Christophe JAILLET; +Cc: jonathanh, linux-tegra, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
On Tue, Apr 11, 2017 at 05:40:41AM +0200, Christophe JAILLET wrote:
> It is likely that returning returned by 'devm_ioremap_resource()' is
> expected here instead of something related to 'base' which should be a
> valid pointer at this point.
>
> Fixes: 841fd94c43a4 ("soc/tegra: flowctrl: Add basic platform driver")
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/soc/tegra/flowctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread