All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/doc: Add hflip/vflip property descriptions in msm
@ 2015-07-27 22:57 Jilai Wang
  2015-07-28  8:29   ` Daniel Vetter
  0 siblings, 1 reply; 4+ messages in thread
From: Jilai Wang @ 2015-07-27 22:57 UTC (permalink / raw)
  To: dri-devel; +Cc: linux-arm-msm, linux-kernel, robdclark, Jilai Wang

Add plane properties hflip/vflip which are used in MDP driver to flip
the input horizontally/vertically.

Signed-off-by: Jilai Wang <jilaiw@codeaurora.org>
---
 Documentation/DocBook/drm.tmpl | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
index d9f5613..bef6d34 100644
--- a/Documentation/DocBook/drm.tmpl
+++ b/Documentation/DocBook/drm.tmpl
@@ -3501,8 +3501,8 @@ void intel_crt_init(struct drm_device *dev)
 	<td valign="top" >TBD</td>
 	</tr>
 	<tr>
-	<td rowspan="3" valign="top" >msm</td>
-	<td rowspan="3" valign="top" >Generic</td>
+	<td rowspan="5" valign="top" >msm</td>
+	<td rowspan="5" valign="top" >Generic</td>
 	<td valign="top" >"premultiplied"</td>
 	<td valign="top" >ENUM</td>
 	<td valign="top" >{ "false", "true" }</td>
@@ -3523,6 +3523,20 @@ void intel_crt_init(struct drm_device *dev)
 	<td valign="top" >Plane</td>
 	<td valign="top" >property to set plane's z position during blending</td>
 	</tr>
+	<tr>
+	<td valign="top" >"hflip"</td>
+	<td valign="top" >ENUM</td>
+	<td valign="top" >{ "off", "on" }</td>
+	<td valign="top" >Plane</td>
+	<td valign="top" >property to flip the input horizontally</td>
+	</tr>
+	<tr>
+	<td valign="top" >"vflip"</td>
+	<td valign="top" >ENUM</td>
+	<td valign="top" >{ "off", "on" }</td>
+	<td valign="top" >Plane</td>
+	<td valign="top" >property to flip the input vertically</td>
+	</tr>
 	</tbody>
 	</table>
     </sect2>
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] drm/doc: Add hflip/vflip property descriptions in msm
  2015-07-27 22:57 [PATCH 1/2] drm/doc: Add hflip/vflip property descriptions in msm Jilai Wang
@ 2015-07-28  8:29   ` Daniel Vetter
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2015-07-28  8:29 UTC (permalink / raw)
  To: Jilai Wang; +Cc: linux-arm-msm, linux-kernel, dri-devel

On Mon, Jul 27, 2015 at 06:57:33PM -0400, Jilai Wang wrote:
> Add plane properties hflip/vflip which are used in MDP driver to flip
> the input horizontally/vertically.
> 
> Signed-off-by: Jilai Wang <jilaiw@codeaurora.org>

Is the existing rotation prop with flip masks not enough?
-Daniel

> ---
>  Documentation/DocBook/drm.tmpl | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> index d9f5613..bef6d34 100644
> --- a/Documentation/DocBook/drm.tmpl
> +++ b/Documentation/DocBook/drm.tmpl
> @@ -3501,8 +3501,8 @@ void intel_crt_init(struct drm_device *dev)
>  	<td valign="top" >TBD</td>
>  	</tr>
>  	<tr>
> -	<td rowspan="3" valign="top" >msm</td>
> -	<td rowspan="3" valign="top" >Generic</td>
> +	<td rowspan="5" valign="top" >msm</td>
> +	<td rowspan="5" valign="top" >Generic</td>
>  	<td valign="top" >"premultiplied"</td>
>  	<td valign="top" >ENUM</td>
>  	<td valign="top" >{ "false", "true" }</td>
> @@ -3523,6 +3523,20 @@ void intel_crt_init(struct drm_device *dev)
>  	<td valign="top" >Plane</td>
>  	<td valign="top" >property to set plane's z position during blending</td>
>  	</tr>
> +	<tr>
> +	<td valign="top" >"hflip"</td>
> +	<td valign="top" >ENUM</td>
> +	<td valign="top" >{ "off", "on" }</td>
> +	<td valign="top" >Plane</td>
> +	<td valign="top" >property to flip the input horizontally</td>
> +	</tr>
> +	<tr>
> +	<td valign="top" >"vflip"</td>
> +	<td valign="top" >ENUM</td>
> +	<td valign="top" >{ "off", "on" }</td>
> +	<td valign="top" >Plane</td>
> +	<td valign="top" >property to flip the input vertically</td>
> +	</tr>
>  	</tbody>
>  	</table>
>      </sect2>
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] drm/doc: Add hflip/vflip property descriptions in msm
@ 2015-07-28  8:29   ` Daniel Vetter
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2015-07-28  8:29 UTC (permalink / raw)
  To: Jilai Wang; +Cc: dri-devel, linux-arm-msm, linux-kernel

On Mon, Jul 27, 2015 at 06:57:33PM -0400, Jilai Wang wrote:
> Add plane properties hflip/vflip which are used in MDP driver to flip
> the input horizontally/vertically.
> 
> Signed-off-by: Jilai Wang <jilaiw@codeaurora.org>

Is the existing rotation prop with flip masks not enough?
-Daniel

> ---
>  Documentation/DocBook/drm.tmpl | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> index d9f5613..bef6d34 100644
> --- a/Documentation/DocBook/drm.tmpl
> +++ b/Documentation/DocBook/drm.tmpl
> @@ -3501,8 +3501,8 @@ void intel_crt_init(struct drm_device *dev)
>  	<td valign="top" >TBD</td>
>  	</tr>
>  	<tr>
> -	<td rowspan="3" valign="top" >msm</td>
> -	<td rowspan="3" valign="top" >Generic</td>
> +	<td rowspan="5" valign="top" >msm</td>
> +	<td rowspan="5" valign="top" >Generic</td>
>  	<td valign="top" >"premultiplied"</td>
>  	<td valign="top" >ENUM</td>
>  	<td valign="top" >{ "false", "true" }</td>
> @@ -3523,6 +3523,20 @@ void intel_crt_init(struct drm_device *dev)
>  	<td valign="top" >Plane</td>
>  	<td valign="top" >property to set plane's z position during blending</td>
>  	</tr>
> +	<tr>
> +	<td valign="top" >"hflip"</td>
> +	<td valign="top" >ENUM</td>
> +	<td valign="top" >{ "off", "on" }</td>
> +	<td valign="top" >Plane</td>
> +	<td valign="top" >property to flip the input horizontally</td>
> +	</tr>
> +	<tr>
> +	<td valign="top" >"vflip"</td>
> +	<td valign="top" >ENUM</td>
> +	<td valign="top" >{ "off", "on" }</td>
> +	<td valign="top" >Plane</td>
> +	<td valign="top" >property to flip the input vertically</td>
> +	</tr>
>  	</tbody>
>  	</table>
>      </sect2>
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] drm/doc: Add hflip/vflip property descriptions in msm
  2015-07-28  8:29   ` Daniel Vetter
  (?)
@ 2015-07-29 20:50   ` jilaiw
  -1 siblings, 0 replies; 4+ messages in thread
From: jilaiw @ 2015-07-29 20:50 UTC (permalink / raw)
  To: Jilai Wang, dri-devel, linux-arm-msm, linux-kernel

Thanks for this information, Daniel.
I will change it to use rotation prop in next patch.
> On Mon, Jul 27, 2015 at 06:57:33PM -0400, Jilai Wang wrote:
>> Add plane properties hflip/vflip which are used in MDP driver to flip
>> the input horizontally/vertically.
>>
>> Signed-off-by: Jilai Wang <jilaiw@codeaurora.org>
>
> Is the existing rotation prop with flip masks not enough?
> -Daniel
>
>> ---
>>  Documentation/DocBook/drm.tmpl | 18 ++++++++++++++++--
>>  1 file changed, 16 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/DocBook/drm.tmpl
>> b/Documentation/DocBook/drm.tmpl
>> index d9f5613..bef6d34 100644
>> --- a/Documentation/DocBook/drm.tmpl
>> +++ b/Documentation/DocBook/drm.tmpl
>> @@ -3501,8 +3501,8 @@ void intel_crt_init(struct drm_device *dev)
>>  	<td valign="top" >TBD</td>
>>  	</tr>
>>  	<tr>
>> -	<td rowspan="3" valign="top" >msm</td>
>> -	<td rowspan="3" valign="top" >Generic</td>
>> +	<td rowspan="5" valign="top" >msm</td>
>> +	<td rowspan="5" valign="top" >Generic</td>
>>  	<td valign="top" >"premultiplied"</td>
>>  	<td valign="top" >ENUM</td>
>>  	<td valign="top" >{ "false", "true" }</td>
>> @@ -3523,6 +3523,20 @@ void intel_crt_init(struct drm_device *dev)
>>  	<td valign="top" >Plane</td>
>>  	<td valign="top" >property to set plane's z position during
>> blending</td>
>>  	</tr>
>> +	<tr>
>> +	<td valign="top" >"hflip"</td>
>> +	<td valign="top" >ENUM</td>
>> +	<td valign="top" >{ "off", "on" }</td>
>> +	<td valign="top" >Plane</td>
>> +	<td valign="top" >property to flip the input horizontally</td>
>> +	</tr>
>> +	<tr>
>> +	<td valign="top" >"vflip"</td>
>> +	<td valign="top" >ENUM</td>
>> +	<td valign="top" >{ "off", "on" }</td>
>> +	<td valign="top" >Plane</td>
>> +	<td valign="top" >property to flip the input vertically</td>
>> +	</tr>
>>  	</tbody>
>>  	</table>
>>      </sect2>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-07-29 20:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-27 22:57 [PATCH 1/2] drm/doc: Add hflip/vflip property descriptions in msm Jilai Wang
2015-07-28  8:29 ` Daniel Vetter
2015-07-28  8:29   ` Daniel Vetter
2015-07-29 20:50   ` jilaiw

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.