Re: [Qemu-devel] [PATCH 12/14] target/mips: Implement segmentation control

[Yongbok Kim <yongbok.kim@imgtec.com>]

On 18/07/2017 12:55, James Hogan wrote:
> Implement the optional segmentation control feature in the virtual to
> physical address translation code.
> 
> The fixed legacy segment and xkphys handling is replaced with a dynamic
> layout based on the segmentation control registers (which should be set
> up even when the feature is not exposed to the guest).
> 
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Yongbok Kim <yongbok.kim@imgtec.com>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> ---
> Changes in v2:
> - Use hwaddr instead of target_ulong for physical addresses in
>   get_seg[ctl]_physical_address() (Yongbok).
> - Fix xkphys privilege control based on access mode (am) (Yongbok).
> - Fix xkphys TLB faults to use XTLB.
> ---
>  target/mips/helper.c | 177 +++++++++++++++++++++++++++++++++++---------
>  1 file changed, 142 insertions(+), 35 deletions(-)
> 

Reviewed-by: Yongbok Kim <yongbok.kim@imgtec.com>

Regards,
Yongbok