[PATCH] drm/amdkfd: To flush tlb for MMHUB of GFX9 series

[PATCH] drm/amdkfd: To flush tlb for MMHUB of GFX9 series

[Ji, Ruili]

From: Ruili Ji <ruiliji2@amd.com>

amdgpu: [mmhub0] no-retry page fault (src_id:0 ring:40 vmid:8 pasid:32769, for process test_basic pid 3305 thread test_basic pid 3305)
amdgpu: in page starting at address 0x00007ff990003000 from IH client 0x12 (VMC)
amdgpu: VM_L2_PROTECTION_FAULT_STATUS:0x00840051
amdgpu: Faulty UTCL2 client ID: MP1 (0x0)
amdgpu: MORE_FAULTS: 0x1
amdgpu: WALKER_ERROR: 0x0
amdgpu: PERMISSION_FAULTS: 0x5
amdgpu: MAPPING_ERROR: 0x0
amdgpu: RW: 0x1

When memory is allocated by kfd, no one triggers the tlb flush for MMHUB0.
There is page fault from MMHUB0.

Signed-off-by: Ruili Ji <ruiliji2@amd.com>
Change-Id: I97786f02849dd047703d6e8feff53916b307715c
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
index 1d0c9762ebfb..12fc822c0a92 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
@@ -739,7 +739,8 @@ int amdgpu_amdkfd_flush_gpu_tlb_pasid(struct amdgpu_device *adev,
 {
 	bool all_hub = false;
 
-	if (adev->family == AMDGPU_FAMILY_AI)
+	if (adev->family == AMDGPU_FAMILY_AI
+		|| adev->family == AMDGPU_FAMILY_RV)
 		all_hub = true;
 
 	return amdgpu_gmc_flush_gpu_tlb_pasid(adev, pasid, flush_type, all_hub);
-- 
2.25.1

Re: [PATCH] drm/amdkfd: To flush tlb for MMHUB of GFX9 series

[Alex Deucher]

Acked-by: Alex Deucher <alexander.deucher@amd.com>

On Mon, Jun 20, 2022 at 10:26 PM Ji, Ruili <ruili.ji@amd.com> wrote:
>
> From: Ruili Ji <ruiliji2@amd.com>
>
> amdgpu: [mmhub0] no-retry page fault (src_id:0 ring:40 vmid:8 pasid:32769, for process test_basic pid 3305 thread test_basic pid 3305)
> amdgpu: in page starting at address 0x00007ff990003000 from IH client 0x12 (VMC)
> amdgpu: VM_L2_PROTECTION_FAULT_STATUS:0x00840051
> amdgpu: Faulty UTCL2 client ID: MP1 (0x0)
> amdgpu: MORE_FAULTS: 0x1
> amdgpu: WALKER_ERROR: 0x0
> amdgpu: PERMISSION_FAULTS: 0x5
> amdgpu: MAPPING_ERROR: 0x0
> amdgpu: RW: 0x1
>
> When memory is allocated by kfd, no one triggers the tlb flush for MMHUB0.
> There is page fault from MMHUB0.
>
> Signed-off-by: Ruili Ji <ruiliji2@amd.com>
> Change-Id: I97786f02849dd047703d6e8feff53916b307715c
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> index 1d0c9762ebfb..12fc822c0a92 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> @@ -739,7 +739,8 @@ int amdgpu_amdkfd_flush_gpu_tlb_pasid(struct amdgpu_device *adev,
>  {
>         bool all_hub = false;
>
> -       if (adev->family == AMDGPU_FAMILY_AI)
> +       if (adev->family == AMDGPU_FAMILY_AI
> +               || adev->family == AMDGPU_FAMILY_RV)
>                 all_hub = true;
>
>         return amdgpu_gmc_flush_gpu_tlb_pasid(adev, pasid, flush_type, all_hub);
> --
> 2.25.1
>

Re: [PATCH] drm/amdkfd: To flush tlb for MMHUB of GFX9 series

[philip yang]

[-- Attachment #1: Type: text/html, Size: 2334 bytes --]