From: Paul Durrant <Paul.Durrant@citrix.com> To: Igor Druzhinin <igor.druzhinin@citrix.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org> Cc: "sstabellini@kernel.org" <sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com>, "mst@redhat.com" <mst@redhat.com>, "pbonzini@redhat.com" <pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH] xen-pvdevice: Introduce a simplistic xen-pvdevice save state Date: Thu, 8 Mar 2018 12:53:47 +0000 [thread overview] Message-ID: <e9d205b6139c4e338b5535fc6bed3a2a@AMSPEX02CL03.citrite.net> (raw) In-Reply-To: <1520513551-19851-1-git-send-email-igor.druzhinin@citrix.com> > -----Original Message----- > From: Igor Druzhinin [mailto:igor.druzhinin@citrix.com] > Sent: 08 March 2018 12:53 > To: qemu-devel@nongnu.org; xen-devel@lists.xenproject.org > Cc: sstabellini@kernel.org; Paul Durrant <Paul.Durrant@citrix.com>; Anthony > Perard <anthony.perard@citrix.com>; mst@redhat.com; > pbonzini@redhat.com; Igor Druzhinin <igor.druzhinin@citrix.com> > Subject: [PATCH] xen-pvdevice: Introduce a simplistic xen-pvdevice save > state > > This should help to avoid problems with accessing the device after > migration/resume without PV drivers. Older systems will acquire > the new record when migrated which should not change their state for > worse. > > Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com> Reviewed-by: Paul Durrant <paul.durrant@citrix.com> > --- > hw/i386/xen/xen_pvdevice.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/hw/i386/xen/xen_pvdevice.c b/hw/i386/xen/xen_pvdevice.c > index c093b34..ef22a03 100644 > --- a/hw/i386/xen/xen_pvdevice.c > +++ b/hw/i386/xen/xen_pvdevice.c > @@ -71,6 +71,16 @@ static const MemoryRegionOps xen_pv_mmio_ops = { > .endianness = DEVICE_LITTLE_ENDIAN, > }; > > +static const VMStateDescription vmstate_xen_pvdevice = { > + .name = "xen-pvdevice", > + .version_id = 1, > + .minimum_version_id = 1, > + .fields = (VMStateField[]) { > + VMSTATE_PCI_DEVICE(parent_obj, XenPVDevice), > + VMSTATE_END_OF_LIST() > + } > +}; > + > static void xen_pv_realize(PCIDevice *pci_dev, Error **errp) > { > XenPVDevice *d = XEN_PV_DEVICE(pci_dev); > @@ -120,6 +130,7 @@ static void xen_pv_class_init(ObjectClass *klass, void > *data) > k->class_id = PCI_CLASS_SYSTEM_OTHER; > dc->desc = "Xen PV Device"; > dc->props = xen_pv_props; > + dc->vmsd = &vmstate_xen_pvdevice; > } > > static const TypeInfo xen_pv_type_info = { > -- > 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Paul Durrant <Paul.Durrant@citrix.com> To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org> Cc: Anthony Perard <anthony.perard@citrix.com>, "pbonzini@redhat.com" <pbonzini@redhat.com>, Igor Druzhinin <igor.druzhinin@citrix.com>, "sstabellini@kernel.org" <sstabellini@kernel.org>, "mst@redhat.com" <mst@redhat.com> Subject: Re: [PATCH] xen-pvdevice: Introduce a simplistic xen-pvdevice save state Date: Thu, 8 Mar 2018 12:53:47 +0000 [thread overview] Message-ID: <e9d205b6139c4e338b5535fc6bed3a2a@AMSPEX02CL03.citrite.net> (raw) In-Reply-To: <1520513551-19851-1-git-send-email-igor.druzhinin@citrix.com> > -----Original Message----- > From: Igor Druzhinin [mailto:igor.druzhinin@citrix.com] > Sent: 08 March 2018 12:53 > To: qemu-devel@nongnu.org; xen-devel@lists.xenproject.org > Cc: sstabellini@kernel.org; Paul Durrant <Paul.Durrant@citrix.com>; Anthony > Perard <anthony.perard@citrix.com>; mst@redhat.com; > pbonzini@redhat.com; Igor Druzhinin <igor.druzhinin@citrix.com> > Subject: [PATCH] xen-pvdevice: Introduce a simplistic xen-pvdevice save > state > > This should help to avoid problems with accessing the device after > migration/resume without PV drivers. Older systems will acquire > the new record when migrated which should not change their state for > worse. > > Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com> Reviewed-by: Paul Durrant <paul.durrant@citrix.com> > --- > hw/i386/xen/xen_pvdevice.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/hw/i386/xen/xen_pvdevice.c b/hw/i386/xen/xen_pvdevice.c > index c093b34..ef22a03 100644 > --- a/hw/i386/xen/xen_pvdevice.c > +++ b/hw/i386/xen/xen_pvdevice.c > @@ -71,6 +71,16 @@ static const MemoryRegionOps xen_pv_mmio_ops = { > .endianness = DEVICE_LITTLE_ENDIAN, > }; > > +static const VMStateDescription vmstate_xen_pvdevice = { > + .name = "xen-pvdevice", > + .version_id = 1, > + .minimum_version_id = 1, > + .fields = (VMStateField[]) { > + VMSTATE_PCI_DEVICE(parent_obj, XenPVDevice), > + VMSTATE_END_OF_LIST() > + } > +}; > + > static void xen_pv_realize(PCIDevice *pci_dev, Error **errp) > { > XenPVDevice *d = XEN_PV_DEVICE(pci_dev); > @@ -120,6 +130,7 @@ static void xen_pv_class_init(ObjectClass *klass, void > *data) > k->class_id = PCI_CLASS_SYSTEM_OTHER; > dc->desc = "Xen PV Device"; > dc->props = xen_pv_props; > + dc->vmsd = &vmstate_xen_pvdevice; > } > > static const TypeInfo xen_pv_type_info = { > -- > 2.7.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-08 12:54 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-08 12:52 [Qemu-devel] [PATCH] xen-pvdevice: Introduce a simplistic xen-pvdevice save state Igor Druzhinin 2018-03-08 12:52 ` Igor Druzhinin 2018-03-08 12:53 ` Paul Durrant [this message] 2018-03-08 12:53 ` Paul Durrant 2018-03-09 17:14 ` [Qemu-devel] " Anthony PERARD 2018-03-09 17:14 ` Anthony PERARD 2018-03-11 21:05 ` Stefano Stabellini 2018-03-11 21:05 ` [Qemu-devel] " Stefano Stabellini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e9d205b6139c4e338b5535fc6bed3a2a@AMSPEX02CL03.citrite.net \ --to=paul.durrant@citrix.com \ --cc=anthony.perard@citrix.com \ --cc=igor.druzhinin@citrix.com \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.