All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH 1/4] target/mips: Add declarations for generic TCG helpers
Date: Sat, 19 Jun 2021 11:26:07 +0200	[thread overview]
Message-ID: <ea1ec188-d011-e8f2-7131-3946bfd6d963@amsat.org> (raw)
In-Reply-To: <a586a9e9-ea77-04da-f1f0-45d79d6eb626@linaro.org>

On 6/18/21 10:15 PM, Richard Henderson wrote:
> On 6/17/21 10:49 AM, Philippe Mathieu-Daudé wrote:
>> To be able to extract the microMIPS ISA and Code Compaction ASE
>> translation routines to different source files, declare few TCG
>> helpers which are also used by translate.c in "translate.h".
>>
>> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
>> ---
>>   target/mips/tcg/translate.h | 5 +++++
>>   target/mips/tcg/translate.c | 9 ++++-----
>>   2 files changed, 9 insertions(+), 5 deletions(-)
> 
> What patch set does this belong with?

micromips_translate.c.inc:1778:                    gen_ldxs(ctx, rs, rt,
rd);
micromips_translate.c.inc:1806:            gen_align(ctx, 32, rd, rs,
rt, extract32(ctx->opcode, 9, 2));
micromips_translate.c.inc:2859:            gen_addiupc(ctx, reg, offset,
0, 0);
mips16e_translate.c.inc:444:        gen_addiupc(ctx, ry, offset, 1,
extended);
mips16e_translate.c.inc:481:        gen_addiupc(ctx, rx, imm, 0, 1);
mips16e_translate.c.inc:682:        gen_addiupc(ctx, rx, ((uint8_t)
ctx->opcode) << 2, 0, 0);

>  It doesn't seem to match the next
> two patches, which don't create new compilation units.

Indeed. In a yet-to-be-posted later series they get renamed to .c,
becoming new units. It seemed simpler for me to do it that way, but
I'll see how to rearrange the patches. Ah, now I remember, rearranging
the patches modify the next 2 big patches (total 4k+ lines moved) you
already reviewed... So to keep your two R-b it is simpler to add this
one first.
What I can do is hold these patches and post them later with the
yet-to-be-posted series, *but* that breaks the "extract nanomips
from translate.c" which you already reviewed :/
It is hard to split this huge 25k+ spaghetti translate.c :(

> As far as it goes, the patch is fine...
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> 
> 
> r~
> 


  reply	other threads:[~2021-06-19  9:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 17:49 [PATCH 0/4] target/mips: Extract microMIPS ISA and Code Compaction ASE apart Philippe Mathieu-Daudé
2021-06-17 17:49 ` [PATCH 1/4] target/mips: Add declarations for generic TCG helpers Philippe Mathieu-Daudé
2021-06-18 20:15   ` Richard Henderson
2021-06-19  9:26     ` Philippe Mathieu-Daudé [this message]
2021-06-19 12:41       ` Richard Henderson
2021-06-28 16:33         ` Philippe Mathieu-Daudé
2021-06-28 21:31           ` Richard Henderson
2021-06-17 17:49 ` [PATCH 2/4] target/mips: Extract Code Compaction ASE translation routines Philippe Mathieu-Daudé
2021-06-17 17:49 ` [PATCH 3/4] target/mips: Extract the microMIPS ISA " Philippe Mathieu-Daudé
2021-06-17 17:49 ` [PATCH 4/4] target/mips: Add declarations for generic DSP TCG helpers Philippe Mathieu-Daudé
2021-06-17 18:25   ` Philippe Mathieu-Daudé
2021-06-18 20:17   ` Richard Henderson
2021-06-29  4:35 ` [PATCH 0/4] target/mips: Extract microMIPS ISA and Code Compaction ASE apart Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea1ec188-d011-e8f2-7131-3946bfd6d963@amsat.org \
    --to=f4bug@amsat.org \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --subject='Re: [PATCH 1/4] target/mips: Add declarations for generic TCG helpers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.