From: Xiao Guangrong <guangrong.xiao@gmail.com>
To: "Emilio G. Cota" <cota@braap.org>
Cc: kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com,
Xiao Guangrong <xiaoguangrong@tencent.com>,
qemu-devel@nongnu.org, peterx@redhat.com,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
quintela@redhat.com, wei.w.wang@intel.com,
jiang.biao2@zte.com.cn, pbonzini@redhat.com
Subject: Re: [PATCH v3 2/5] util: introduce threaded workqueue
Date: Tue, 27 Nov 2018 16:30:37 +0800 [thread overview]
Message-ID: <ebd5a6d4-22fa-4b2a-f9c2-cbbf5d97ff0d@gmail.com> (raw)
In-Reply-To: <20181126185504.GB6688@flamenco>
On 11/27/18 2:55 AM, Emilio G. Cota wrote:
> On Mon, Nov 26, 2018 at 15:57:25 +0800, Xiao Guangrong wrote:
>>
>>
>> On 11/23/18 7:02 PM, Dr. David Alan Gilbert wrote:
>>
>>>> +#include "qemu/osdep.h"
>>>> +#include "qemu/bitmap.h"
>>>> +#include "qemu/threaded-workqueue.h"
>>>> +
>>>> +#define SMP_CACHE_BYTES 64
>>>
>>> That's architecture dependent isn't it?
>>>
>>
>> Yes, it's arch dependent indeed.
>>
>> I just used 64 for simplification and i think it is <= 64 on most CPU arch-es
>> so that can work.
>>
>> Should i introduce statically defined CACHE LINE SIZE for all arch-es? :(
>
> No, at compile-time this is impossible to know.
>
> We do query this info at run-time though (see util/cacheinfo.c),
> but using that info here would complicate things too much.
I see.
>
> You can just give it a different name, and perhaps add a comment.
> See for instance what we do in qht.c with QHT_BUCKET_ALIGN.
That's really a good lesson to me, will follow it. :)
WARNING: multiple messages have this Message-ID (diff)
From: Xiao Guangrong <guangrong.xiao@gmail.com>
To: "Emilio G. Cota" <cota@braap.org>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
pbonzini@redhat.com, mst@redhat.com, mtosatti@redhat.com,
qemu-devel@nongnu.org, kvm@vger.kernel.org, peterx@redhat.com,
wei.w.wang@intel.com, jiang.biao2@zte.com.cn, eblake@redhat.com,
quintela@redhat.com, Xiao Guangrong <xiaoguangrong@tencent.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue
Date: Tue, 27 Nov 2018 16:30:37 +0800 [thread overview]
Message-ID: <ebd5a6d4-22fa-4b2a-f9c2-cbbf5d97ff0d@gmail.com> (raw)
In-Reply-To: <20181126185504.GB6688@flamenco>
On 11/27/18 2:55 AM, Emilio G. Cota wrote:
> On Mon, Nov 26, 2018 at 15:57:25 +0800, Xiao Guangrong wrote:
>>
>>
>> On 11/23/18 7:02 PM, Dr. David Alan Gilbert wrote:
>>
>>>> +#include "qemu/osdep.h"
>>>> +#include "qemu/bitmap.h"
>>>> +#include "qemu/threaded-workqueue.h"
>>>> +
>>>> +#define SMP_CACHE_BYTES 64
>>>
>>> That's architecture dependent isn't it?
>>>
>>
>> Yes, it's arch dependent indeed.
>>
>> I just used 64 for simplification and i think it is <= 64 on most CPU arch-es
>> so that can work.
>>
>> Should i introduce statically defined CACHE LINE SIZE for all arch-es? :(
>
> No, at compile-time this is impossible to know.
>
> We do query this info at run-time though (see util/cacheinfo.c),
> but using that info here would complicate things too much.
I see.
>
> You can just give it a different name, and perhaps add a comment.
> See for instance what we do in qht.c with QHT_BUCKET_ALIGN.
That's really a good lesson to me, will follow it. :)
next prev parent reply other threads:[~2018-11-27 8:30 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 7:20 [PATCH v3 0/5] migration: improve multithreads guangrong.xiao
2018-11-22 7:20 ` [Qemu-devel] " guangrong.xiao
2018-11-22 7:20 ` [PATCH v3 1/5] bitops: introduce change_bit_atomic guangrong.xiao
2018-11-22 7:20 ` [Qemu-devel] " guangrong.xiao
2018-11-23 10:23 ` Dr. David Alan Gilbert
2018-11-23 10:23 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-11-28 9:35 ` Juan Quintela
2018-11-28 9:35 ` [Qemu-devel] " Juan Quintela
2018-11-22 7:20 ` [PATCH v3 2/5] util: introduce threaded workqueue guangrong.xiao
2018-11-22 7:20 ` [Qemu-devel] " guangrong.xiao
2018-11-23 11:02 ` Dr. David Alan Gilbert
2018-11-23 11:02 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-11-26 7:57 ` Xiao Guangrong
2018-11-26 7:57 ` [Qemu-devel] " Xiao Guangrong
2018-11-26 10:56 ` Dr. David Alan Gilbert
2018-11-26 10:56 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-11-27 7:17 ` Xiao Guangrong
2018-11-27 7:17 ` [Qemu-devel] " Xiao Guangrong
2018-11-26 18:55 ` Emilio G. Cota
2018-11-26 18:55 ` [Qemu-devel] " Emilio G. Cota
2018-11-27 8:30 ` Xiao Guangrong [this message]
2018-11-27 8:30 ` Xiao Guangrong
2018-11-24 0:12 ` Emilio G. Cota
2018-11-24 0:12 ` [Qemu-devel] " Emilio G. Cota
2018-11-26 8:06 ` Xiao Guangrong
2018-11-26 8:06 ` [Qemu-devel] " Xiao Guangrong
2018-11-26 18:49 ` Emilio G. Cota
2018-11-26 18:49 ` [Qemu-devel] " Emilio G. Cota
2018-11-27 8:29 ` Xiao Guangrong
2018-11-27 8:29 ` [Qemu-devel] " Xiao Guangrong
2018-11-24 0:17 ` Emilio G. Cota
2018-11-24 0:17 ` [Qemu-devel] " Emilio G. Cota
2018-11-26 8:18 ` Xiao Guangrong
2018-11-26 8:18 ` [Qemu-devel] " Xiao Guangrong
2018-11-26 10:28 ` Paolo Bonzini
2018-11-26 10:28 ` [Qemu-devel] " Paolo Bonzini
2018-11-27 8:31 ` Xiao Guangrong
2018-11-27 8:31 ` [Qemu-devel] " Xiao Guangrong
2018-11-27 12:49 ` Christophe de Dinechin
2018-11-27 12:49 ` [Qemu-devel] " Christophe de Dinechin
2018-11-27 13:51 ` Paolo Bonzini
2018-11-27 13:51 ` [Qemu-devel] " Paolo Bonzini
2018-12-04 15:49 ` Christophe de Dinechin
2018-12-04 15:49 ` [Qemu-devel] " Christophe de Dinechin
2018-12-04 17:16 ` Paolo Bonzini
2018-12-04 17:16 ` [Qemu-devel] " Paolo Bonzini
2018-12-10 3:23 ` Xiao Guangrong
2018-12-10 3:23 ` [Qemu-devel] " Xiao Guangrong
2018-11-27 17:39 ` Emilio G. Cota
2018-11-27 17:39 ` [Qemu-devel] " Emilio G. Cota
2018-11-28 8:55 ` Xiao Guangrong
2018-11-28 8:55 ` [Qemu-devel] " Xiao Guangrong
2018-11-22 7:20 ` [PATCH v3 3/5] migration: use threaded workqueue for compression guangrong.xiao
2018-11-22 7:20 ` [Qemu-devel] " guangrong.xiao
2018-11-23 18:17 ` Dr. David Alan Gilbert
2018-11-23 18:17 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-11-23 18:22 ` Paolo Bonzini
2018-11-23 18:22 ` [Qemu-devel] " Paolo Bonzini
2018-11-23 18:29 ` Dr. David Alan Gilbert
2018-11-23 18:29 ` [Qemu-devel] " Dr. David Alan Gilbert
2018-11-26 8:00 ` Xiao Guangrong
2018-11-26 8:00 ` [Qemu-devel] " Xiao Guangrong
2018-11-22 7:20 ` [PATCH v3 4/5] migration: use threaded workqueue for decompression guangrong.xiao
2018-11-22 7:20 ` [Qemu-devel] " guangrong.xiao
2018-11-22 7:20 ` [PATCH v3 5/5] tests: add threaded-workqueue-bench guangrong.xiao
2018-11-22 7:20 ` [Qemu-devel] " guangrong.xiao
2018-11-22 21:25 ` [PATCH v3 0/5] migration: improve multithreads no-reply
2018-11-22 21:25 ` [Qemu-devel] " no-reply
2018-11-22 21:35 ` no-reply
2018-11-22 21:35 ` [Qemu-devel] " no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebd5a6d4-22fa-4b2a-f9c2-cbbf5d97ff0d@gmail.com \
--to=guangrong.xiao@gmail.com \
--cc=cota@braap.org \
--cc=dgilbert@redhat.com \
--cc=jiang.biao2@zte.com.cn \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=wei.w.wang@intel.com \
--cc=xiaoguangrong@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.