From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Jeongtae Park <jtp.park@samsung.com>,
Kamil Debski <kamil@wypas.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [media] s5p-mfc: Adjust a null pointer check in four functions
Date: Tue, 12 Sep 2017 22:33:16 +0200 [thread overview]
Message-ID: <ecb9823b-007c-f2c2-29bb-fbd08429385c@users.sourceforge.net> (raw)
In-Reply-To: <ee8ba7fd-1de4-b1b9-8aa0-130c86c38f30@samsung.com>
> Generating patch is only part of the story,
I can follow this view in principle.
> it seems the patch is not sent properly
I got an other impression.
> and tags which should be in SMTP header end up in the message body.
I agree that extra message fields were presented by the git software for
a reason.
You might have got other opinions about the original reason (than me).
> I think there would not be such issues if you have used git
> format-patch + git send-email.
I have got also doubts about your corresponding expectations when you
would find
the proposed commit message itself acceptable (besides the small source
code changes).
> I normally do amend things like this while applying,
That is interesting.
> I will do that this time as well.
Such an action can also be nice.
> It's already too much time wasted for such a dubious patch.
A bit of time is needed to resolve a temporary disagreement.
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [media] s5p-mfc: Adjust a null pointer check in four functions
Date: Tue, 12 Sep 2017 20:33:16 +0000 [thread overview]
Message-ID: <ecb9823b-007c-f2c2-29bb-fbd08429385c@users.sourceforge.net> (raw)
In-Reply-To: <ee8ba7fd-1de4-b1b9-8aa0-130c86c38f30@samsung.com>
> Generating patch is only part of the story,
I can follow this view in principle.
> it seems the patch is not sent properly
I got an other impression.
> and tags which should be in SMTP header end up in the message body.
I agree that extra message fields were presented by the git software for
a reason.
You might have got other opinions about the original reason (than me).
> I think there would not be such issues if you have used git
> format-patch + git send-email.
I have got also doubts about your corresponding expectations when you
would find
the proposed commit message itself acceptable (besides the small source
code changes).
> I normally do amend things like this while applying,
That is interesting.
> I will do that this time as well.
Such an action can also be nice.
> It's already too much time wasted for such a dubious patch.
A bit of time is needed to resolve a temporary disagreement.
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: elfring@users.sourceforge.net (SF Markus Elfring)
To: linux-arm-kernel@lists.infradead.org
Subject: [media] s5p-mfc: Adjust a null pointer check in four functions
Date: Tue, 12 Sep 2017 22:33:16 +0200 [thread overview]
Message-ID: <ecb9823b-007c-f2c2-29bb-fbd08429385c@users.sourceforge.net> (raw)
In-Reply-To: <ee8ba7fd-1de4-b1b9-8aa0-130c86c38f30@samsung.com>
> Generating patch is only part of the story,
I can follow this view in principle.
> it seems the patch is not sent properly
I got an other impression.
> and tags which should be in SMTP header end up in the message body.
I agree that extra message fields were presented by the git software for
a reason.
You might have got other opinions about the original reason (than me).
> I think there would not be such issues if you have used git
> format-patch + git send-email.
I have got also doubts about your corresponding expectations when you
would find
the proposed commit message itself acceptable (besides the small source
code changes).
> I normally do amend things like this while applying,
That is interesting.
> I will do that this time as well.
Such an action can also be nice.
> It's already too much time wasted for such a dubious patch.
A bit of time is needed to resolve a temporary disagreement.
Regards,
Markus
next prev parent reply other threads:[~2017-09-12 20:34 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 20:50 [PATCH 0/3] S5P MFC: Adjustments for five function implementations SF Markus Elfring
2017-09-08 20:50 ` SF Markus Elfring
2017-09-08 20:50 ` SF Markus Elfring
2017-09-08 20:51 ` [PATCH 1/3] [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe() SF Markus Elfring
2017-09-08 20:51 ` SF Markus Elfring
2017-09-08 20:51 ` [PATCH 1/3] [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe SF Markus Elfring
[not found] ` <CGME20170911091439epcas1p3f8b62f55cae4255d250b1fe990fbf1ff@epcas1p3.samsung.com>
2017-09-11 9:14 ` [PATCH 1/3] [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe() Sylwester Nawrocki
2017-09-11 9:14 ` Sylwester Nawrocki
2017-09-11 9:14 ` [PATCH 1/3] [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_p Sylwester Nawrocki
2017-09-11 19:34 ` [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe() SF Markus Elfring
2017-09-11 19:34 ` SF Markus Elfring
2017-09-11 19:34 ` SF Markus Elfring
2017-09-08 20:52 ` [PATCH 2/3] [media] s5p-mfc: Improve a size determination in s5p_mfc_alloc_memdev() SF Markus Elfring
2017-09-08 20:52 ` SF Markus Elfring
2017-09-08 20:52 ` SF Markus Elfring
[not found] ` <CGME20170911091700epcas1p1bd85f95a6b776581ad4cd6f3108d09ba@epcas1p1.samsung.com>
2017-09-11 9:16 ` Sylwester Nawrocki
2017-09-11 9:16 ` Sylwester Nawrocki
2017-09-11 9:16 ` Sylwester Nawrocki
2017-09-08 20:53 ` [PATCH 3/3] [media] s5p-mfc: Adjust a null pointer check in four functions SF Markus Elfring
2017-09-08 20:53 ` SF Markus Elfring
2017-09-08 20:53 ` SF Markus Elfring
[not found] ` <CGME20170911092134epcas2p1a1b11c056b52d68c3b0e4ea2e1e8f758@epcas2p1.samsung.com>
2017-09-11 9:21 ` Sylwester Nawrocki
2017-09-11 9:21 ` Sylwester Nawrocki
2017-09-11 9:21 ` Sylwester Nawrocki
2017-09-11 19:21 ` SF Markus Elfring
2017-09-11 19:21 ` SF Markus Elfring
2017-09-11 19:21 ` SF Markus Elfring
2017-09-12 13:21 ` Sylwester Nawrocki
2017-09-12 13:21 ` Sylwester Nawrocki
2017-09-12 13:21 ` Sylwester Nawrocki
2017-09-12 15:00 ` SF Markus Elfring
2017-09-12 15:00 ` SF Markus Elfring
2017-09-12 15:00 ` SF Markus Elfring
2017-09-12 17:41 ` Sylwester Nawrocki
2017-09-12 17:41 ` Sylwester Nawrocki
2017-09-12 17:41 ` Sylwester Nawrocki
2017-09-12 20:33 ` SF Markus Elfring [this message]
2017-09-12 20:33 ` SF Markus Elfring
2017-09-12 20:33 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecb9823b-007c-f2c2-29bb-fbd08429385c@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=a.hajda@samsung.com \
--cc=jtp.park@samsung.com \
--cc=kamil@wypas.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.