* [PATCH] drm: tidss: Fix pixel format definition
@ 2022-12-02 0:18 Randolph Sapp
2022-12-02 17:52 ` Andrew Davis
2022-12-16 8:16 ` Tomi Valkeinen
0 siblings, 2 replies; 4+ messages in thread
From: Randolph Sapp @ 2022-12-02 0:18 UTC (permalink / raw)
To: jyri.sarha, tomba; +Cc: Randolph Sapp, dri-devel, a-bhatia1
There was a long-standing bug from a typo that created 2 ARGB1555 and
ABGR1555 pixel format entries. Weston 10 has a sanity check that alerted
me to this issue.
According to the Supported Pixel Data formats table we have the later
entries should have been for Alpha-X instead.
Signed-off-by: Randolph Sapp <rs@ti.com>
---
drivers/gpu/drm/tidss/tidss_dispc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c
index ad93acc9abd2..16301bdfead1 100644
--- a/drivers/gpu/drm/tidss/tidss_dispc.c
+++ b/drivers/gpu/drm/tidss/tidss_dispc.c
@@ -1858,8 +1858,8 @@ static const struct {
{ DRM_FORMAT_XBGR4444, 0x21, },
{ DRM_FORMAT_RGBX4444, 0x22, },
- { DRM_FORMAT_ARGB1555, 0x25, },
- { DRM_FORMAT_ABGR1555, 0x26, },
+ { DRM_FORMAT_XRGB1555, 0x25, },
+ { DRM_FORMAT_XBGR1555, 0x26, },
{ DRM_FORMAT_XRGB8888, 0x27, },
{ DRM_FORMAT_XBGR8888, 0x28, },
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm: tidss: Fix pixel format definition
2022-12-02 0:18 [PATCH] drm: tidss: Fix pixel format definition Randolph Sapp
@ 2022-12-02 17:52 ` Andrew Davis
2022-12-05 5:24 ` Aradhya Bhatia
2022-12-16 8:16 ` Tomi Valkeinen
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Davis @ 2022-12-02 17:52 UTC (permalink / raw)
To: Randolph Sapp, jyri.sarha, tomba; +Cc: a-bhatia1, dri-devel
On 12/1/22 6:18 PM, Randolph Sapp wrote:
> There was a long-standing bug from a typo that created 2 ARGB1555 and
> ABGR1555 pixel format entries. Weston 10 has a sanity check that alerted
> me to this issue.
>
> According to the Supported Pixel Data formats table we have the later
> entries should have been for Alpha-X instead.
>
Fixes 32a1795f57eecc
Acked-by: Andrew Davis <afd@ti.com>
> Signed-off-by: Randolph Sapp <rs@ti.com>
> ---
> drivers/gpu/drm/tidss/tidss_dispc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c
> index ad93acc9abd2..16301bdfead1 100644
> --- a/drivers/gpu/drm/tidss/tidss_dispc.c
> +++ b/drivers/gpu/drm/tidss/tidss_dispc.c
> @@ -1858,8 +1858,8 @@ static const struct {
> { DRM_FORMAT_XBGR4444, 0x21, },
> { DRM_FORMAT_RGBX4444, 0x22, },
>
> - { DRM_FORMAT_ARGB1555, 0x25, },
> - { DRM_FORMAT_ABGR1555, 0x26, },
> + { DRM_FORMAT_XRGB1555, 0x25, },
> + { DRM_FORMAT_XBGR1555, 0x26, },
>
> { DRM_FORMAT_XRGB8888, 0x27, },
> { DRM_FORMAT_XBGR8888, 0x28, },
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm: tidss: Fix pixel format definition
2022-12-02 17:52 ` Andrew Davis
@ 2022-12-05 5:24 ` Aradhya Bhatia
0 siblings, 0 replies; 4+ messages in thread
From: Aradhya Bhatia @ 2022-12-05 5:24 UTC (permalink / raw)
To: Andrew Davis, Randolph Sapp, jyri.sarha, tomba; +Cc: dri-devel
On 02-Dec-22 23:22, Andrew Davis wrote:
> On 12/1/22 6:18 PM, Randolph Sapp wrote:
>> There was a long-standing bug from a typo that created 2 ARGB1555 and
>> ABGR1555 pixel format entries. Weston 10 has a sanity check that alerted
>> me to this issue.
>>
>> According to the Supported Pixel Data formats table we have the later
>> entries should have been for Alpha-X instead.
>>
>
> Fixes 32a1795f57eecc
>
> Acked-by: Andrew Davis <afd@ti.com>
>
>> Signed-off-by: Randolph Sapp <rs@ti.com>
Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>
>> ---
>> drivers/gpu/drm/tidss/tidss_dispc.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c
>> b/drivers/gpu/drm/tidss/tidss_dispc.c
>> index ad93acc9abd2..16301bdfead1 100644
>> --- a/drivers/gpu/drm/tidss/tidss_dispc.c
>> +++ b/drivers/gpu/drm/tidss/tidss_dispc.c
>> @@ -1858,8 +1858,8 @@ static const struct {
>> { DRM_FORMAT_XBGR4444, 0x21, },
>> { DRM_FORMAT_RGBX4444, 0x22, },
>> - { DRM_FORMAT_ARGB1555, 0x25, },
>> - { DRM_FORMAT_ABGR1555, 0x26, },
>> + { DRM_FORMAT_XRGB1555, 0x25, },
>> + { DRM_FORMAT_XBGR1555, 0x26, },
>> { DRM_FORMAT_XRGB8888, 0x27, },
>> { DRM_FORMAT_XBGR8888, 0x28, },
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: tidss: Fix pixel format definition
2022-12-02 0:18 [PATCH] drm: tidss: Fix pixel format definition Randolph Sapp
2022-12-02 17:52 ` Andrew Davis
@ 2022-12-16 8:16 ` Tomi Valkeinen
1 sibling, 0 replies; 4+ messages in thread
From: Tomi Valkeinen @ 2022-12-16 8:16 UTC (permalink / raw)
To: Randolph Sapp, jyri.sarha; +Cc: dri-devel, a-bhatia1
On 02/12/2022 02:18, Randolph Sapp wrote:
> There was a long-standing bug from a typo that created 2 ARGB1555 and
> ABGR1555 pixel format entries. Weston 10 has a sanity check that alerted
> me to this issue.
>
> According to the Supported Pixel Data formats table we have the later
> entries should have been for Alpha-X instead.
>
> Signed-off-by: Randolph Sapp <rs@ti.com>
> ---
> drivers/gpu/drm/tidss/tidss_dispc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c
> index ad93acc9abd2..16301bdfead1 100644
> --- a/drivers/gpu/drm/tidss/tidss_dispc.c
> +++ b/drivers/gpu/drm/tidss/tidss_dispc.c
> @@ -1858,8 +1858,8 @@ static const struct {
> { DRM_FORMAT_XBGR4444, 0x21, },
> { DRM_FORMAT_RGBX4444, 0x22, },
>
> - { DRM_FORMAT_ARGB1555, 0x25, },
> - { DRM_FORMAT_ABGR1555, 0x26, },
> + { DRM_FORMAT_XRGB1555, 0x25, },
> + { DRM_FORMAT_XBGR1555, 0x26, },
>
> { DRM_FORMAT_XRGB8888, 0x27, },
> { DRM_FORMAT_XBGR8888, 0x28, },
Thanks, I'll apply to drm-misc.
Tomi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-16 11:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-02 0:18 [PATCH] drm: tidss: Fix pixel format definition Randolph Sapp
2022-12-02 17:52 ` Andrew Davis
2022-12-05 5:24 ` Aradhya Bhatia
2022-12-16 8:16 ` Tomi Valkeinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.