From: Johannes Berg <johannes@sipsolutions.net>
To: Balaji Pothunoori <bpothuno@codeaurora.org>, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org,
Ashok Raj Nagarajan <arnagara@codeaurora.org>
Subject: Re: [PATCH 2/3] mac80211: store tx power value from user to station
Date: Fri, 25 Jan 2019 13:34:21 +0100 [thread overview]
Message-ID: <ecef4536f2b9f08195e0da2d00f67f33ee66bdbd.camel@sipsolutions.net> (raw)
In-Reply-To: <1547724247-11481-1-git-send-email-bpothuno@codeaurora.org>
On Thu, 2019-01-17 at 16:54 +0530, Balaji Pothunoori wrote:
>
> + * @txpwr: indicates the tx power, in mBm, to be used when sending data frames
> + * to the STA.
> + * @type: In particular if TPC %type is NL80211_TX_POWER_LIMITED then txpwr will
> + * be less than or equal to specified from userspace, whereas if TPC %type
> + * is NL80211_TX_POWER_AUTOMATIC then it indicates default txpwr.
> + * NL80211_TX_POWER_FIXED is not a valid configuration option for
> + * per peer TPC.
Same comment here wrt. txpower_type or so.
> +TRACE_EVENT(drv_sta_set_txpwr,
> + TP_PROTO(struct ieee80211_local *local,
> + struct ieee80211_sub_if_data *sdata,
> + struct ieee80211_sta *sta),
> +
> + TP_ARGS(local, sdata, sta),
> +
> + TP_STRUCT__entry(
> + LOCAL_ENTRY
> + VIF_ENTRY
> + STA_ENTRY
> + __field(s16, txpwr)
> + ),
> +
> + TP_fast_assign(
> + LOCAL_ASSIGN;
> + VIF_ASSIGN;
> + STA_ASSIGN;
> + __entry->txpwr = sta->txpwr;
> + ),
Include the type as well?
OTOH, is this whole business with the type even needed everywhere?
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Balaji Pothunoori <bpothuno@codeaurora.org>, ath10k@lists.infradead.org
Cc: Ashok Raj Nagarajan <arnagara@codeaurora.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] mac80211: store tx power value from user to station
Date: Fri, 25 Jan 2019 13:34:21 +0100 [thread overview]
Message-ID: <ecef4536f2b9f08195e0da2d00f67f33ee66bdbd.camel@sipsolutions.net> (raw)
In-Reply-To: <1547724247-11481-1-git-send-email-bpothuno@codeaurora.org>
On Thu, 2019-01-17 at 16:54 +0530, Balaji Pothunoori wrote:
>
> + * @txpwr: indicates the tx power, in mBm, to be used when sending data frames
> + * to the STA.
> + * @type: In particular if TPC %type is NL80211_TX_POWER_LIMITED then txpwr will
> + * be less than or equal to specified from userspace, whereas if TPC %type
> + * is NL80211_TX_POWER_AUTOMATIC then it indicates default txpwr.
> + * NL80211_TX_POWER_FIXED is not a valid configuration option for
> + * per peer TPC.
Same comment here wrt. txpower_type or so.
> +TRACE_EVENT(drv_sta_set_txpwr,
> + TP_PROTO(struct ieee80211_local *local,
> + struct ieee80211_sub_if_data *sdata,
> + struct ieee80211_sta *sta),
> +
> + TP_ARGS(local, sdata, sta),
> +
> + TP_STRUCT__entry(
> + LOCAL_ENTRY
> + VIF_ENTRY
> + STA_ENTRY
> + __field(s16, txpwr)
> + ),
> +
> + TP_fast_assign(
> + LOCAL_ASSIGN;
> + VIF_ASSIGN;
> + STA_ASSIGN;
> + __entry->txpwr = sta->txpwr;
> + ),
Include the type as well?
OTOH, is this whole business with the type even needed everywhere?
johannes
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2019-01-25 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 11:24 [PATCH 2/3] mac80211: store tx power value from user to station Balaji Pothunoori
2019-01-17 11:24 ` Balaji Pothunoori
2019-01-25 12:34 ` Johannes Berg [this message]
2019-01-25 12:34 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecef4536f2b9f08195e0da2d00f67f33ee66bdbd.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arnagara@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=bpothuno@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.