* [PATCH v2] hw/virtio: Document *_should_notify() are called within rcu_read_lock()
@ 2021-05-23 9:40 Philippe Mathieu-Daudé
2021-06-05 19:06 ` Laurent Vivier
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-05-23 9:40 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Philippe Mathieu-Daudé, Michael S. Tsirkin
Such comments make reviewing this file somehow easier.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2: only one space before end of comment (mst)
---
hw/virtio/virtio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index e02544b2df7..130e3568409 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -2449,6 +2449,7 @@ static void virtio_set_isr(VirtIODevice *vdev, int value)
}
}
+/* Called within rcu_read_lock(). */
static bool virtio_split_should_notify(VirtIODevice *vdev, VirtQueue *vq)
{
uint16_t old, new;
@@ -2485,6 +2486,7 @@ static bool vring_packed_need_event(VirtQueue *vq, bool wrap,
return vring_need_event(off, new, old);
}
+/* Called within rcu_read_lock(). */
static bool virtio_packed_should_notify(VirtIODevice *vdev, VirtQueue *vq)
{
VRingPackedDescEvent e;
--
2.26.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] hw/virtio: Document *_should_notify() are called within rcu_read_lock()
2021-05-23 9:40 [PATCH v2] hw/virtio: Document *_should_notify() are called within rcu_read_lock() Philippe Mathieu-Daudé
@ 2021-06-05 19:06 ` Laurent Vivier
2021-06-14 10:42 ` Philippe Mathieu-Daudé
2021-06-21 10:06 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2021-06-05 19:06 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: qemu-trivial, Michael S. Tsirkin
Le 23/05/2021 à 11:40, Philippe Mathieu-Daudé a écrit :
> Such comments make reviewing this file somehow easier.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: only one space before end of comment (mst)
> ---
> hw/virtio/virtio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index e02544b2df7..130e3568409 100644
> --- a/hw/virtio/virtio.c
> +++ b/hw/virtio/virtio.c
> @@ -2449,6 +2449,7 @@ static void virtio_set_isr(VirtIODevice *vdev, int value)
> }
> }
>
> +/* Called within rcu_read_lock(). */
> static bool virtio_split_should_notify(VirtIODevice *vdev, VirtQueue *vq)
> {
> uint16_t old, new;
> @@ -2485,6 +2486,7 @@ static bool vring_packed_need_event(VirtQueue *vq, bool wrap,
> return vring_need_event(off, new, old);
> }
>
> +/* Called within rcu_read_lock(). */
> static bool virtio_packed_should_notify(VirtIODevice *vdev, VirtQueue *vq)
> {
> VRingPackedDescEvent e;
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] hw/virtio: Document *_should_notify() are called within rcu_read_lock()
2021-05-23 9:40 [PATCH v2] hw/virtio: Document *_should_notify() are called within rcu_read_lock() Philippe Mathieu-Daudé
2021-06-05 19:06 ` Laurent Vivier
@ 2021-06-14 10:42 ` Philippe Mathieu-Daudé
2021-06-21 10:06 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-06-14 10:42 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-trivial, qemu-devel
Hi Michael,
On 5/23/21 11:40 AM, Philippe Mathieu-Daudé wrote:
> Such comments make reviewing this file somehow easier.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: only one space before end of comment (mst)
Are you OK if this patch is queued via trivial@?
> ---
> hw/virtio/virtio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index e02544b2df7..130e3568409 100644
> --- a/hw/virtio/virtio.c
> +++ b/hw/virtio/virtio.c
> @@ -2449,6 +2449,7 @@ static void virtio_set_isr(VirtIODevice *vdev, int value)
> }
> }
>
> +/* Called within rcu_read_lock(). */
> static bool virtio_split_should_notify(VirtIODevice *vdev, VirtQueue *vq)
> {
> uint16_t old, new;
> @@ -2485,6 +2486,7 @@ static bool vring_packed_need_event(VirtQueue *vq, bool wrap,
> return vring_need_event(off, new, old);
> }
>
> +/* Called within rcu_read_lock(). */
> static bool virtio_packed_should_notify(VirtIODevice *vdev, VirtQueue *vq)
> {
> VRingPackedDescEvent e;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] hw/virtio: Document *_should_notify() are called within rcu_read_lock()
2021-05-23 9:40 [PATCH v2] hw/virtio: Document *_should_notify() are called within rcu_read_lock() Philippe Mathieu-Daudé
2021-06-05 19:06 ` Laurent Vivier
2021-06-14 10:42 ` Philippe Mathieu-Daudé
@ 2021-06-21 10:06 ` Philippe Mathieu-Daudé
2021-07-06 10:04 ` Philippe Mathieu-Daudé
2 siblings, 1 reply; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-06-21 10:06 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Michael S. Tsirkin
ping?
On 5/23/21 11:40 AM, Philippe Mathieu-Daudé wrote:
> Such comments make reviewing this file somehow easier.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: only one space before end of comment (mst)
> ---
> hw/virtio/virtio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index e02544b2df7..130e3568409 100644
> --- a/hw/virtio/virtio.c
> +++ b/hw/virtio/virtio.c
> @@ -2449,6 +2449,7 @@ static void virtio_set_isr(VirtIODevice *vdev, int value)
> }
> }
>
> +/* Called within rcu_read_lock(). */
> static bool virtio_split_should_notify(VirtIODevice *vdev, VirtQueue *vq)
> {
> uint16_t old, new;
> @@ -2485,6 +2486,7 @@ static bool vring_packed_need_event(VirtQueue *vq, bool wrap,
> return vring_need_event(off, new, old);
> }
>
> +/* Called within rcu_read_lock(). */
> static bool virtio_packed_should_notify(VirtIODevice *vdev, VirtQueue *vq)
> {
> VRingPackedDescEvent e;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] hw/virtio: Document *_should_notify() are called within rcu_read_lock()
2021-06-21 10:06 ` Philippe Mathieu-Daudé
@ 2021-07-06 10:04 ` Philippe Mathieu-Daudé
2021-07-09 9:10 ` Laurent Vivier
0 siblings, 1 reply; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-07-06 10:04 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Michael S. Tsirkin
Hi Michael, since I asked a modification on v1, I suppose
this patch is somehow worth in documentation, so I'm
pinging again. It could go via qemu-trival if you ack it.
On 6/21/21 12:06 PM, Philippe Mathieu-Daudé wrote:
> ping?
>
> On 5/23/21 11:40 AM, Philippe Mathieu-Daudé wrote:
>> Such comments make reviewing this file somehow easier.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> v2: only one space before end of comment (mst)
>> ---
>> hw/virtio/virtio.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
>> index e02544b2df7..130e3568409 100644
>> --- a/hw/virtio/virtio.c
>> +++ b/hw/virtio/virtio.c
>> @@ -2449,6 +2449,7 @@ static void virtio_set_isr(VirtIODevice *vdev, int value)
>> }
>> }
>>
>> +/* Called within rcu_read_lock(). */
>> static bool virtio_split_should_notify(VirtIODevice *vdev, VirtQueue *vq)
>> {
>> uint16_t old, new;
>> @@ -2485,6 +2486,7 @@ static bool vring_packed_need_event(VirtQueue *vq, bool wrap,
>> return vring_need_event(off, new, old);
>> }
>>
>> +/* Called within rcu_read_lock(). */
>> static bool virtio_packed_should_notify(VirtIODevice *vdev, VirtQueue *vq)
>> {
>> VRingPackedDescEvent e;
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] hw/virtio: Document *_should_notify() are called within rcu_read_lock()
2021-07-06 10:04 ` Philippe Mathieu-Daudé
@ 2021-07-09 9:10 ` Laurent Vivier
0 siblings, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2021-07-09 9:10 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, Michael S. Tsirkin; +Cc: qemu-trivial
Le 06/07/2021 à 12:04, Philippe Mathieu-Daudé a écrit :
> Hi Michael, since I asked a modification on v1, I suppose
> this patch is somehow worth in documentation, so I'm
> pinging again. It could go via qemu-trival if you ack it.
>
> On 6/21/21 12:06 PM, Philippe Mathieu-Daudé wrote:
>> ping?
Applied to my trivial-patches branch.
Thanks,
Laurent
>> On 5/23/21 11:40 AM, Philippe Mathieu-Daudé wrote:
>>> Such comments make reviewing this file somehow easier.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> ---
>>> v2: only one space before end of comment (mst)
>>> ---
>>> hw/virtio/virtio.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
>>> index e02544b2df7..130e3568409 100644
>>> --- a/hw/virtio/virtio.c
>>> +++ b/hw/virtio/virtio.c
>>> @@ -2449,6 +2449,7 @@ static void virtio_set_isr(VirtIODevice *vdev, int value)
>>> }
>>> }
>>>
>>> +/* Called within rcu_read_lock(). */
>>> static bool virtio_split_should_notify(VirtIODevice *vdev, VirtQueue *vq)
>>> {
>>> uint16_t old, new;
>>> @@ -2485,6 +2486,7 @@ static bool vring_packed_need_event(VirtQueue *vq, bool wrap,
>>> return vring_need_event(off, new, old);
>>> }
>>>
>>> +/* Called within rcu_read_lock(). */
>>> static bool virtio_packed_should_notify(VirtIODevice *vdev, VirtQueue *vq)
>>> {
>>> VRingPackedDescEvent e;
>>>
>>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-09 9:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-23 9:40 [PATCH v2] hw/virtio: Document *_should_notify() are called within rcu_read_lock() Philippe Mathieu-Daudé
2021-06-05 19:06 ` Laurent Vivier
2021-06-14 10:42 ` Philippe Mathieu-Daudé
2021-06-21 10:06 ` Philippe Mathieu-Daudé
2021-07-06 10:04 ` Philippe Mathieu-Daudé
2021-07-09 9:10 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.