All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Cc: netdev <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	 Jakub Kicinski <kuba@kernel.org>,
	Mat Martineau <mathew.j.martineau@linux.intel.com>,
	Ayush Sawal <ayush.sawal@chelsio.com>,
	MPTCP Upstream <mptcp@lists.linux.dev>
Subject: Re: [RFC PATCH 4/5] Partially revert "tcp: factor out tcp_build_frag()"
Date: Fri, 17 Sep 2021 19:31:04 +0200	[thread overview]
Message-ID: <ef20848328710215a2d237dbbab18ca953737c5a.camel@redhat.com> (raw)
In-Reply-To: <CANn89i+e7xVLia3epGLpSR70kxuTMyV=VtKGRp3g0m56Ee30gQ@mail.gmail.com>

On Fri, 2021-09-17 at 09:41 -0700, Eric Dumazet wrote:
> On Fri, Sep 17, 2021 at 8:39 AM Paolo Abeni <pabeni@redhat.com> wrote:
> > This is a partial revert for commit b796d04bd014 ("tcp:
> > factor out tcp_build_frag()").
> > 
> > MPTCP was the only user of the tcp_build_frag helper, and after
> > the previous patch MPTCP does not use the mentioned helper anymore.
> > Let's avoid exposing TCP internals.
> > 
> > The revert is partial, as tcp_remove_empty_skb(), exposed
> > by the same commit is still required.
> > 
> 
> I would simply remove the extern in include, and make this nice helper static ?
> 
> This would avoid code churn, and keep a clean code.

I thought you would have preferred otherwise. I'll make the helper
static in the next iteration.

Thanks!

Paolo


  reply	other threads:[~2021-09-17 17:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-17 15:38 [RFC PATCH 0/5] net: remove sk skb caches Paolo Abeni
2021-09-17 15:38 ` [RFC PATCH 1/5] chtls: rename skb_entail() to chtls_skb_entail() Paolo Abeni
2021-09-17 15:38 ` [RFC PATCH 2/5] tcp: expose the tcp_mark_push() and skb_entail() helpers Paolo Abeni
2021-09-17 16:43   ` Eric Dumazet
2021-09-17 16:43     ` Eric Dumazet
2021-09-17 17:28     ` Paolo Abeni
2021-09-17 17:28       ` Paolo Abeni
2021-09-17 15:38 ` [RFC PATCH 3/5] mptcp: stop relying on tcp_tx_skb_cache Paolo Abeni
2021-09-17 15:38 ` [RFC PATCH 4/5] Partially revert "tcp: factor out tcp_build_frag()" Paolo Abeni
2021-09-17 16:41   ` Eric Dumazet
2021-09-17 16:41     ` Eric Dumazet
2021-09-17 17:31     ` Paolo Abeni [this message]
2021-09-17 17:31       ` Paolo Abeni
2021-09-17 15:38 ` [RFC PATCH 5/5] tcp: remove sk_{tr}x_skb_cache Paolo Abeni
2021-09-17 16:47 ` [RFC PATCH 0/5] net: remove sk skb caches Eric Dumazet
2021-09-17 16:47   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef20848328710215a2d237dbbab18ca953737c5a.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=ayush.sawal@chelsio.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.