* [PATCH 1/2] rainier: Add leds that are off 9551 on Operator Panel
@ 2020-07-28 13:59 Vishwanatha Subbanna
2020-07-28 20:45 ` Eddie James
0 siblings, 1 reply; 8+ messages in thread
From: Vishwanatha Subbanna @ 2020-07-28 13:59 UTC (permalink / raw)
To: joel; +Cc: vishwa, devicetree, eajames
These are LEDs that are controlled by 9551
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
---
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 82 ++++++++++++++++++++++++++++
1 file changed, 82 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
index 0b5c6cc..ecbce50 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
@@ -69,6 +69,38 @@
};
};
+ leds {
+ compatible = "gpio-leds";
+
+ /* System ID LED that is at front on Op Panel */
+ front-sys-id0 {
+ retain-state-shutdown;
+ default-state = "keep";
+ gpios = <&pca1 0 GPIO_ACTIVE_LOW>;
+ };
+
+ /* System Attention Indicator ID LED that is at front on Op Panel */
+ front-check-log0 {
+ retain-state-shutdown;
+ default-state = "keep";
+ gpios = <&pca1 1 GPIO_ACTIVE_LOW>;
+ };
+
+ /* Enclosure Fault LED that is at front on Op Panel */
+ front-enc-fault1 {
+ retain-state-shutdown;
+ default-state = "keep";
+ gpios = <&pca1 2 GPIO_ACTIVE_LOW>;
+ };
+
+ /* System PowerOn LED that is at front on Op Panel */
+ front-sys-pwron0 {
+ retain-state-shutdown;
+ default-state = "keep";
+ gpios = <&pca1 3 GPIO_ACTIVE_LOW>;
+ };
+ };
+
};
&gpio0 {
@@ -514,6 +546,56 @@
};
};
+ pca1: pca9551@60 {
+ compatible = "nxp,pca9551";
+ reg = <0x60>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ gpio@0 {
+ reg = <0>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@1 {
+ reg = <1>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@2 {
+ reg = <2>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@3 {
+ reg = <3>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@4 {
+ reg = <4>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@5 {
+ reg = <5>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@6 {
+ reg = <6>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@7 {
+ reg = <7>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+ };
+
dps: dps310@76 {
compatible = "infineon,dps310";
reg = <0x76>;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] rainier: Add leds that are off 9551 on Operator Panel
2020-07-28 13:59 [PATCH 1/2] rainier: Add leds that are off 9551 on Operator Panel Vishwanatha Subbanna
@ 2020-07-28 20:45 ` Eddie James
0 siblings, 0 replies; 8+ messages in thread
From: Eddie James @ 2020-07-28 20:45 UTC (permalink / raw)
To: Vishwanatha Subbanna, joel; +Cc: devicetree
On 7/28/20 8:59 AM, Vishwanatha Subbanna wrote:
> These are LEDs that are controlled by 9551
Reviewed-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 82 ++++++++++++++++++++++++++++
> 1 file changed, 82 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index 0b5c6cc..ecbce50 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -69,6 +69,38 @@
> };
> };
>
> + leds {
> + compatible = "gpio-leds";
> +
> + /* System ID LED that is at front on Op Panel */
> + front-sys-id0 {
> + retain-state-shutdown;
> + default-state = "keep";
> + gpios = <&pca1 0 GPIO_ACTIVE_LOW>;
> + };
> +
> + /* System Attention Indicator ID LED that is at front on Op Panel */
> + front-check-log0 {
> + retain-state-shutdown;
> + default-state = "keep";
> + gpios = <&pca1 1 GPIO_ACTIVE_LOW>;
> + };
> +
> + /* Enclosure Fault LED that is at front on Op Panel */
> + front-enc-fault1 {
> + retain-state-shutdown;
> + default-state = "keep";
> + gpios = <&pca1 2 GPIO_ACTIVE_LOW>;
> + };
> +
> + /* System PowerOn LED that is at front on Op Panel */
> + front-sys-pwron0 {
> + retain-state-shutdown;
> + default-state = "keep";
> + gpios = <&pca1 3 GPIO_ACTIVE_LOW>;
> + };
> + };
> +
> };
>
> &gpio0 {
> @@ -514,6 +546,56 @@
> };
> };
>
> + pca1: pca9551@60 {
> + compatible = "nxp,pca9551";
> + reg = <0x60>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + gpio@0 {
> + reg = <0>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@1 {
> + reg = <1>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@2 {
> + reg = <2>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@3 {
> + reg = <3>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@4 {
> + reg = <4>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@5 {
> + reg = <5>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@6 {
> + reg = <6>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@7 {
> + reg = <7>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> + };
> +
> dps: dps310@76 {
> compatible = "infineon,dps310";
> reg = <0x76>;
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] rainier: Add leds that are off 9551 on Operator Panel
@ 2020-07-27 12:40 ` vishwanatha subbanna
0 siblings, 0 replies; 8+ messages in thread
From: vishwanatha subbanna @ 2020-07-27 12:40 UTC (permalink / raw)
To: openbmc, joel, eajames, devicetree; +Cc: vishwanatha subbanna
These are LEDs that are controlled by 9551
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
---
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 82 ++++++++++++++++++++++++++++
1 file changed, 82 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
index 0b5c6cc..ecbce50 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
@@ -69,6 +69,38 @@
};
};
+ leds {
+ compatible = "gpio-leds";
+
+ /* System ID LED that is at front on Op Panel */
+ front-sys-id0 {
+ retain-state-shutdown;
+ default-state = "keep";
+ gpios = <&pca1 0 GPIO_ACTIVE_LOW>;
+ };
+
+ /* System Attention Indicator ID LED that is at front on Op Panel */
+ front-check-log0 {
+ retain-state-shutdown;
+ default-state = "keep";
+ gpios = <&pca1 1 GPIO_ACTIVE_LOW>;
+ };
+
+ /* Enclosure Fault LED that is at front on Op Panel */
+ front-enc-fault1 {
+ retain-state-shutdown;
+ default-state = "keep";
+ gpios = <&pca1 2 GPIO_ACTIVE_LOW>;
+ };
+
+ /* System PowerOn LED that is at front on Op Panel */
+ front-sys-pwron0 {
+ retain-state-shutdown;
+ default-state = "keep";
+ gpios = <&pca1 3 GPIO_ACTIVE_LOW>;
+ };
+ };
+
};
&gpio0 {
@@ -514,6 +546,56 @@
};
};
+ pca1: pca9551@60 {
+ compatible = "nxp,pca9551";
+ reg = <0x60>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ gpio@0 {
+ reg = <0>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@1 {
+ reg = <1>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@2 {
+ reg = <2>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@3 {
+ reg = <3>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@4 {
+ reg = <4>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@5 {
+ reg = <5>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@6 {
+ reg = <6>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@7 {
+ reg = <7>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+ };
+
dps: dps310@76 {
compatible = "infineon,dps310";
reg = <0x76>;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 1/2] rainier: Add leds that are off 9551 on Operator Panel
@ 2020-07-27 12:40 ` vishwanatha subbanna
0 siblings, 0 replies; 8+ messages in thread
From: vishwanatha subbanna @ 2020-07-27 12:40 UTC (permalink / raw)
To: openbmc, joel, eajames, devicetree
These are LEDs that are controlled by 9551
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
---
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 82 ++++++++++++++++++++++++++++
1 file changed, 82 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
index 0b5c6cc..ecbce50 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
@@ -69,6 +69,38 @@
};
};
+ leds {
+ compatible = "gpio-leds";
+
+ /* System ID LED that is at front on Op Panel */
+ front-sys-id0 {
+ retain-state-shutdown;
+ default-state = "keep";
+ gpios = <&pca1 0 GPIO_ACTIVE_LOW>;
+ };
+
+ /* System Attention Indicator ID LED that is at front on Op Panel */
+ front-check-log0 {
+ retain-state-shutdown;
+ default-state = "keep";
+ gpios = <&pca1 1 GPIO_ACTIVE_LOW>;
+ };
+
+ /* Enclosure Fault LED that is at front on Op Panel */
+ front-enc-fault1 {
+ retain-state-shutdown;
+ default-state = "keep";
+ gpios = <&pca1 2 GPIO_ACTIVE_LOW>;
+ };
+
+ /* System PowerOn LED that is at front on Op Panel */
+ front-sys-pwron0 {
+ retain-state-shutdown;
+ default-state = "keep";
+ gpios = <&pca1 3 GPIO_ACTIVE_LOW>;
+ };
+ };
+
};
&gpio0 {
@@ -514,6 +546,56 @@
};
};
+ pca1: pca9551@60 {
+ compatible = "nxp,pca9551";
+ reg = <0x60>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ gpio@0 {
+ reg = <0>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@1 {
+ reg = <1>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@2 {
+ reg = <2>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@3 {
+ reg = <3>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@4 {
+ reg = <4>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@5 {
+ reg = <5>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@6 {
+ reg = <6>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@7 {
+ reg = <7>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+ };
+
dps: dps310@76 {
compatible = "infineon,dps310";
reg = <0x76>;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] rainier: Add leds that are off 9551 on Operator Panel
2020-07-27 12:40 ` vishwanatha subbanna
(?)
@ 2020-07-27 21:19 ` Eddie James
-1 siblings, 0 replies; 8+ messages in thread
From: Eddie James @ 2020-07-27 21:19 UTC (permalink / raw)
To: vishwanatha subbanna, openbmc, joel, devicetree
On 7/27/20 7:40 AM, vishwanatha subbanna wrote:
> These are LEDs that are controlled by 9551
Reviewed-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 82 ++++++++++++++++++++++++++++
> 1 file changed, 82 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index 0b5c6cc..ecbce50 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -69,6 +69,38 @@
> };
> };
>
> + leds {
> + compatible = "gpio-leds";
> +
> + /* System ID LED that is at front on Op Panel */
> + front-sys-id0 {
> + retain-state-shutdown;
> + default-state = "keep";
> + gpios = <&pca1 0 GPIO_ACTIVE_LOW>;
> + };
> +
> + /* System Attention Indicator ID LED that is at front on Op Panel */
> + front-check-log0 {
> + retain-state-shutdown;
> + default-state = "keep";
> + gpios = <&pca1 1 GPIO_ACTIVE_LOW>;
> + };
> +
> + /* Enclosure Fault LED that is at front on Op Panel */
> + front-enc-fault1 {
> + retain-state-shutdown;
> + default-state = "keep";
> + gpios = <&pca1 2 GPIO_ACTIVE_LOW>;
> + };
> +
> + /* System PowerOn LED that is at front on Op Panel */
> + front-sys-pwron0 {
> + retain-state-shutdown;
> + default-state = "keep";
> + gpios = <&pca1 3 GPIO_ACTIVE_LOW>;
> + };
> + };
> +
> };
>
> &gpio0 {
> @@ -514,6 +546,56 @@
> };
> };
>
> + pca1: pca9551@60 {
> + compatible = "nxp,pca9551";
> + reg = <0x60>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + gpio@0 {
> + reg = <0>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@1 {
> + reg = <1>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@2 {
> + reg = <2>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@3 {
> + reg = <3>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@4 {
> + reg = <4>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@5 {
> + reg = <5>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@6 {
> + reg = <6>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@7 {
> + reg = <7>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> + };
> +
> dps: dps310@76 {
> compatible = "infineon,dps310";
> reg = <0x76>;
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] rainier: Add leds that are off 9551 on Operator Panel
2020-07-27 12:40 ` vishwanatha subbanna
@ 2020-07-27 23:23 ` Joel Stanley
-1 siblings, 0 replies; 8+ messages in thread
From: Joel Stanley @ 2020-07-27 23:23 UTC (permalink / raw)
To: vishwanatha subbanna; +Cc: OpenBMC Maillist, Eddie James, devicetree
On Mon, 27 Jul 2020 at 12:41, vishwanatha subbanna
<vishwa@linux.vnet.ibm.com> wrote:
>
>
> These are LEDs that are controlled by 9551
>
> Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 82 ++++++++++++++++++++++++++++
> 1 file changed, 82 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index 0b5c6cc..ecbce50 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -69,6 +69,38 @@
> };
> };
>
> + leds {
> + compatible = "gpio-leds";
> +
> + /* System ID LED that is at front on Op Panel */
> + front-sys-id0 {
> + retain-state-shutdown;
> + default-state = "keep";
> + gpios = <&pca1 0 GPIO_ACTIVE_LOW>;
> + };
> +
> + /* System Attention Indicator ID LED that is at front on Op Panel */
> + front-check-log0 {
> + retain-state-shutdown;
> + default-state = "keep";
> + gpios = <&pca1 1 GPIO_ACTIVE_LOW>;
> + };
> +
> + /* Enclosure Fault LED that is at front on Op Panel */
> + front-enc-fault1 {
> + retain-state-shutdown;
> + default-state = "keep";
> + gpios = <&pca1 2 GPIO_ACTIVE_LOW>;
> + };
> +
> + /* System PowerOn LED that is at front on Op Panel */
> + front-sys-pwron0 {
> + retain-state-shutdown;
> + default-state = "keep";
> + gpios = <&pca1 3 GPIO_ACTIVE_LOW>;
> + };
> + };
> +
> };
This patch is malformed. It looks like you've pasted it into your
mailer, which makes it easy to break the patch. Instead I recommend
using git-send-email to send your patches as it avoids this issue.
>
> &gpio0 {
> @@ -514,6 +546,56 @@
> };
> };
>
> + pca1: pca9551@60 {
> + compatible = "nxp,pca9551";
> + reg = <0x60>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + gpio@0 {
> + reg = <0>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@1 {
> + reg = <1>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@2 {
> + reg = <2>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@3 {
> + reg = <3>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@4 {
> + reg = <4>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@5 {
> + reg = <5>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@6 {
> + reg = <6>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@7 {
> + reg = <7>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> + };
> +
> dps: dps310@76 {
> compatible = "infineon,dps310";
> reg = <0x76>;
> --
> 1.8.3.1
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] rainier: Add leds that are off 9551 on Operator Panel
@ 2020-07-27 23:23 ` Joel Stanley
0 siblings, 0 replies; 8+ messages in thread
From: Joel Stanley @ 2020-07-27 23:23 UTC (permalink / raw)
To: vishwanatha subbanna; +Cc: OpenBMC Maillist, Eddie James, devicetree
On Mon, 27 Jul 2020 at 12:41, vishwanatha subbanna
<vishwa@linux.vnet.ibm.com> wrote:
>
>
> These are LEDs that are controlled by 9551
>
> Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 82 ++++++++++++++++++++++++++++
> 1 file changed, 82 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index 0b5c6cc..ecbce50 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -69,6 +69,38 @@
> };
> };
>
> + leds {
> + compatible = "gpio-leds";
> +
> + /* System ID LED that is at front on Op Panel */
> + front-sys-id0 {
> + retain-state-shutdown;
> + default-state = "keep";
> + gpios = <&pca1 0 GPIO_ACTIVE_LOW>;
> + };
> +
> + /* System Attention Indicator ID LED that is at front on Op Panel */
> + front-check-log0 {
> + retain-state-shutdown;
> + default-state = "keep";
> + gpios = <&pca1 1 GPIO_ACTIVE_LOW>;
> + };
> +
> + /* Enclosure Fault LED that is at front on Op Panel */
> + front-enc-fault1 {
> + retain-state-shutdown;
> + default-state = "keep";
> + gpios = <&pca1 2 GPIO_ACTIVE_LOW>;
> + };
> +
> + /* System PowerOn LED that is at front on Op Panel */
> + front-sys-pwron0 {
> + retain-state-shutdown;
> + default-state = "keep";
> + gpios = <&pca1 3 GPIO_ACTIVE_LOW>;
> + };
> + };
> +
> };
This patch is malformed. It looks like you've pasted it into your
mailer, which makes it easy to break the patch. Instead I recommend
using git-send-email to send your patches as it avoids this issue.
>
> &gpio0 {
> @@ -514,6 +546,56 @@
> };
> };
>
> + pca1: pca9551@60 {
> + compatible = "nxp,pca9551";
> + reg = <0x60>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + gpio@0 {
> + reg = <0>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@1 {
> + reg = <1>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@2 {
> + reg = <2>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@3 {
> + reg = <3>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@4 {
> + reg = <4>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@5 {
> + reg = <5>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@6 {
> + reg = <6>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> +
> + gpio@7 {
> + reg = <7>;
> + type = <PCA955X_TYPE_GPIO>;
> + };
> + };
> +
> dps: dps310@76 {
> compatible = "infineon,dps310";
> reg = <0x76>;
> --
> 1.8.3.1
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] rainier: Add leds that are off 9551 on Operator Panel
@ 2020-07-09 11:15 Vishwanatha Subbanna
0 siblings, 0 replies; 8+ messages in thread
From: Vishwanatha Subbanna @ 2020-07-09 11:15 UTC (permalink / raw)
To: openbmc
These are LEDs that are controlled by 9551
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
---
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 82 ++++++++++++++++++++++++++++
1 file changed, 82 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
index 0b5c6cc..ecbce50 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
@@ -69,6 +69,38 @@
};
};
+ leds {
+ compatible = "gpio-leds";
+
+ /* System ID LED that is at front on Op Panel */
+ front-sys-id0 {
+ retain-state-shutdown;
+ default-state = "keep";
+ gpios = <&pca1 0 GPIO_ACTIVE_LOW>;
+ };
+
+ /* System Attention Indicator ID LED that is at front on Op Panel */
+ front-check-log0 {
+ retain-state-shutdown;
+ default-state = "keep";
+ gpios = <&pca1 1 GPIO_ACTIVE_LOW>;
+ };
+
+ /* Enclosure Fault LED that is at front on Op Panel */
+ front-enc-fault1 {
+ retain-state-shutdown;
+ default-state = "keep";
+ gpios = <&pca1 2 GPIO_ACTIVE_LOW>;
+ };
+
+ /* System PowerOn LED that is at front on Op Panel */
+ front-sys-pwron0 {
+ retain-state-shutdown;
+ default-state = "keep";
+ gpios = <&pca1 3 GPIO_ACTIVE_LOW>;
+ };
+ };
+
};
&gpio0 {
@@ -514,6 +546,56 @@
};
};
+ pca1: pca9551@60 {
+ compatible = "nxp,pca9551";
+ reg = <0x60>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ gpio@0 {
+ reg = <0>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@1 {
+ reg = <1>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@2 {
+ reg = <2>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@3 {
+ reg = <3>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@4 {
+ reg = <4>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@5 {
+ reg = <5>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@6 {
+ reg = <6>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+
+ gpio@7 {
+ reg = <7>;
+ type = <PCA955X_TYPE_GPIO>;
+ };
+ };
+
dps: dps310@76 {
compatible = "infineon,dps310";
reg = <0x76>;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-07-28 20:45 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 13:59 [PATCH 1/2] rainier: Add leds that are off 9551 on Operator Panel Vishwanatha Subbanna
2020-07-28 20:45 ` Eddie James
-- strict thread matches above, loose matches on Subject: below --
2020-07-27 12:40 vishwanatha subbanna
2020-07-27 12:40 ` vishwanatha subbanna
2020-07-27 21:19 ` Eddie James
2020-07-27 23:23 ` Joel Stanley
2020-07-27 23:23 ` Joel Stanley
2020-07-09 11:15 Vishwanatha Subbanna
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.