From: Paolo Bonzini <pbonzini@redhat.com> To: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, "Michael S . Tsirkin" <mst@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org, Boris Petkov <bp@suse.de>, Tony Luck <tony.luck@intel.com>, Andi Kleen <andi.kleen@intel.com>, rkrcmar@redhat.com, Ashok Raj <ashok.raj@intel.com> Subject: Re: [PATCH v4 1/3] target-i386: KVM: add basic Intel LMCE support Date: Thu, 16 Jun 2016 12:42:19 +0200 [thread overview] Message-ID: <f0944c76-49e7-73ea-0e63-883ab3763c43@redhat.com> (raw) In-Reply-To: <20160616103413.qqtdihdto545y7hb@hz-desktop> On 16/06/2016 12:34, Haozhong Zhang wrote: > On 06/16/16 12:23, Paolo Bonzini wrote: >> >> >> On 16/06/2016 12:16, Haozhong Zhang wrote: >>>> >>>>> + has_msr_mcg_ext_ctl = true; >>>>> } >>>>> >>>>> c = cpuid_find_entry(&cpuid_data.cpuid, 0x80000007, 0); >>>> >>>> Which silicon has LMCE? We may want to enable the property for some CPU >>>> models. Apart from this, the patch is pretty much okay. >>> >>> Skylake-EX >> >> ... However, all virtual CPUs can use LMCE because the rendez-vous is >> done in the host. Is this correct? >> > > Yes, if it does not confuse the guest which sees LMCE available on > lower end or earlier CPUs (though I think someone would feel > happy). Yes, that's what I expect too. No confusion, and some happiness. :) > Or do we add it only to qemu64 and kvm64? I'm not sure where to add it, actually. :( Let's wait for Eduardo's opinion. Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com> To: qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, "Michael S . Tsirkin" <mst@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org, Boris Petkov <bp@suse.de>, Tony Luck <tony.luck@intel.com>, Andi Kleen <andi.kleen@intel.com>, rkrcmar@redhat.com, Ashok Raj <ashok.raj@intel.com> Subject: Re: [Qemu-devel] [PATCH v4 1/3] target-i386: KVM: add basic Intel LMCE support Date: Thu, 16 Jun 2016 12:42:19 +0200 [thread overview] Message-ID: <f0944c76-49e7-73ea-0e63-883ab3763c43@redhat.com> (raw) In-Reply-To: <20160616103413.qqtdihdto545y7hb@hz-desktop> On 16/06/2016 12:34, Haozhong Zhang wrote: > On 06/16/16 12:23, Paolo Bonzini wrote: >> >> >> On 16/06/2016 12:16, Haozhong Zhang wrote: >>>> >>>>> + has_msr_mcg_ext_ctl = true; >>>>> } >>>>> >>>>> c = cpuid_find_entry(&cpuid_data.cpuid, 0x80000007, 0); >>>> >>>> Which silicon has LMCE? We may want to enable the property for some CPU >>>> models. Apart from this, the patch is pretty much okay. >>> >>> Skylake-EX >> >> ... However, all virtual CPUs can use LMCE because the rendez-vous is >> done in the host. Is this correct? >> > > Yes, if it does not confuse the guest which sees LMCE available on > lower end or earlier CPUs (though I think someone would feel > happy). Yes, that's what I expect too. No confusion, and some happiness. :) > Or do we add it only to qemu64 and kvm64? I'm not sure where to add it, actually. :( Let's wait for Eduardo's opinion. Paolo
next prev parent reply other threads:[~2016-06-16 10:42 UTC|newest] Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-16 6:06 [PATCH v4 0/3] Add QEMU support for Intel local MCE Haozhong Zhang 2016-06-16 6:06 ` [Qemu-devel] " Haozhong Zhang 2016-06-16 6:06 ` [PATCH v4 1/3] target-i386: KVM: add basic Intel LMCE support Haozhong Zhang 2016-06-16 6:06 ` [Qemu-devel] " Haozhong Zhang 2016-06-16 9:50 ` Paolo Bonzini 2016-06-16 9:50 ` [Qemu-devel] " Paolo Bonzini 2016-06-16 10:16 ` Haozhong Zhang 2016-06-16 10:16 ` [Qemu-devel] " Haozhong Zhang 2016-06-16 10:23 ` Paolo Bonzini 2016-06-16 10:23 ` [Qemu-devel] " Paolo Bonzini 2016-06-16 10:34 ` Haozhong Zhang 2016-06-16 10:34 ` [Qemu-devel] " Haozhong Zhang 2016-06-16 10:42 ` Paolo Bonzini [this message] 2016-06-16 10:42 ` Paolo Bonzini 2016-06-16 18:05 ` Eduardo Habkost 2016-06-16 18:05 ` [Qemu-devel] " Eduardo Habkost 2016-06-16 18:17 ` Paolo Bonzini 2016-06-16 18:17 ` [Qemu-devel] " Paolo Bonzini 2016-06-16 19:37 ` Eduardo Habkost 2016-06-16 19:37 ` [Qemu-devel] " Eduardo Habkost 2016-06-17 1:26 ` Haozhong Zhang 2016-06-17 1:26 ` [Qemu-devel] " Haozhong Zhang 2016-06-17 16:20 ` Eduardo Habkost 2016-06-17 16:20 ` [Qemu-devel] " Eduardo Habkost 2016-06-20 2:04 ` Haozhong Zhang 2016-06-20 2:04 ` [Qemu-devel] " Haozhong Zhang 2016-06-16 6:06 ` [PATCH v4 2/3] target-i386: add migration support for Intel LMCE Haozhong Zhang 2016-06-16 6:06 ` [Qemu-devel] " Haozhong Zhang 2016-06-16 9:51 ` Paolo Bonzini 2016-06-16 9:51 ` [Qemu-devel] " Paolo Bonzini 2016-06-16 10:29 ` Haozhong Zhang 2016-06-16 10:29 ` [Qemu-devel] " Haozhong Zhang 2016-06-16 10:41 ` Paolo Bonzini 2016-06-16 10:41 ` [Qemu-devel] " Paolo Bonzini 2016-06-16 10:55 ` Haozhong Zhang 2016-06-16 10:55 ` [Qemu-devel] " Haozhong Zhang 2016-06-16 17:36 ` Eduardo Habkost 2016-06-16 17:36 ` [Qemu-devel] " Eduardo Habkost 2016-06-16 17:40 ` Paolo Bonzini 2016-06-16 17:40 ` [Qemu-devel] " Paolo Bonzini 2016-06-16 17:58 ` Eduardo Habkost 2016-06-16 17:58 ` [Qemu-devel] " Eduardo Habkost 2016-06-17 2:01 ` Haozhong Zhang 2016-06-17 2:01 ` [Qemu-devel] " Haozhong Zhang 2016-06-17 17:20 ` Eduardo Habkost 2016-06-17 17:20 ` [Qemu-devel] " Eduardo Habkost 2016-06-17 17:26 ` Paolo Bonzini 2016-06-17 17:26 ` [Qemu-devel] " Paolo Bonzini 2016-06-20 2:11 ` Haozhong Zhang 2016-06-20 2:11 ` [Qemu-devel] " Haozhong Zhang 2016-06-20 6:58 ` Paolo Bonzini 2016-06-20 6:58 ` [Qemu-devel] " Paolo Bonzini 2016-06-20 7:26 ` Haozhong Zhang 2016-06-16 19:53 ` Eduardo Habkost 2016-06-16 19:53 ` [Qemu-devel] " Eduardo Habkost 2016-06-16 6:06 ` [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg Haozhong Zhang 2016-06-16 6:06 ` [Qemu-devel] " Haozhong Zhang 2016-06-16 9:52 ` Paolo Bonzini 2016-06-16 9:52 ` [Qemu-devel] " Paolo Bonzini 2016-06-16 11:19 ` Haozhong Zhang 2016-06-16 11:19 ` [Qemu-devel] " Haozhong Zhang 2016-06-17 17:31 ` Laszlo Ersek 2016-06-17 17:31 ` [Qemu-devel] " Laszlo Ersek 2016-06-17 20:21 ` Raj, Ashok 2016-06-17 20:21 ` [Qemu-devel] " Raj, Ashok 2016-06-17 20:48 ` Laszlo Ersek 2016-06-17 20:48 ` [Qemu-devel] " Laszlo Ersek 2016-06-17 20:55 ` Raj, Ashok 2016-06-17 20:55 ` [Qemu-devel] " Raj, Ashok 2016-06-17 21:30 ` Laszlo Ersek 2016-06-17 21:30 ` [Qemu-devel] " Laszlo Ersek 2016-06-20 3:09 ` Haozhong Zhang 2016-06-20 3:09 ` [Qemu-devel] " Haozhong Zhang 2016-06-20 6:56 ` Paolo Bonzini 2016-06-20 6:56 ` [Qemu-devel] " Paolo Bonzini 2016-06-20 7:20 ` Haozhong Zhang 2016-06-20 7:20 ` [Qemu-devel] " Haozhong Zhang 2016-06-22 10:18 ` Haozhong Zhang 2016-06-22 10:18 ` [Qemu-devel] " Haozhong Zhang 2016-06-22 15:51 ` Laszlo Ersek 2016-06-22 15:51 ` [Qemu-devel] " Laszlo Ersek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f0944c76-49e7-73ea-0e63-883ab3763c43@redhat.com \ --to=pbonzini@redhat.com \ --cc=andi.kleen@intel.com \ --cc=ashok.raj@intel.com \ --cc=bp@suse.de \ --cc=ehabkost@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=mst@redhat.com \ --cc=mtosatti@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=rkrcmar@redhat.com \ --cc=rth@twiddle.net \ --cc=tony.luck@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.