From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>,
~postmarketos/upstreaming@lists.sr.ht
Cc: martin.botka@somainline.org,
angelogioacchino.delregno@somainline.org,
marijn.suijten@somainline.org, jamipkettunen@somainline.org,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Jonathan Marek <jonathan@marek.ca>,
Abhinav Kumar <abhinavk@codeaurora.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/msm/dsi: Fix DSI and DSI PHY regulator config from SDM660
Date: Thu, 29 Jul 2021 12:10:21 +0300 [thread overview]
Message-ID: <f19a9368-1d51-9e1a-dfe8-04d6970e149f@linaro.org> (raw)
In-Reply-To: <20210728222057.52641-1-konrad.dybcio@somainline.org>
On 29/07/2021 01:20, Konrad Dybcio wrote:
> VDDA is not present and the specified load value is wrong. Fix it.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/dsi/dsi_cfg.c | 1 -
> drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> index f3f1c03c7db9..763f127e4621 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> @@ -154,7 +154,6 @@ static const struct msm_dsi_config sdm660_dsi_cfg = {
> .reg_cfg = {
> .num = 2,
> .regs = {
> - {"vdd", 73400, 32 }, /* 0.9 V */
> {"vdda", 12560, 4 }, /* 1.2 V */
> },
> },
> diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c
> index a34cf151c517..bb31230721bd 100644
> --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c
> +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c
> @@ -1050,7 +1050,7 @@ const struct msm_dsi_phy_cfg dsi_phy_14nm_660_cfgs = {
> .reg_cfg = {
> .num = 1,
> .regs = {
> - {"vcca", 17000, 32},
> + {"vcca", 73400, 32},
> },
> },
> .ops = {
>
--
With best wishes
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>,
~postmarketos/upstreaming@lists.sr.ht
Cc: freedreno@lists.freedesktop.org,
Jonathan Marek <jonathan@marek.ca>,
David Airlie <airlied@linux.ie>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, jamipkettunen@somainline.org,
martin.botka@somainline.org,
Abhinav Kumar <abhinavk@codeaurora.org>,
angelogioacchino.delregno@somainline.org,
marijn.suijten@somainline.org, Sean Paul <sean@poorly.run>
Subject: Re: [PATCH] drm/msm/dsi: Fix DSI and DSI PHY regulator config from SDM660
Date: Thu, 29 Jul 2021 12:10:21 +0300 [thread overview]
Message-ID: <f19a9368-1d51-9e1a-dfe8-04d6970e149f@linaro.org> (raw)
In-Reply-To: <20210728222057.52641-1-konrad.dybcio@somainline.org>
On 29/07/2021 01:20, Konrad Dybcio wrote:
> VDDA is not present and the specified load value is wrong. Fix it.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/dsi/dsi_cfg.c | 1 -
> drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> index f3f1c03c7db9..763f127e4621 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c
> @@ -154,7 +154,6 @@ static const struct msm_dsi_config sdm660_dsi_cfg = {
> .reg_cfg = {
> .num = 2,
> .regs = {
> - {"vdd", 73400, 32 }, /* 0.9 V */
> {"vdda", 12560, 4 }, /* 1.2 V */
> },
> },
> diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c
> index a34cf151c517..bb31230721bd 100644
> --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c
> +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c
> @@ -1050,7 +1050,7 @@ const struct msm_dsi_phy_cfg dsi_phy_14nm_660_cfgs = {
> .reg_cfg = {
> .num = 1,
> .regs = {
> - {"vcca", 17000, 32},
> + {"vcca", 73400, 32},
> },
> },
> .ops = {
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2021-07-29 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 22:20 [PATCH] drm/msm/dsi: Fix DSI and DSI PHY regulator config from SDM660 Konrad Dybcio
2021-07-28 22:20 ` Konrad Dybcio
2021-07-29 9:10 ` Dmitry Baryshkov [this message]
2021-07-29 9:10 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f19a9368-1d51-9e1a-dfe8-04d6970e149f@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@somainline.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jamipkettunen@somainline.org \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.