From: "Xu, Yanfei" <yanfei.xu@windriver.com> To: "Russell King (Oracle)" <linux@armlinux.org.uk> Cc: rppt@kernel.org, ardb@kernel.org, linus.walleij@linaro.org, akpm@linux-foundation.org, carver4lio@163.com, tiantao6@hisilicon.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] ARM: change vmalloc_min to vmalloc_start Date: Fri, 28 May 2021 10:52:28 +0800 [thread overview] Message-ID: <f2be5610-9a2c-f4cc-510c-b8fae22f67dd@windriver.com> (raw) In-Reply-To: <20210520090024.GB30436@shell.armlinux.org.uk> On 5/20/21 5:00 PM, Russell King (Oracle) wrote: > [Please note: This e-mail is from an EXTERNAL e-mail address] > > On Wed, May 19, 2021 at 12:41:10PM +0800, Xu, Yanfei wrote: >> On 5/18/21 8:15 PM, Russell King (Oracle) wrote: >>> -static unsigned long __initdata vmalloc_min = >>> - VMALLOC_END - (240 << 20) - VMALLOC_OFFSET; >>> +static unsigned long __initdata vmalloc_start = VMALLOC_END - (240 << 20); >>> >>> /* >>> * vmalloc=size forces the vmalloc area to be exactly 'size' >>> @@ -1169,7 +1168,8 @@ void __init adjust_lowmem_bounds(void) >>> * and may itself be outside the valid range for which phys_addr_t >>> * and therefore __pa() is defined. >>> */ >>> - vmalloc_limit = (u64)vmalloc_min - PAGE_OFFSET + PHYS_OFFSET; >>> + vmalloc_limit = (u64)vmalloc_start - >>> + (PAGE_OFFSET + PHYS_OFFSET + VMALLOC_OFFSET); >>> >> Here is bug, it should be >> >> vmalloc_limit = (u64)vmalloc_start - >> (PAGE_OFFSET + VMALLOC_OFFSET) + PHYS_OFFSET; > > Yes, you're absolutely right, thanks for catching that! > Hi Russell, Will you send v2? (or I missed something.) Thanks, Yanfei > -- > RMK's Patch system: https://urldefense.com/v3/__https://www.armlinux.org.uk/developer/patches/__;!!AjveYdw8EvQ!M3h7vuBembpLOcv9xTj5vzxlU0dxXMOa1lDX4yN6u4l-TwnuZ3-ldjYom-7ZQYpsVYc$ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! >
WARNING: multiple messages have this Message-ID (diff)
From: "Xu, Yanfei" <yanfei.xu@windriver.com> To: "Russell King (Oracle)" <linux@armlinux.org.uk> Cc: rppt@kernel.org, ardb@kernel.org, linus.walleij@linaro.org, akpm@linux-foundation.org, carver4lio@163.com, tiantao6@hisilicon.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] ARM: change vmalloc_min to vmalloc_start Date: Fri, 28 May 2021 10:52:28 +0800 [thread overview] Message-ID: <f2be5610-9a2c-f4cc-510c-b8fae22f67dd@windriver.com> (raw) In-Reply-To: <20210520090024.GB30436@shell.armlinux.org.uk> On 5/20/21 5:00 PM, Russell King (Oracle) wrote: > [Please note: This e-mail is from an EXTERNAL e-mail address] > > On Wed, May 19, 2021 at 12:41:10PM +0800, Xu, Yanfei wrote: >> On 5/18/21 8:15 PM, Russell King (Oracle) wrote: >>> -static unsigned long __initdata vmalloc_min = >>> - VMALLOC_END - (240 << 20) - VMALLOC_OFFSET; >>> +static unsigned long __initdata vmalloc_start = VMALLOC_END - (240 << 20); >>> >>> /* >>> * vmalloc=size forces the vmalloc area to be exactly 'size' >>> @@ -1169,7 +1168,8 @@ void __init adjust_lowmem_bounds(void) >>> * and may itself be outside the valid range for which phys_addr_t >>> * and therefore __pa() is defined. >>> */ >>> - vmalloc_limit = (u64)vmalloc_min - PAGE_OFFSET + PHYS_OFFSET; >>> + vmalloc_limit = (u64)vmalloc_start - >>> + (PAGE_OFFSET + PHYS_OFFSET + VMALLOC_OFFSET); >>> >> Here is bug, it should be >> >> vmalloc_limit = (u64)vmalloc_start - >> (PAGE_OFFSET + VMALLOC_OFFSET) + PHYS_OFFSET; > > Yes, you're absolutely right, thanks for catching that! > Hi Russell, Will you send v2? (or I missed something.) Thanks, Yanfei > -- > RMK's Patch system: https://urldefense.com/v3/__https://www.armlinux.org.uk/developer/patches/__;!!AjveYdw8EvQ!M3h7vuBembpLOcv9xTj5vzxlU0dxXMOa1lDX4yN6u4l-TwnuZ3-ldjYom-7ZQYpsVYc$ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-28 2:53 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-18 11:12 [PATCH] arm: make the size of vmalloc in cmdline and meminfo uniform Yanfei Xu 2021-05-18 11:12 ` Yanfei Xu 2021-05-18 11:29 ` Russell King (Oracle) 2021-05-18 11:29 ` Russell King (Oracle) 2021-05-18 12:06 ` Russell King (Oracle) 2021-05-18 12:06 ` Russell King (Oracle) 2021-05-18 12:15 ` [PATCH 1/4] ARM: change vmalloc_min to be unsigned long Russell King (Oracle) 2021-05-18 12:15 ` Russell King (Oracle) 2021-05-18 22:09 ` Linus Walleij 2021-05-18 22:09 ` Linus Walleij 2021-05-18 12:15 ` [PATCH 2/4] ARM: use a temporary variable to hold maximum vmalloc size Russell King (Oracle) 2021-05-18 12:15 ` Russell King (Oracle) 2021-05-18 22:11 ` Linus Walleij 2021-05-18 22:11 ` Linus Walleij 2021-05-18 12:15 ` [PATCH 3/4] ARM: change vmalloc_min to vmalloc_start Russell King (Oracle) 2021-05-18 12:15 ` Russell King (Oracle) 2021-05-18 22:19 ` Linus Walleij 2021-05-18 22:19 ` Linus Walleij 2021-05-18 22:26 ` Nicolas Pitre 2021-05-18 22:26 ` Nicolas Pitre 2021-05-18 22:32 ` Nicolas Pitre 2021-05-18 22:32 ` Nicolas Pitre 2021-05-18 22:34 ` Linus Walleij 2021-05-18 22:34 ` Linus Walleij 2021-05-18 22:38 ` Nicolas Pitre 2021-05-18 22:38 ` Nicolas Pitre 2021-05-28 9:55 ` Russell King (Oracle) 2021-05-28 9:55 ` Russell King (Oracle) 2021-05-19 4:41 ` Xu, Yanfei 2021-05-19 4:41 ` Xu, Yanfei 2021-05-20 9:00 ` Russell King (Oracle) 2021-05-20 9:00 ` Russell King (Oracle) 2021-05-28 2:52 ` Xu, Yanfei [this message] 2021-05-28 2:52 ` Xu, Yanfei 2021-05-28 10:00 ` Russell King (Oracle) 2021-05-28 10:00 ` Russell King (Oracle) 2021-05-19 5:25 ` Xu, Yanfei 2021-05-19 5:25 ` Xu, Yanfei 2021-05-18 12:15 ` [PATCH 4/4] ARM: change vmalloc_start to vmalloc_size Russell King (Oracle) 2021-05-18 12:15 ` Russell King (Oracle) 2021-05-18 22:21 ` Linus Walleij 2021-05-18 22:21 ` Linus Walleij 2021-05-19 4:39 ` [PATCH] arm: make the size of vmalloc in cmdline and meminfo uniform Xu, Yanfei 2021-05-19 4:39 ` Xu, Yanfei 2021-05-19 5:32 ` Xu, Yanfei 2021-05-19 5:32 ` Xu, Yanfei 2021-05-20 4:52 ` Alexander Dahl 2021-05-20 4:52 ` Alexander Dahl 2021-05-20 6:50 ` Xu, Yanfei 2021-05-20 6:50 ` Xu, Yanfei 2021-05-28 10:11 ` [PATCH v2 1/6] ARM: change vmalloc_min to be unsigned long Russell King (Oracle) 2021-05-28 10:11 ` Russell King (Oracle) 2021-05-28 13:10 ` Xu, Yanfei 2021-05-28 13:10 ` Xu, Yanfei 2021-05-28 10:11 ` [PATCH v2 2/6] ARM: use a temporary variable to hold maximum vmalloc size Russell King (Oracle) 2021-05-28 10:11 ` Russell King (Oracle) 2021-05-28 13:11 ` Xu, Yanfei 2021-05-28 13:11 ` Xu, Yanfei 2021-05-28 10:11 ` [PATCH v2 3/6] ARM: change vmalloc_min to vmalloc_start Russell King (Oracle) 2021-05-28 10:11 ` Russell King (Oracle) 2021-05-28 12:21 ` Linus Walleij 2021-05-28 12:21 ` Linus Walleij 2021-05-28 13:05 ` Xu, Yanfei 2021-05-28 13:05 ` Xu, Yanfei 2021-05-28 10:11 ` [PATCH v2 4/6] ARM: change vmalloc_start to vmalloc_size Russell King (Oracle) 2021-05-28 10:11 ` Russell King (Oracle) 2021-05-28 12:22 ` Linus Walleij 2021-05-28 12:22 ` Linus Walleij 2021-05-28 13:15 ` Xu, Yanfei 2021-05-28 13:15 ` Xu, Yanfei 2021-05-28 10:11 ` [PATCH v2 5/6] ARM: use "* SZ_1M" rather than "<< 20" Russell King (Oracle) 2021-05-28 10:11 ` Russell King (Oracle) 2021-05-28 12:23 ` Linus Walleij 2021-05-28 12:23 ` Linus Walleij 2021-05-28 13:17 ` Xu, Yanfei 2021-05-28 13:17 ` Xu, Yanfei 2021-05-28 10:11 ` [PATCH v2 6/6] ARM: use MiB for vmalloc sizes Russell King (Oracle) 2021-05-28 10:11 ` Russell King (Oracle) 2021-05-28 12:24 ` Linus Walleij 2021-05-28 12:24 ` Linus Walleij 2021-05-28 13:20 ` Xu, Yanfei 2021-05-28 13:20 ` Xu, Yanfei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f2be5610-9a2c-f4cc-510c-b8fae22f67dd@windriver.com \ --to=yanfei.xu@windriver.com \ --cc=akpm@linux-foundation.org \ --cc=ardb@kernel.org \ --cc=carver4lio@163.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=rppt@kernel.org \ --cc=tiantao6@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.