From: Nicolas Pitre <nico@fluxnic.net>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Yanfei Xu <yanfei.xu@windriver.com>,
Mike Rapoport <rppt@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Hailong liu <carver4lio@163.com>,
Tian Tao <tiantao6@hisilicon.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] ARM: change vmalloc_min to vmalloc_start
Date: Tue, 18 May 2021 18:26:54 -0400 (EDT) [thread overview]
Message-ID: <sons6q6-2630-rr8s-18ns-221454n9472@syhkavp.arg> (raw)
In-Reply-To: <CACRpkdbZObW2SXdTUkPrsezjjVU19emts420EN-uhkHWb+4vrA@mail.gmail.com>
On Wed, 19 May 2021, Linus Walleij wrote:
> On Tue, May 18, 2021 at 2:15 PM Russell King (Oracle)
> <rmk+kernel@armlinux.org.uk> wrote:
>
> > Change the current vmalloc_min, which is supposed to be the lowest
> > address of vmalloc space including the VMALLOC_OFFSET, to vmalloc_start
> > which does not include VMALLOC_OFFSET.
> >
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> > +static unsigned long __initdata vmalloc_start = VMALLOC_END - (240 << 20);
>
> When I first read this it took me some time to figure out what was
> going on here, so if you have time, please fold in a comment
> with some explanation of that (240 << 20) thing, in some blog
> post I described it as "an interesting way to write 0x0f000000"
> but I suppose commit 0536bdf33faf chose this way for a
> specific reason? (Paging Nico if he can explain it.)
That's an alternative (and deprecated) way to write MB(240).
Nicolas
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Pitre <nico@fluxnic.net>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Yanfei Xu <yanfei.xu@windriver.com>,
Mike Rapoport <rppt@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Hailong liu <carver4lio@163.com>,
Tian Tao <tiantao6@hisilicon.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] ARM: change vmalloc_min to vmalloc_start
Date: Tue, 18 May 2021 18:26:54 -0400 (EDT) [thread overview]
Message-ID: <sons6q6-2630-rr8s-18ns-221454n9472@syhkavp.arg> (raw)
In-Reply-To: <CACRpkdbZObW2SXdTUkPrsezjjVU19emts420EN-uhkHWb+4vrA@mail.gmail.com>
On Wed, 19 May 2021, Linus Walleij wrote:
> On Tue, May 18, 2021 at 2:15 PM Russell King (Oracle)
> <rmk+kernel@armlinux.org.uk> wrote:
>
> > Change the current vmalloc_min, which is supposed to be the lowest
> > address of vmalloc space including the VMALLOC_OFFSET, to vmalloc_start
> > which does not include VMALLOC_OFFSET.
> >
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> > +static unsigned long __initdata vmalloc_start = VMALLOC_END - (240 << 20);
>
> When I first read this it took me some time to figure out what was
> going on here, so if you have time, please fold in a comment
> with some explanation of that (240 << 20) thing, in some blog
> post I described it as "an interesting way to write 0x0f000000"
> but I suppose commit 0536bdf33faf chose this way for a
> specific reason? (Paging Nico if he can explain it.)
That's an alternative (and deprecated) way to write MB(240).
Nicolas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-18 22:26 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 11:12 [PATCH] arm: make the size of vmalloc in cmdline and meminfo uniform Yanfei Xu
2021-05-18 11:12 ` Yanfei Xu
2021-05-18 11:29 ` Russell King (Oracle)
2021-05-18 11:29 ` Russell King (Oracle)
2021-05-18 12:06 ` Russell King (Oracle)
2021-05-18 12:06 ` Russell King (Oracle)
2021-05-18 12:15 ` [PATCH 1/4] ARM: change vmalloc_min to be unsigned long Russell King (Oracle)
2021-05-18 12:15 ` Russell King (Oracle)
2021-05-18 22:09 ` Linus Walleij
2021-05-18 22:09 ` Linus Walleij
2021-05-18 12:15 ` [PATCH 2/4] ARM: use a temporary variable to hold maximum vmalloc size Russell King (Oracle)
2021-05-18 12:15 ` Russell King (Oracle)
2021-05-18 22:11 ` Linus Walleij
2021-05-18 22:11 ` Linus Walleij
2021-05-18 12:15 ` [PATCH 3/4] ARM: change vmalloc_min to vmalloc_start Russell King (Oracle)
2021-05-18 12:15 ` Russell King (Oracle)
2021-05-18 22:19 ` Linus Walleij
2021-05-18 22:19 ` Linus Walleij
2021-05-18 22:26 ` Nicolas Pitre [this message]
2021-05-18 22:26 ` Nicolas Pitre
2021-05-18 22:32 ` Nicolas Pitre
2021-05-18 22:32 ` Nicolas Pitre
2021-05-18 22:34 ` Linus Walleij
2021-05-18 22:34 ` Linus Walleij
2021-05-18 22:38 ` Nicolas Pitre
2021-05-18 22:38 ` Nicolas Pitre
2021-05-28 9:55 ` Russell King (Oracle)
2021-05-28 9:55 ` Russell King (Oracle)
2021-05-19 4:41 ` Xu, Yanfei
2021-05-19 4:41 ` Xu, Yanfei
2021-05-20 9:00 ` Russell King (Oracle)
2021-05-20 9:00 ` Russell King (Oracle)
2021-05-28 2:52 ` Xu, Yanfei
2021-05-28 2:52 ` Xu, Yanfei
2021-05-28 10:00 ` Russell King (Oracle)
2021-05-28 10:00 ` Russell King (Oracle)
2021-05-19 5:25 ` Xu, Yanfei
2021-05-19 5:25 ` Xu, Yanfei
2021-05-18 12:15 ` [PATCH 4/4] ARM: change vmalloc_start to vmalloc_size Russell King (Oracle)
2021-05-18 12:15 ` Russell King (Oracle)
2021-05-18 22:21 ` Linus Walleij
2021-05-18 22:21 ` Linus Walleij
2021-05-19 4:39 ` [PATCH] arm: make the size of vmalloc in cmdline and meminfo uniform Xu, Yanfei
2021-05-19 4:39 ` Xu, Yanfei
2021-05-19 5:32 ` Xu, Yanfei
2021-05-19 5:32 ` Xu, Yanfei
2021-05-20 4:52 ` Alexander Dahl
2021-05-20 4:52 ` Alexander Dahl
2021-05-20 6:50 ` Xu, Yanfei
2021-05-20 6:50 ` Xu, Yanfei
2021-05-28 10:11 ` [PATCH v2 1/6] ARM: change vmalloc_min to be unsigned long Russell King (Oracle)
2021-05-28 10:11 ` Russell King (Oracle)
2021-05-28 13:10 ` Xu, Yanfei
2021-05-28 13:10 ` Xu, Yanfei
2021-05-28 10:11 ` [PATCH v2 2/6] ARM: use a temporary variable to hold maximum vmalloc size Russell King (Oracle)
2021-05-28 10:11 ` Russell King (Oracle)
2021-05-28 13:11 ` Xu, Yanfei
2021-05-28 13:11 ` Xu, Yanfei
2021-05-28 10:11 ` [PATCH v2 3/6] ARM: change vmalloc_min to vmalloc_start Russell King (Oracle)
2021-05-28 10:11 ` Russell King (Oracle)
2021-05-28 12:21 ` Linus Walleij
2021-05-28 12:21 ` Linus Walleij
2021-05-28 13:05 ` Xu, Yanfei
2021-05-28 13:05 ` Xu, Yanfei
2021-05-28 10:11 ` [PATCH v2 4/6] ARM: change vmalloc_start to vmalloc_size Russell King (Oracle)
2021-05-28 10:11 ` Russell King (Oracle)
2021-05-28 12:22 ` Linus Walleij
2021-05-28 12:22 ` Linus Walleij
2021-05-28 13:15 ` Xu, Yanfei
2021-05-28 13:15 ` Xu, Yanfei
2021-05-28 10:11 ` [PATCH v2 5/6] ARM: use "* SZ_1M" rather than "<< 20" Russell King (Oracle)
2021-05-28 10:11 ` Russell King (Oracle)
2021-05-28 12:23 ` Linus Walleij
2021-05-28 12:23 ` Linus Walleij
2021-05-28 13:17 ` Xu, Yanfei
2021-05-28 13:17 ` Xu, Yanfei
2021-05-28 10:11 ` [PATCH v2 6/6] ARM: use MiB for vmalloc sizes Russell King (Oracle)
2021-05-28 10:11 ` Russell King (Oracle)
2021-05-28 12:24 ` Linus Walleij
2021-05-28 12:24 ` Linus Walleij
2021-05-28 13:20 ` Xu, Yanfei
2021-05-28 13:20 ` Xu, Yanfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sons6q6-2630-rr8s-18ns-221454n9472@syhkavp.arg \
--to=nico@fluxnic.net \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=carver4lio@163.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rppt@kernel.org \
--cc=tiantao6@hisilicon.com \
--cc=yanfei.xu@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.