* Re: [PATCH] net: broadcom: fix a mistake about ioremap resource
@ 2020-05-05 7:19 Markus Elfring
2020-05-05 17:44 ` Jonathan Richardson
0 siblings, 1 reply; 4+ messages in thread
From: Markus Elfring @ 2020-05-05 7:19 UTC (permalink / raw)
To: Dejin Zheng, netdev
Cc: linux-kernel, David S. Miller, Florian Fainelli,
Jonathan Richardson, Petr Štetiar, Ray Jui, Scott Branden,
Stephen Boyd
> Commit d7a5502b0bb8b ("net: broadcom: convert to
> devm_platform_ioremap_resource_byname()") will broke this driver.
> idm_base and nicpm_base were optional, after this change, they are
> mandatory. it will probe fails with -22 when the dtb doesn't have them
> defined. so revert part of this commit and make idm_base and nicpm_base
> as optional.
I hope that other contributors can convince you to improve also this
commit message considerably.
Would you like to fix the spelling besides other wording weaknesses?
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: broadcom: fix a mistake about ioremap resource
2020-05-05 7:19 [PATCH] net: broadcom: fix a mistake about ioremap resource Markus Elfring
@ 2020-05-05 17:44 ` Jonathan Richardson
2020-05-07 11:16 ` Markus Elfring
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Richardson @ 2020-05-05 17:44 UTC (permalink / raw)
To: Markus Elfring
Cc: Dejin Zheng, netdev, linux-kernel, David S. Miller,
Florian Fainelli, Petr Štetiar, Ray Jui, Scott Branden,
Stephen Boyd
On Tue, May 5, 2020 at 12:20 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > Commit d7a5502b0bb8b ("net: broadcom: convert to
> > devm_platform_ioremap_resource_byname()") will broke this driver.
> > idm_base and nicpm_base were optional, after this change, they are
> > mandatory. it will probe fails with -22 when the dtb doesn't have them
> > defined. so revert part of this commit and make idm_base and nicpm_base
> > as optional.
>
> I hope that other contributors can convince you to improve also this
> commit message considerably.
> Would you like to fix the spelling besides other wording weaknesses?
How about this wording:
Commit d7a5502b0bb8b ("net: broadcom: convert to
devm_platform_ioremap_resource_byname()")
inadvertently made idm_base and nicpm_base mandatory. These are
optional properties.
probe will fail when they're not defined. The commit is partially
reverted so that they are
obtained by platform_get_resource_byname() as before. amac_base can
still be obtained
by devm_platform_ioremap_resource_byname().
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: net: broadcom: fix a mistake about ioremap resource
2020-05-05 17:44 ` Jonathan Richardson
@ 2020-05-07 11:16 ` Markus Elfring
0 siblings, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2020-05-07 11:16 UTC (permalink / raw)
To: Jonathan Richardson, David S. Miller, netdev
Cc: Dejin Zheng, Florian Fainelli, Petr Štetiar, Ray Jui,
Scott Branden, Stephen Boyd, LKML, kernel-janitors
>> I hope that other contributors can convince you to improve also this
>> commit message considerably.
>> Would you like to fix the spelling besides other wording weaknesses?
>
> How about this wording:
>
> Commit d7a5502b0bb8b ("net: broadcom: convert to
> devm_platform_ioremap_resource_byname()")
> inadvertently made idm_base and nicpm_base mandatory. These are
> optional properties.
> probe will fail when they're not defined. The commit is partially
> reverted so that they are
> obtained by platform_get_resource_byname() as before. amac_base can
> still be obtained
> by devm_platform_ioremap_resource_byname().
Is it interesting anyhow that another attempt for such an improvement
did not get the possibly desired software development attention?
https://lore.kernel.org/lkml/20200505.111206.118627398774406136.davem@davemloft.net/
https://lore.kernel.org/patchwork/comment/1430759/
https://lkml.org/lkml/2020/5/5/1114
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: net: broadcom: fix a mistake about ioremap resource
@ 2020-05-07 11:16 ` Markus Elfring
0 siblings, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2020-05-07 11:16 UTC (permalink / raw)
To: Jonathan Richardson, David S. Miller, netdev
Cc: Dejin Zheng, Florian Fainelli, Petr Štetiar, Ray Jui,
Scott Branden, Stephen Boyd, LKML, kernel-janitors
>> I hope that other contributors can convince you to improve also this
>> commit message considerably.
>> Would you like to fix the spelling besides other wording weaknesses?
>
> How about this wording:
>
> Commit d7a5502b0bb8b ("net: broadcom: convert to
> devm_platform_ioremap_resource_byname()")
> inadvertently made idm_base and nicpm_base mandatory. These are
> optional properties.
> probe will fail when they're not defined. The commit is partially
> reverted so that they are
> obtained by platform_get_resource_byname() as before. amac_base can
> still be obtained
> by devm_platform_ioremap_resource_byname().
Is it interesting anyhow that another attempt for such an improvement
did not get the possibly desired software development attention?
https://lore.kernel.org/lkml/20200505.111206.118627398774406136.davem@davemloft.net/
https://lore.kernel.org/patchwork/comment/1430759/
https://lkml.org/lkml/2020/5/5/1114
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-07 11:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-05 7:19 [PATCH] net: broadcom: fix a mistake about ioremap resource Markus Elfring
2020-05-05 17:44 ` Jonathan Richardson
2020-05-07 11:16 ` Markus Elfring
2020-05-07 11:16 ` Markus Elfring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.