* PATCH: calculate s3c2410 NAND timing values more accurately
@ 2007-02-12 19:39 Matt Reimer
2007-02-13 10:46 ` Matthieu CASTET
2007-02-13 11:09 ` Ben Dooks
0 siblings, 2 replies; 3+ messages in thread
From: Matt Reimer @ 2007-02-12 19:39 UTC (permalink / raw)
To: linux-mtd
[-- Attachment #1: Type: text/plain, Size: 277 bytes --]
Calculate NAND timing values more accurately on S3C2410, 2412, and
2440, whose registers differ slightly:
Enforce the TACLS max value as 3 on 2440 but 7 on 2410/2412.
Also, make it possible to specify a value of 0 on 2412/2440.
Signed-off-by: Matt Reimer <mreimer@vpop.net>
[-- Attachment #2: calc-rate.patch2 --]
[-- Type: application/octet-stream, Size: 1887 bytes --]
--- a/drivers/mtd/nand/s3c2410.c Tue Jan 30 12:54:43 2007
+++ b/drivers/mtd/nand/s3c2410.c Tue Jan 30 12:54:43 2007
@@ -168,9 +169,6 @@ static int s3c_nand_calc_rate(int wanted
return -1;
}
- if (result < 1)
- result = 1;
-
return result;
}
@@ -183,7 +181,7 @@ static int s3c2410_nand_inithw(struct s3
{
struct s3c2410_platform_nand *plat = to_nand_plat(pdev);
unsigned long clkrate = clk_get_rate(info->clk);
- int tacls_max = (info->cpu_type == TYPE_S3C2412) ? 8 : 4;
+ int tacls_max = (info->cpu_type == TYPE_S3C2440) ? 4 : 8;
int tacls, twrph0, twrph1;
unsigned long cfg = 0;
@@ -207,26 +205,34 @@ static int s3c2410_nand_inithw(struct s3
return -EINVAL;
}
- dev_info(info->device, "Tacls=%d, %dns Twrph0=%d %dns, Twrph1=%d %dns\n",
- tacls, to_ns(tacls, clkrate), twrph0, to_ns(twrph0, clkrate), twrph1, to_ns(twrph1, clkrate));
-
switch (info->cpu_type) {
case TYPE_S3C2410:
cfg = S3C2410_NFCONF_EN;
cfg |= S3C2410_NFCONF_TACLS(tacls - 1);
cfg |= S3C2410_NFCONF_TWRPH0(twrph0 - 1);
cfg |= S3C2410_NFCONF_TWRPH1(twrph1 - 1);
+
+ dev_info(info->device, "Tacls=%d, %dns Twrph0=%d %dns, Twrph1=%d %dns\n",
+ tacls - 1, to_ns(tacls, clkrate),
+ twrph0 - 1, to_ns(twrph0, clkrate),
+ twrph1 - 1, to_ns(twrph1, clkrate));
+
break;
case TYPE_S3C2440:
case TYPE_S3C2412:
- cfg = S3C2440_NFCONF_TACLS(tacls - 1);
+ cfg = S3C2440_NFCONF_TACLS(tacls);
cfg |= S3C2440_NFCONF_TWRPH0(twrph0 - 1);
cfg |= S3C2440_NFCONF_TWRPH1(twrph1 - 1);
/* enable the controller and de-assert nFCE */
writel(S3C2440_NFCONT_ENABLE, info->regs + S3C2440_NFCONT);
+
+ dev_info(info->device, "Tacls=%d, %dns Twrph0=%d %dns, Twrph1=%d %dns\n",
+ tacls, to_ns(tacls, clkrate),
+ twrph0 - 1, to_ns(twrph0, clkrate),
+ twrph1 - 1, to_ns(twrph1, clkrate));
}
dev_dbg(info->device, "NF_CONF is 0x%lx\n", cfg);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: calculate s3c2410 NAND timing values more accurately
2007-02-12 19:39 PATCH: calculate s3c2410 NAND timing values more accurately Matt Reimer
@ 2007-02-13 10:46 ` Matthieu CASTET
2007-02-13 11:09 ` Ben Dooks
1 sibling, 0 replies; 3+ messages in thread
From: Matthieu CASTET @ 2007-02-13 10:46 UTC (permalink / raw)
To: linux-mtd
Hi,
Matt Reimer <mattjreimer <at> gmail.com> writes:
>
> Calculate NAND timing values more accurately on S3C2410, 2412, and
> 2440, whose registers differ slightly:
>
> Enforce the TACLS max value as 3 on 2440 but 7 on 2410/2412.
>
> Also, make it possible to specify a value of 0 on 2412/2440.
>
If you remove the "if (result < 1) result = 1;" check in s3c_nand_calc_rate, I
believe you should check for twrph0 or twrph1 equal 0 in s3c2410_nand_inithw (ie
if (tacls < 0 || twrph0 <= 0 || twrph1 <= 0) { return error).
Matthieu
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: calculate s3c2410 NAND timing values more accurately
2007-02-12 19:39 PATCH: calculate s3c2410 NAND timing values more accurately Matt Reimer
2007-02-13 10:46 ` Matthieu CASTET
@ 2007-02-13 11:09 ` Ben Dooks
1 sibling, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2007-02-13 11:09 UTC (permalink / raw)
To: Matt Reimer; +Cc: linux-mtd
On Mon, Feb 12, 2007 at 11:39:55AM -0800, Matt Reimer wrote:
> Calculate NAND timing values more accurately on S3C2410, 2412, and
> 2440, whose registers differ slightly:
>
> Enforce the TACLS max value as 3 on 2440 but 7 on 2410/2412.
>
> Also, make it possible to specify a value of 0 on 2412/2440.
>
> Signed-off-by: Matt Reimer <mreimer@vpop.net>
Please in-line your patches next time, this makes it much easier
to make comments, like this:
--- a/drivers/mtd/nand/s3c2410.c Tue Jan 30 12:54:43 2007
+++ b/drivers/mtd/nand/s3c2410.c Tue Jan 30 12:54:43 2007
@@ -168,9 +169,6 @@ static int s3c_nand_calc_rate(int wanted
return -1;
}
- if (result < 1)
- result = 1;
-
return result;
}
@@ -183,7 +181,7 @@ static int s3c2410_nand_inithw(struct s3
{
struct s3c2410_platform_nand *plat = to_nand_plat(pdev);
unsigned long clkrate = clk_get_rate(info->clk);
- int tacls_max = (info->cpu_type == TYPE_S3C2412) ? 8 : 4;
+ int tacls_max = (info->cpu_type == TYPE_S3C2440) ? 4 : 8;
int tacls, twrph0, twrph1;
unsigned long cfg = 0;
@@ -207,26 +205,34 @@ static int s3c2410_nand_inithw(struct s3
return -EINVAL;
}
- dev_info(info->device, "Tacls=%d, %dns Twrph0=%d %dns, Twrph1=%d %dns\n",
- tacls, to_ns(tacls, clkrate), twrph0, to_ns(twrph0, clkrate), twrph1, to_ns(twrph1, clkrate));
-
switch (info->cpu_type) {
case TYPE_S3C2410:
cfg = S3C2410_NFCONF_EN;
cfg |= S3C2410_NFCONF_TACLS(tacls - 1);
cfg |= S3C2410_NFCONF_TWRPH0(twrph0 - 1);
cfg |= S3C2410_NFCONF_TWRPH1(twrph1 - 1);
+
+ dev_info(info->device, "Tacls=%d, %dns Twrph0=%d %dns, Twrph1=%d %dns\n",
+ tacls - 1, to_ns(tacls, clkrate),
+ twrph0 - 1, to_ns(twrph0, clkrate),
+ twrph1 - 1, to_ns(twrph1, clkrate));
+
break;
case TYPE_S3C2440:
case TYPE_S3C2412:
- cfg = S3C2440_NFCONF_TACLS(tacls - 1);
+ cfg = S3C2440_NFCONF_TACLS(tacls);
cfg |= S3C2440_NFCONF_TWRPH0(twrph0 - 1);
cfg |= S3C2440_NFCONF_TWRPH1(twrph1 - 1);
According to the S3C2440A datasheet, the duration is defined
as `HCLK * (TACLS+1)` unlike the S3C2412 which defines it as
`HCLK * TALCS`.
/* enable the controller and de-assert nFCE */
writel(S3C2440_NFCONT_ENABLE, info->regs + S3C2440_NFCONT);
+
+ dev_info(info->device, "Tacls=%d, %dns Twrph0=%d %dns, Twrph1=%d %dns\n",
+ tacls, to_ns(tacls, clkrate),
+ twrph0 - 1, to_ns(twrph0, clkrate),
+ twrph1 - 1, to_ns(twrph1, clkrate));
}
dev_dbg(info->device, "NF_CONF is 0x%lx\n", cfg);
I'll post the patch I've done
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-02-13 11:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-12 19:39 PATCH: calculate s3c2410 NAND timing values more accurately Matt Reimer
2007-02-13 10:46 ` Matthieu CASTET
2007-02-13 11:09 ` Ben Dooks
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.