From: YueHaibing <yuehaibing@huawei.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
<linux-omap@vger.kernel.org>, <netdev@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()
Date: Mon, 29 Apr 2019 22:17:48 +0800 [thread overview]
Message-ID: <f3b8d542-9ba6-d867-4979-530b53a395d5@huawei.com> (raw)
In-Reply-To: <20190429135603.GI10772@lunn.ch>
On 2019/4/29 21:56, Andrew Lunn wrote:
> On Mon, Apr 29, 2019 at 01:56:50PM +0000, YueHaibing wrote:
>> Change the call to PTR_ERR to access the value just tested by IS_ERR.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Please could you add a Fixes: tag.
>
Ok, will sendv2, thanks!
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Andrew
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: YueHaibing <yuehaibing@huawei.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
linux-omap@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()
Date: Mon, 29 Apr 2019 14:17:48 +0000 [thread overview]
Message-ID: <f3b8d542-9ba6-d867-4979-530b53a395d5@huawei.com> (raw)
In-Reply-To: <20190429135603.GI10772@lunn.ch>
On 2019/4/29 21:56, Andrew Lunn wrote:
> On Mon, Apr 29, 2019 at 01:56:50PM +0000, YueHaibing wrote:
>> Change the call to PTR_ERR to access the value just tested by IS_ERR.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Please could you add a Fixes: tag.
>
Ok, will sendv2, thanks!
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Andrew
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: YueHaibing <yuehaibing@huawei.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
linux-omap@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()
Date: Mon, 29 Apr 2019 22:17:48 +0800 [thread overview]
Message-ID: <f3b8d542-9ba6-d867-4979-530b53a395d5@huawei.com> (raw)
In-Reply-To: <20190429135603.GI10772@lunn.ch>
On 2019/4/29 21:56, Andrew Lunn wrote:
> On Mon, Apr 29, 2019 at 01:56:50PM +0000, YueHaibing wrote:
>> Change the call to PTR_ERR to access the value just tested by IS_ERR.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Please could you add a Fixes: tag.
>
Ok, will sendv2, thanks!
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Andrew
>
> .
>
next prev parent reply other threads:[~2019-04-29 14:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 13:56 [PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe() YueHaibing
2019-04-29 13:56 ` YueHaibing
2019-04-29 13:56 ` YueHaibing
2019-04-29 13:56 ` Andrew Lunn
2019-04-29 13:56 ` Andrew Lunn
2019-04-29 14:17 ` YueHaibing [this message]
2019-04-29 14:17 ` YueHaibing
2019-04-29 14:17 ` YueHaibing
2019-04-29 14:31 ` [PATCH v2 " YueHaibing
2019-04-29 14:31 ` YueHaibing
2019-04-29 16:30 ` Julia Lawall
2019-04-29 16:30 ` Julia Lawall
2019-04-30 1:33 ` YueHaibing
2019-04-30 1:33 ` YueHaibing
2019-04-30 1:33 ` YueHaibing
2019-04-30 1:55 ` [PATCH v3 " YueHaibing
2019-04-30 1:55 ` YueHaibing
2019-05-01 18:29 ` David Miller
2019-05-01 18:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3b8d542-9ba6-d867-4979-530b53a395d5@huawei.com \
--to=yuehaibing@huawei.com \
--cc=andrew@lunn.ch \
--cc=grygorii.strashko@ti.com \
--cc=ilias.apalodimas@linaro.org \
--cc=ivan.khoronzhuk@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.