From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Ladislav Michl <ladis@linux-mips.org>, Pavel Machek <pavel@ucw.cz>
Cc: mark.rutland@arm.com, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, tony@atomide.com, abcloriens@gmail.com,
tiwai@suse.com, martijn@brixit.nl,
"Filip Matijević" <filip.matijevic.pz@gmail.com>,
patrikbachan@gmail.com, ivo.g.dimitrov.75@gmail.com,
khilman@kernel.org, serge@hallyn.com, devicetree@vger.kernel.org,
pali.rohar@gmail.com, robh+dt@kernel.org,
linux-omap@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
aaro.koskinen@iki.fi, linux-kernel@vger.kernel.org,
broonie@kernel.org, clayton@craftyguy.net,
sakari.ailus@linux.intel.com, sre@kernel.org, bhumirks@gmail.com
Subject: Re: [alsa-devel] [PATCH] sound/tlv320dac33: Add device tree support
Date: Wed, 31 Jan 2018 11:12:20 +0200 [thread overview]
Message-ID: <f3f23e16-2045-78bd-b77e-f236cab3b85d@ti.com> (raw)
In-Reply-To: <20180129232031.GA7695@lenoch>
On 2018-01-30 01:20, Ladislav Michl wrote:
> On Tue, Jan 30, 2018 at 12:05:39AM +0100, Pavel Machek wrote:
>>
>> This adds device tree support to tlv320dac33.c.
>>
>> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>>
>> diff --git a/Documentation/devicetree/bindings/sound/tlv320dac33.txt b/Documentation/devicetree/bindings/sound/tlv320dac33.txt
>> new file mode 100644
>> index 0000000..6cbd311
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/tlv320dac33.txt
>> @@ -0,0 +1,32 @@
>> +Texas Instruments - tlv320dac33 Codec module
>> +
>> +The tlv320dac33 serial control bus communicates through I2C protocols.
>> +
>> +Required properties:
>> +
>> +- compatible - "ti,tlv320dac33"
>> +- reg - I2C slave address
>> +
>> +Optional properties:
>> +
>> +- power-gpios - gpio pin to power the device, active high
>
> While driver used gpio in platform data, isn't it more likely
> regulator which powers device?
It is GPIO, and according to the non public TRM it is connected to the
reset pin of the codec.
So the correct name should be reset-gpios
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Ladislav Michl <ladis@linux-mips.org>, Pavel Machek <pavel@ucw.cz>
Cc: mark.rutland@arm.com, alsa-devel@alsa-project.org,
tony@atomide.com, abcloriens@gmail.com, lgirdwood@gmail.com,
martijn@brixit.nl,
"Filip Matijević" <filip.matijevic.pz@gmail.com>,
patrikbachan@gmail.com, ivo.g.dimitrov.75@gmail.com,
khilman@kernel.org, tiwai@suse.com, serge@hallyn.com,
devicetree@vger.kernel.org, broonie@kernel.org, sre@kernel.org,
linux-omap@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
aaro.koskinen@iki.fi, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, clayton@craftyguy.net,
sakari.ailus@linux.intel.com, pali.rohar@gmail.com,
bhumirks@gmail.com
Subject: Re: [PATCH] sound/tlv320dac33: Add device tree support
Date: Wed, 31 Jan 2018 11:12:20 +0200 [thread overview]
Message-ID: <f3f23e16-2045-78bd-b77e-f236cab3b85d@ti.com> (raw)
In-Reply-To: <20180129232031.GA7695@lenoch>
On 2018-01-30 01:20, Ladislav Michl wrote:
> On Tue, Jan 30, 2018 at 12:05:39AM +0100, Pavel Machek wrote:
>>
>> This adds device tree support to tlv320dac33.c.
>>
>> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>>
>> diff --git a/Documentation/devicetree/bindings/sound/tlv320dac33.txt b/Documentation/devicetree/bindings/sound/tlv320dac33.txt
>> new file mode 100644
>> index 0000000..6cbd311
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/tlv320dac33.txt
>> @@ -0,0 +1,32 @@
>> +Texas Instruments - tlv320dac33 Codec module
>> +
>> +The tlv320dac33 serial control bus communicates through I2C protocols.
>> +
>> +Required properties:
>> +
>> +- compatible - "ti,tlv320dac33"
>> +- reg - I2C slave address
>> +
>> +Optional properties:
>> +
>> +- power-gpios - gpio pin to power the device, active high
>
> While driver used gpio in platform data, isn't it more likely
> regulator which powers device?
It is GPIO, and according to the non public TRM it is connected to the
reset pin of the codec.
So the correct name should be reset-gpios
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH] sound/tlv320dac33: Add device tree support
Date: Wed, 31 Jan 2018 11:12:20 +0200 [thread overview]
Message-ID: <f3f23e16-2045-78bd-b77e-f236cab3b85d@ti.com> (raw)
In-Reply-To: <20180129232031.GA7695@lenoch>
On 2018-01-30 01:20, Ladislav Michl wrote:
> On Tue, Jan 30, 2018 at 12:05:39AM +0100, Pavel Machek wrote:
>>
>> This adds device tree support to tlv320dac33.c.
>>
>> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>>
>> diff --git a/Documentation/devicetree/bindings/sound/tlv320dac33.txt b/Documentation/devicetree/bindings/sound/tlv320dac33.txt
>> new file mode 100644
>> index 0000000..6cbd311
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/tlv320dac33.txt
>> @@ -0,0 +1,32 @@
>> +Texas Instruments - tlv320dac33 Codec module
>> +
>> +The tlv320dac33 serial control bus communicates through I2C protocols.
>> +
>> +Required properties:
>> +
>> +- compatible - "ti,tlv320dac33"
>> +- reg - I2C slave address
>> +
>> +Optional properties:
>> +
>> +- power-gpios - gpio pin to power the device, active high
>
> While driver used gpio in platform data, isn't it more likely
> regulator which powers device?
It is GPIO, and according to the non public TRM it is connected to the
reset pin of the codec.
So the correct name should be reset-gpios
- P?ter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2018-01-31 9:14 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 23:05 [PATCH] sound/tlv320dac33: Add device tree support Pavel Machek
2018-01-29 23:05 ` Pavel Machek
2018-01-29 23:20 ` Ladislav Michl
2018-01-29 23:20 ` Ladislav Michl
2018-01-29 23:20 ` Ladislav Michl
2018-01-29 23:33 ` Pavel Machek
2018-01-29 23:33 ` Pavel Machek
2018-01-30 8:34 ` Ladislav Michl
2018-01-30 8:34 ` Ladislav Michl
2018-01-30 8:53 ` Pavel Machek
2018-01-30 8:53 ` Pavel Machek
2018-01-30 8:53 ` Pavel Machek
2018-01-30 9:11 ` Filip Matijević
2018-01-30 9:11 ` Filip Matijević
2018-01-30 9:38 ` Ladislav Michl
2018-01-30 9:38 ` Ladislav Michl
2018-01-30 9:38 ` Ladislav Michl
2018-01-30 10:00 ` Pavel Machek
2018-01-30 10:00 ` Pavel Machek
2018-01-30 10:00 ` Pavel Machek
2018-01-30 10:10 ` Ladislav Michl
2018-01-30 10:10 ` Ladislav Michl
2018-01-30 10:35 ` Pavel Machek
2018-01-30 10:35 ` Pavel Machek
2018-01-30 10:35 ` Pavel Machek
2018-01-30 11:38 ` Ladislav Michl
2018-01-30 11:38 ` Ladislav Michl
2018-01-30 11:38 ` Ladislav Michl
2018-01-31 9:24 ` [alsa-devel] " Peter Ujfalusi
2018-01-31 9:24 ` Peter Ujfalusi
2018-01-31 9:24 ` Peter Ujfalusi
2018-01-30 11:32 ` Mark Brown
2018-01-30 11:32 ` Mark Brown
2018-01-30 11:32 ` Mark Brown
2018-01-30 12:28 ` Pavel Machek
2018-01-30 12:28 ` Pavel Machek
2018-01-30 12:28 ` Pavel Machek
2018-01-31 9:12 ` Peter Ujfalusi [this message]
2018-01-31 9:12 ` [alsa-devel] " Peter Ujfalusi
2018-01-31 9:12 ` Peter Ujfalusi
2018-01-31 19:01 ` [PATCHv2] tlv320dac33: Add device tree bindings Pavel Machek
2018-01-31 19:01 ` Pavel Machek
2018-02-01 7:39 ` Peter Ujfalusi
2018-02-01 7:39 ` Peter Ujfalusi
2018-02-05 8:24 ` [PATCHv3] " Pavel Machek
2018-02-05 8:24 ` Pavel Machek
2018-02-05 8:24 ` Pavel Machek
2018-02-06 12:11 ` Mark Brown
2018-02-06 12:11 ` Mark Brown
2018-02-06 12:11 ` Mark Brown
2018-02-06 13:49 ` Pavel Machek
2018-02-06 13:49 ` Pavel Machek
2018-02-06 13:49 ` Pavel Machek
2018-02-06 15:27 ` Mark Brown
2018-02-06 15:27 ` Mark Brown
2018-02-06 15:27 ` Mark Brown
2018-02-24 20:57 ` Pavel Machek
2018-02-24 20:57 ` Pavel Machek
2018-02-24 20:57 ` Pavel Machek
2018-03-05 12:52 ` Peter Ujfalusi
2018-03-05 12:52 ` Peter Ujfalusi
2018-03-05 12:52 ` Peter Ujfalusi
2018-02-09 2:25 ` Rob Herring
2018-02-09 2:25 ` Rob Herring
2018-02-09 2:25 ` Rob Herring
2018-02-05 6:08 ` [PATCHv2] " Rob Herring
2018-02-05 6:08 ` Rob Herring
2018-02-05 6:08 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3f23e16-2045-78bd-b77e-f236cab3b85d@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=abcloriens@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=bhumirks@gmail.com \
--cc=broonie@kernel.org \
--cc=clayton@craftyguy.net \
--cc=devicetree@vger.kernel.org \
--cc=filip.matijevic.pz@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=ladis@linux-mips.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martijn@brixit.nl \
--cc=pali.rohar@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=serge@hallyn.com \
--cc=sre@kernel.org \
--cc=tiwai@suse.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.