From: Jan Kiszka <jan.kiszka@siemens.com> To: Michal Simek <michal.simek@xilinx.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: stable@vger.kernel.org, Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>, Jiri Slaby <jslaby@suse.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-serial <linux-serial@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: [PATCH] Revert "tty: xilinx_uartps: Fix missing id assignment to the console" Date: Thu, 18 Jun 2020 10:11:40 +0200 [thread overview] Message-ID: <f4092727-d8f5-5f91-2c9f-76643aace993@siemens.com> (raw) From: Jan Kiszka <jan.kiszka@siemens.com> This reverts commit 2ae11c46d5fdc46cb396e35911c713d271056d35. It turned out to break the ultra96-rev1, e.g., which uses uart1 as serial0 (and stdout-path = "serial0:115200n8"). Cc: stable <stable@vger.kernel.org> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- drivers/tty/serial/xilinx_uartps.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 35e9e8faf8de..ac137b6a1dc1 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1459,7 +1459,6 @@ static int cdns_uart_probe(struct platform_device *pdev) cdns_uart_uart_driver.nr = CDNS_UART_NR_PORTS; #ifdef CONFIG_SERIAL_XILINX_PS_UART_CONSOLE cdns_uart_uart_driver.cons = &cdns_uart_console; - cdns_uart_console.index = id; #endif rc = uart_register_driver(&cdns_uart_uart_driver); -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com> To: Michal Simek <michal.simek@xilinx.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, stable@vger.kernel.org, linux-serial <linux-serial@vger.kernel.org>, Jiri Slaby <jslaby@suse.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: [PATCH] Revert "tty: xilinx_uartps: Fix missing id assignment to the console" Date: Thu, 18 Jun 2020 10:11:40 +0200 [thread overview] Message-ID: <f4092727-d8f5-5f91-2c9f-76643aace993@siemens.com> (raw) From: Jan Kiszka <jan.kiszka@siemens.com> This reverts commit 2ae11c46d5fdc46cb396e35911c713d271056d35. It turned out to break the ultra96-rev1, e.g., which uses uart1 as serial0 (and stdout-path = "serial0:115200n8"). Cc: stable <stable@vger.kernel.org> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- drivers/tty/serial/xilinx_uartps.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 35e9e8faf8de..ac137b6a1dc1 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1459,7 +1459,6 @@ static int cdns_uart_probe(struct platform_device *pdev) cdns_uart_uart_driver.nr = CDNS_UART_NR_PORTS; #ifdef CONFIG_SERIAL_XILINX_PS_UART_CONSOLE cdns_uart_uart_driver.cons = &cdns_uart_console; - cdns_uart_console.index = id; #endif rc = uart_register_driver(&cdns_uart_uart_driver); -- 2.26.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-06-18 8:16 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-18 8:11 Jan Kiszka [this message] 2020-06-18 8:11 ` [PATCH] Revert "tty: xilinx_uartps: Fix missing id assignment to the console" Jan Kiszka 2020-06-18 8:17 ` Michal Simek 2020-06-18 8:17 ` Michal Simek 2020-07-09 7:48 ` [PATCH] tty: xilinx_uartps: Really fix id assignment Helmut Grohne 2020-07-09 7:48 ` Helmut Grohne 2020-07-10 11:45 ` Michal Simek 2020-07-10 11:45 ` Michal Simek 2020-07-13 7:11 ` Helmut Grohne 2020-07-13 7:11 ` Helmut Grohne 2020-07-13 11:49 ` Michal Simek 2020-07-13 11:49 ` Michal Simek 2020-07-13 12:10 ` Helmut Grohne 2020-07-13 12:10 ` Helmut Grohne 2020-07-13 16:08 ` Maarten Brock 2020-07-13 16:08 ` Maarten Brock 2020-07-22 7:18 ` Michal Simek 2020-07-22 7:18 ` Michal Simek 2020-07-22 16:50 ` Maarten Brock 2020-07-22 16:50 ` Maarten Brock 2020-07-24 9:19 ` Michal Simek 2020-07-24 9:19 ` Michal Simek 2020-07-22 7:14 ` Michal Simek 2020-07-23 9:50 ` Helmut Grohne 2020-07-23 9:50 ` Helmut Grohne 2020-07-24 8:43 ` Michal Simek 2020-07-24 8:43 ` Michal Simek 2020-07-10 12:45 ` Greg Kroah-Hartman 2020-07-10 12:45 ` Greg Kroah-Hartman 2020-07-13 7:32 ` [PATCH v2] " Helmut Grohne 2020-07-13 7:32 ` Helmut Grohne
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f4092727-d8f5-5f91-2c9f-76643aace993@siemens.com \ --to=jan.kiszka@siemens.com \ --cc=gregkh@linuxfoundation.org \ --cc=jslaby@suse.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=michal.simek@xilinx.com \ --cc=shubhrajyoti.datta@xilinx.com \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.