All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helmut Grohne <helmut.grohne@intenta.de>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
	"Jan Kiszka" <jan.kiszka@web.de>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] tty: xilinx_uartps: Really fix id assignment
Date: Thu, 23 Jul 2020 11:50:30 +0200	[thread overview]
Message-ID: <20200723095030.GA23929@laureti-dev> (raw)
In-Reply-To: <7fea9efe-f439-33a3-966f-4215681ec4c8@xilinx.com>

Hi Michal,

On Wed, Jul 22, 2020 at 09:14:40AM +0200, Michal Simek wrote:
> On 13. 07. 20 14:10, Helmut Grohne wrote:
> > Can we maybe trim down the matrix somehow? In my context, the need for
> > swapping the serial aliases arises from a limitation in u-boot-xlnx and
> > the desire to use one dtb for both linux and u-boot. It requires that
> > the serial0 alias is the console. Are there other reasons to swap them?
> > If not, maybe fixing u-boot would be an option?
> 
> I am not aware about any limitation in u-boot in this space. U-Boot is
> working with aliases and also with stdout-patch selection.
> Can you please elaborate more on this?

I have retested this (with more recent versions than earlier).

I confirm that u-boot correctly deals with aliases and
chosen/stdout-path. Using linear aliases and assigning stdout to serial1
works.

I also confirm that having ttyPS1 without having ttyPS0 works (only
tested with this patch applied). I questioned this earlier.

So it seems that the need for reversing these aliases is less strong
now. If I remember correctly, Jan Kiszka was also using reversed
aliases, but I don't know why.

Helmut

WARNING: multiple messages have this Message-ID (diff)
From: Helmut Grohne <helmut.grohne@intenta.de>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
	Jan Kiszka <jan.kiszka@web.de>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	Jiri Slaby <jslaby@suse.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] tty: xilinx_uartps: Really fix id assignment
Date: Thu, 23 Jul 2020 11:50:30 +0200	[thread overview]
Message-ID: <20200723095030.GA23929@laureti-dev> (raw)
In-Reply-To: <7fea9efe-f439-33a3-966f-4215681ec4c8@xilinx.com>

Hi Michal,

On Wed, Jul 22, 2020 at 09:14:40AM +0200, Michal Simek wrote:
> On 13. 07. 20 14:10, Helmut Grohne wrote:
> > Can we maybe trim down the matrix somehow? In my context, the need for
> > swapping the serial aliases arises from a limitation in u-boot-xlnx and
> > the desire to use one dtb for both linux and u-boot. It requires that
> > the serial0 alias is the console. Are there other reasons to swap them?
> > If not, maybe fixing u-boot would be an option?
> 
> I am not aware about any limitation in u-boot in this space. U-Boot is
> working with aliases and also with stdout-patch selection.
> Can you please elaborate more on this?

I have retested this (with more recent versions than earlier).

I confirm that u-boot correctly deals with aliases and
chosen/stdout-path. Using linear aliases and assigning stdout to serial1
works.

I also confirm that having ttyPS1 without having ttyPS0 works (only
tested with this patch applied). I questioned this earlier.

So it seems that the need for reversing these aliases is less strong
now. If I remember correctly, Jan Kiszka was also using reversed
aliases, but I don't know why.

Helmut

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-07-23  9:50 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18  8:11 [PATCH] Revert "tty: xilinx_uartps: Fix missing id assignment to the console" Jan Kiszka
2020-06-18  8:11 ` Jan Kiszka
2020-06-18  8:17 ` Michal Simek
2020-06-18  8:17   ` Michal Simek
2020-07-09  7:48 ` [PATCH] tty: xilinx_uartps: Really fix id assignment Helmut Grohne
2020-07-09  7:48   ` Helmut Grohne
2020-07-10 11:45   ` Michal Simek
2020-07-10 11:45     ` Michal Simek
2020-07-13  7:11     ` Helmut Grohne
2020-07-13  7:11       ` Helmut Grohne
2020-07-13 11:49       ` Michal Simek
2020-07-13 11:49         ` Michal Simek
2020-07-13 12:10         ` Helmut Grohne
2020-07-13 12:10           ` Helmut Grohne
2020-07-13 16:08           ` Maarten Brock
2020-07-13 16:08             ` Maarten Brock
2020-07-22  7:18             ` Michal Simek
2020-07-22  7:18               ` Michal Simek
2020-07-22 16:50               ` Maarten Brock
2020-07-22 16:50                 ` Maarten Brock
2020-07-24  9:19                 ` Michal Simek
2020-07-24  9:19                   ` Michal Simek
2020-07-22  7:14           ` Michal Simek
2020-07-23  9:50             ` Helmut Grohne [this message]
2020-07-23  9:50               ` Helmut Grohne
2020-07-24  8:43               ` Michal Simek
2020-07-24  8:43                 ` Michal Simek
2020-07-10 12:45   ` Greg Kroah-Hartman
2020-07-10 12:45     ` Greg Kroah-Hartman
2020-07-13  7:32     ` [PATCH v2] " Helmut Grohne
2020-07-13  7:32       ` Helmut Grohne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200723095030.GA23929@laureti-dev \
    --to=helmut.grohne@intenta.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jan.kiszka@web.de \
    --cc=jslaby@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=shubhrajyoti.datta@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.