From: Lv Zheng <lv.zheng@intel.com> To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <len.brown@intel.com> Cc: Lv Zheng <lv.zheng@intel.com>, Lv Zheng <zetalog@gmail.com>, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Bob Moore <robert.moore@intel.com> Subject: [PATCH v5 2/5] ACPICA: Parser: Fix a regression in LoadTable support Date: Fri, 23 Sep 2016 11:26:43 +0800 [thread overview] Message-ID: <f42c3327e0be2593c86e4a7e640bd9ebea1800a1.1474600034.git.lv.zheng@intel.com> (raw) In-Reply-To: <cover.1474600034.git.lv.zheng@intel.com> ACPICA commit a78506e0ce8ab1d20db2a055d99cf9143e89eb29 LoadTable allows an alternative RootPathString than the default "\", while the new table execution support fails to keep this logic. This regression can be detected by ASLTS - TLT0.tst4, this patch fixes this regression. Linux upstream is not affected by this regression as we haven't enabled the new table execution support there. BZ 1326, Lv Zheng. Link: https://github.com/acpica/acpica/commit/a78506e0 Link: https://bugs.acpica.org/show_bug.cgi?id=1326 Signed-off-by: Lv Zheng <lv.zheng@intel.com> Signed-off-by: Bob Moore <robert.moore@intel.com> --- drivers/acpi/acpica/psxface.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/acpi/acpica/psxface.c b/drivers/acpi/acpica/psxface.c index 8d7e5b5..f3c8726 100644 --- a/drivers/acpi/acpica/psxface.c +++ b/drivers/acpi/acpica/psxface.c @@ -305,6 +305,17 @@ acpi_status acpi_ps_execute_table(struct acpi_evaluate_info *info) walk_state->parse_flags |= ACPI_PARSE_MODULE_LEVEL; } + /* Info->Node is the default location to load the table */ + + if (info->node && info->node != acpi_gbl_root_node) { + status = + acpi_ds_scope_stack_push(info->node, ACPI_TYPE_METHOD, + walk_state); + if (ACPI_FAILURE(status)) { + goto cleanup; + } + } + /* * Parse the AML, walk_state will be deleted by parse_aml */ -- 1.7.10
WARNING: multiple messages have this Message-ID (diff)
From: Lv Zheng <lv.zheng@intel.com> To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <len.brown@intel.com> Cc: Lv Zheng <lv.zheng@intel.com>, Lv Zheng <zetalog@gmail.com>, <linux-kernel@vger.kernel.org>, linux-acpi@vger.kernel.org, Bob Moore <robert.moore@intel.com> Subject: [PATCH v5 2/5] ACPICA: Parser: Fix a regression in LoadTable support Date: Fri, 23 Sep 2016 11:26:43 +0800 [thread overview] Message-ID: <f42c3327e0be2593c86e4a7e640bd9ebea1800a1.1474600034.git.lv.zheng@intel.com> (raw) In-Reply-To: <cover.1474600034.git.lv.zheng@intel.com> ACPICA commit a78506e0ce8ab1d20db2a055d99cf9143e89eb29 LoadTable allows an alternative RootPathString than the default "\", while the new table execution support fails to keep this logic. This regression can be detected by ASLTS - TLT0.tst4, this patch fixes this regression. Linux upstream is not affected by this regression as we haven't enabled the new table execution support there. BZ 1326, Lv Zheng. Link: https://github.com/acpica/acpica/commit/a78506e0 Link: https://bugs.acpica.org/show_bug.cgi?id=1326 Signed-off-by: Lv Zheng <lv.zheng@intel.com> Signed-off-by: Bob Moore <robert.moore@intel.com> --- drivers/acpi/acpica/psxface.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/acpi/acpica/psxface.c b/drivers/acpi/acpica/psxface.c index 8d7e5b5..f3c8726 100644 --- a/drivers/acpi/acpica/psxface.c +++ b/drivers/acpi/acpica/psxface.c @@ -305,6 +305,17 @@ acpi_status acpi_ps_execute_table(struct acpi_evaluate_info *info) walk_state->parse_flags |= ACPI_PARSE_MODULE_LEVEL; } + /* Info->Node is the default location to load the table */ + + if (info->node && info->node != acpi_gbl_root_node) { + status = + acpi_ds_scope_stack_push(info->node, ACPI_TYPE_METHOD, + walk_state); + if (ACPI_FAILURE(status)) { + goto cleanup; + } + } + /* * Parse the AML, walk_state will be deleted by parse_aml */ -- 1.7.10
next prev parent reply other threads:[~2016-09-23 3:26 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <0e65135af51d94db0410c7059f3bc3a2300fc3b5> 2016-05-13 5:35 ` [PATCH v2 0/4] ACPI 2.0: Enable TermList interpretion for table loading Lv Zheng 2016-05-13 5:35 ` Lv Zheng 2016-05-13 5:35 ` [PATCH v2 1/4] ACPICA: Dispatcher: Fix an issue that the opregions created by the linked MLC were not tracked Lv Zheng 2016-05-13 5:35 ` Lv Zheng 2016-05-13 5:35 ` [PATCH v2 2/4] ACPICA: ACPI 2.0, Interpreter: Fix MLC issues by switching to new TermList grammar for table loading Lv Zheng 2016-05-13 5:35 ` Lv Zheng 2016-05-13 5:35 ` [PATCH v2 3/4] ACPI 2.0 / AML: Enable correct ACPI subsystem initialization order for new table loading mode Lv Zheng 2016-05-13 5:35 ` Lv Zheng 2016-05-13 5:35 ` [PATCH v2 4/4] ACPI 2.0 / AML: Fix module level execution by correctly parsing table as TermList Lv Zheng 2016-05-13 5:35 ` Lv Zheng 2016-05-17 0:29 ` [PATCH v2 0/4] ACPI 2.0: Enable TermList interpretion for table loading Zheng, Lv 2016-05-17 23:23 ` Rafael J. Wysocki 2016-05-20 0:57 ` Zheng, Lv 2016-06-10 1:05 ` Rafael J. Wysocki 2016-06-12 1:02 ` Zheng, Lv 2016-06-13 22:59 ` Rafael J. Wysocki 2016-06-20 9:07 ` [PATCH v3 0/5] " Lv Zheng 2016-06-20 9:07 ` Lv Zheng 2016-06-20 9:07 ` [PATCH v3 1/5] ACPICA: Namespace: Fix a regression that MLC support triggers dead lock in dynamic " Lv Zheng 2016-06-20 9:07 ` Lv Zheng 2016-06-20 10:57 ` Mika Westerberg 2016-06-20 10:57 ` Mika Westerberg 2016-06-20 23:13 ` Zheng, Lv 2016-06-20 9:07 ` [PATCH v3 2/5] ACPICA: Dispatcher: Fix an issue that the opregions created by the linked MLC were not tracked Lv Zheng 2016-06-20 9:07 ` Lv Zheng 2016-06-20 9:07 ` [PATCH v3 3/5] ACPICA: ACPI 2.0, Interpreter: Fix MLC issues by switching to new TermList grammar for table loading Lv Zheng 2016-06-20 9:07 ` Lv Zheng 2016-06-20 9:07 ` [PATCH v3 4/5] ACPI 2.0 / AML: Enable correct ACPI subsystem initialization order for new table loading mode Lv Zheng 2016-06-20 9:07 ` Lv Zheng 2016-06-20 9:07 ` [PATCH v3 5/5] ACPI 2.0 / AML: Fix module level execution by correctly parsing table as TermList Lv Zheng 2016-06-20 9:07 ` Lv Zheng 2016-06-21 4:34 ` [PATCH v4 0/5] ACPI 2.0: Enable TermList interpretion for table loading Lv Zheng 2016-06-21 4:34 ` Lv Zheng 2016-06-21 4:34 ` [PATCH v4 1/5] ACPICA: Namespace: Fix a regression that MLC support triggers dead lock in dynamic " Lv Zheng 2016-06-21 4:34 ` Lv Zheng 2016-06-21 7:58 ` Mika Westerberg 2016-06-21 9:55 ` Zheng, Lv 2016-06-23 0:41 ` Rafael J. Wysocki 2016-06-21 4:34 ` [PATCH v4 2/5] ACPICA: Dispatcher: Fix an issue that the opregions created by the linked MLC were not tracked Lv Zheng 2016-06-21 4:34 ` Lv Zheng 2016-06-21 4:34 ` [PATCH v4 3/5] ACPICA: ACPI 2.0, Interpreter: Fix MLC issues by switching to new TermList grammar for table loading Lv Zheng 2016-06-21 4:34 ` Lv Zheng 2016-07-04 23:42 ` Zheng, Lv 2016-07-05 0:09 ` Rafael J. Wysocki 2016-06-21 4:34 ` [PATCH v4 4/5] ACPI 2.0 / AML: Enable correct ACPI subsystem initialization order for new table loading mode Lv Zheng 2016-06-21 4:34 ` Lv Zheng 2016-06-21 4:34 ` [PATCH v4 5/5] ACPI 2.0 / AML: Fix module level execution by correctly parsing table as TermList Lv Zheng 2016-06-21 4:34 ` Lv Zheng 2016-09-23 3:26 ` [PATCH v5 0/5] ACPI 2.0: Stop defer-executing module level code Lv Zheng 2016-09-23 3:26 ` Lv Zheng 2016-09-23 3:26 ` [PATCH v5 1/5] ACPICA: Tables: Fix "UNLOAD" code path lock issues Lv Zheng 2016-09-23 3:26 ` Lv Zheng 2016-09-23 3:26 ` Lv Zheng [this message] 2016-09-23 3:26 ` [PATCH v5 2/5] ACPICA: Parser: Fix a regression in LoadTable support Lv Zheng 2016-09-23 3:26 ` [PATCH v5 3/5] ACPI 2.0 / AML: Enable correct ACPI subsystem initialization order for new table loading mode Lv Zheng 2016-09-23 3:26 ` Lv Zheng 2016-09-23 3:26 ` [PATCH v5 4/5] ACPI 2.0 / AML: Improve module level execution by moving the If/Else/While execution to per-table basis Lv Zheng 2016-09-23 3:26 ` Lv Zheng 2016-11-24 21:16 ` Rafael J. Wysocki 2016-09-23 3:27 ` [PATCH v5 5/5] ACPI 2.0 / AML: Fix module level execution by correctly parsing table as TermList Lv Zheng 2016-09-23 3:27 ` Lv Zheng 2016-09-24 0:32 ` [PATCH v5 0/5] ACPI 2.0: Stop defer-executing module level code Rafael J. Wysocki 2016-09-26 7:43 ` Zheng, Lv 2016-09-26 12:57 ` Rafael J. Wysocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f42c3327e0be2593c86e4a7e640bd9ebea1800a1.1474600034.git.lv.zheng@intel.com \ --to=lv.zheng@intel.com \ --cc=len.brown@intel.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rafael.j.wysocki@intel.com \ --cc=rjw@rjwysocki.net \ --cc=robert.moore@intel.com \ --cc=zetalog@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.