* [PATCH] docs: Correct the default thread-pool-size
@ 2022-04-13 4:20 Liu Yiding
2022-04-14 5:05 ` liuyd.fnst
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Liu Yiding @ 2022-04-13 4:20 UTC (permalink / raw)
To: qemu-devel; +Cc: Liu Yiding
Refer to 26ec190964 virtiofsd: Do not use a thread pool by default
Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
---
docs/tools/virtiofsd.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
index 0c0560203c..33fed08c6f 100644
--- a/docs/tools/virtiofsd.rst
+++ b/docs/tools/virtiofsd.rst
@@ -127,7 +127,7 @@ Options
.. option:: --thread-pool-size=NUM
Restrict the number of worker threads per request queue to NUM. The default
- is 64.
+ is 0.
.. option:: --cache=none|auto|always
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] docs: Correct the default thread-pool-size
2022-04-13 4:20 [PATCH] docs: Correct the default thread-pool-size Liu Yiding
@ 2022-04-14 5:05 ` liuyd.fnst
2022-04-14 10:03 ` liuyd.fnst
2022-04-14 12:19 ` Vivek Goyal
2022-05-09 15:23 ` Stefan Hajnoczi
2 siblings, 1 reply; 9+ messages in thread
From: liuyd.fnst @ 2022-04-14 5:05 UTC (permalink / raw)
To: qemu-devel; +Cc: vgoyal
[+cc vgoyal@redhat.com]
On 4/13/22 12:20 PM, Liu Yiding wrote:
> Refer to 26ec190964 virtiofsd: Do not use a thread pool by default
>
> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
> ---
> docs/tools/virtiofsd.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
> index 0c0560203c..33fed08c6f 100644
> --- a/docs/tools/virtiofsd.rst
> +++ b/docs/tools/virtiofsd.rst
> @@ -127,7 +127,7 @@ Options
> .. option:: --thread-pool-size=NUM
>
> Restrict the number of worker threads per request queue to NUM. The default
> - is 64.
> + is 0.
>
> .. option:: --cache=none|auto|always
>
--
Best Regards.
Yiding Liu
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] docs: Correct the default thread-pool-size
2022-04-14 5:05 ` liuyd.fnst
@ 2022-04-14 10:03 ` liuyd.fnst
0 siblings, 0 replies; 9+ messages in thread
From: liuyd.fnst @ 2022-04-14 10:03 UTC (permalink / raw)
To: qemu-devel; +Cc: stefanha, dgilbert, vgoyal
[+cc dgilbert@redhat.com stefanha@redhat.com]
On 4/14/22 1:05 PM, liuyd.fnst@fujitsu.com wrote:
> [+cc vgoyal@redhat.com]
>
> On 4/13/22 12:20 PM, Liu Yiding wrote:
>> Refer to 26ec190964 virtiofsd: Do not use a thread pool by default
>>
>> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
>> ---
>> docs/tools/virtiofsd.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
>> index 0c0560203c..33fed08c6f 100644
>> --- a/docs/tools/virtiofsd.rst
>> +++ b/docs/tools/virtiofsd.rst
>> @@ -127,7 +127,7 @@ Options
>> .. option:: --thread-pool-size=NUM
>>
>> Restrict the number of worker threads per request queue to NUM. The default
>> - is 64.
>> + is 0.
>>
>> .. option:: --cache=none|auto|always
>>
--
Best Regards.
Yiding Liu
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] docs: Correct the default thread-pool-size
2022-04-13 4:20 [PATCH] docs: Correct the default thread-pool-size Liu Yiding
2022-04-14 5:05 ` liuyd.fnst
@ 2022-04-14 12:19 ` Vivek Goyal
2022-04-21 10:24 ` [Virtio-fs] " liuyd.fnst
2022-04-27 1:12 ` liuyd.fnst
2022-05-09 15:23 ` Stefan Hajnoczi
2 siblings, 2 replies; 9+ messages in thread
From: Vivek Goyal @ 2022-04-14 12:19 UTC (permalink / raw)
To: Liu Yiding; +Cc: qemu-devel
On Wed, Apr 13, 2022 at 12:20:54PM +0800, Liu Yiding wrote:
> Refer to 26ec190964 virtiofsd: Do not use a thread pool by default
>
> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
Looks good. Our default used to be --thread-pool-size=64. But we changed
it to using no thread pool because on lower end of workloads it performed
better. When multiple threads are doing parallel I/O then, thread pool
helps. So people who want to do lots of parallel I/O should manually
enable thread pool.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
> ---
> docs/tools/virtiofsd.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
> index 0c0560203c..33fed08c6f 100644
> --- a/docs/tools/virtiofsd.rst
> +++ b/docs/tools/virtiofsd.rst
> @@ -127,7 +127,7 @@ Options
> .. option:: --thread-pool-size=NUM
>
> Restrict the number of worker threads per request queue to NUM. The default
> - is 64.
> + is 0.
>
> .. option:: --cache=none|auto|always
>
> --
> 2.31.1
>
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] docs: Correct the default thread-pool-size
2022-04-14 12:19 ` Vivek Goyal
@ 2022-04-21 10:24 ` liuyd.fnst
2022-04-27 1:12 ` liuyd.fnst
1 sibling, 0 replies; 9+ messages in thread
From: liuyd.fnst @ 2022-04-21 10:24 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: virtio-fs, qemu-devel, Vivek Goyal, Dr. David Alan Gilbert
Hi, Stefan
Please help review it. I'm sorry that I forgot to add you to the
recipient 😅
On 4/14/22 8:19 PM, Vivek Goyal wrote:
> On Wed, Apr 13, 2022 at 12:20:54PM +0800, Liu Yiding wrote:
>> Refer to 26ec190964 virtiofsd: Do not use a thread pool by default
>>
>> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
> Looks good. Our default used to be --thread-pool-size=64. But we changed
> it to using no thread pool because on lower end of workloads it performed
> better. When multiple threads are doing parallel I/O then, thread pool
> helps. So people who want to do lots of parallel I/O should manually
> enable thread pool.
>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
>
> Vivek
>> ---
>> docs/tools/virtiofsd.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
>> index 0c0560203c..33fed08c6f 100644
>> --- a/docs/tools/virtiofsd.rst
>> +++ b/docs/tools/virtiofsd.rst
>> @@ -127,7 +127,7 @@ Options
>> .. option:: --thread-pool-size=NUM
>>
>> Restrict the number of worker threads per request queue to NUM. The default
>> - is 64.
>> + is 0.
>>
>> .. option:: --cache=none|auto|always
>>
>> --
>> 2.31.1
>>
>>
>>
>>
--
Best Regards.
Yiding Liu
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Virtio-fs] [PATCH] docs: Correct the default thread-pool-size
@ 2022-04-21 10:24 ` liuyd.fnst
0 siblings, 0 replies; 9+ messages in thread
From: liuyd.fnst @ 2022-04-21 10:24 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: qemu-devel, Vivek Goyal, Dr. David Alan Gilbert, virtio-fs
Hi, Stefan
Please help review it. I'm sorry that I forgot to add you to the
recipient 😅
On 4/14/22 8:19 PM, Vivek Goyal wrote:
> On Wed, Apr 13, 2022 at 12:20:54PM +0800, Liu Yiding wrote:
>> Refer to 26ec190964 virtiofsd: Do not use a thread pool by default
>>
>> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
> Looks good. Our default used to be --thread-pool-size=64. But we changed
> it to using no thread pool because on lower end of workloads it performed
> better. When multiple threads are doing parallel I/O then, thread pool
> helps. So people who want to do lots of parallel I/O should manually
> enable thread pool.
>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
>
> Vivek
>> ---
>> docs/tools/virtiofsd.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
>> index 0c0560203c..33fed08c6f 100644
>> --- a/docs/tools/virtiofsd.rst
>> +++ b/docs/tools/virtiofsd.rst
>> @@ -127,7 +127,7 @@ Options
>> .. option:: --thread-pool-size=NUM
>>
>> Restrict the number of worker threads per request queue to NUM. The default
>> - is 64.
>> + is 0.
>>
>> .. option:: --cache=none|auto|always
>>
>> --
>> 2.31.1
>>
>>
>>
>>
--
Best Regards.
Yiding Liu
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] docs: Correct the default thread-pool-size
2022-04-14 12:19 ` Vivek Goyal
2022-04-21 10:24 ` [Virtio-fs] " liuyd.fnst
@ 2022-04-27 1:12 ` liuyd.fnst
2022-05-06 2:09 ` liuyd.fnst
1 sibling, 1 reply; 9+ messages in thread
From: liuyd.fnst @ 2022-04-27 1:12 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
[+cc qemu-trivial]
On 4/14/22 8:19 PM, Vivek Goyal wrote:
> On Wed, Apr 13, 2022 at 12:20:54PM +0800, Liu Yiding wrote:
>> Refer to 26ec190964 virtiofsd: Do not use a thread pool by default
>>
>> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
> Looks good. Our default used to be --thread-pool-size=64. But we changed
> it to using no thread pool because on lower end of workloads it performed
> better. When multiple threads are doing parallel I/O then, thread pool
> helps. So people who want to do lots of parallel I/O should manually
> enable thread pool.
>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
>
> Vivek
>> ---
>> docs/tools/virtiofsd.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
>> index 0c0560203c..33fed08c6f 100644
>> --- a/docs/tools/virtiofsd.rst
>> +++ b/docs/tools/virtiofsd.rst
>> @@ -127,7 +127,7 @@ Options
>> .. option:: --thread-pool-size=NUM
>>
>> Restrict the number of worker threads per request queue to NUM. The default
>> - is 64.
>> + is 0.
>>
>> .. option:: --cache=none|auto|always
>>
>> --
>> 2.31.1
>>
>>
>>
>>
--
Best Regards.
Yiding Liu
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] docs: Correct the default thread-pool-size
2022-04-27 1:12 ` liuyd.fnst
@ 2022-05-06 2:09 ` liuyd.fnst
0 siblings, 0 replies; 9+ messages in thread
From: liuyd.fnst @ 2022-05-06 2:09 UTC (permalink / raw)
To: qemu-devel, Stefan Hajnoczi, Dr. David Alan Gilbert; +Cc: qemu-trivial
Gently ping
On 4/27/22 9:12 AM, liuyd.fnst@fujitsu.com wrote:
> [+cc qemu-trivial]
>
> On 4/14/22 8:19 PM, Vivek Goyal wrote:
>> On Wed, Apr 13, 2022 at 12:20:54PM +0800, Liu Yiding wrote:
>>> Refer to 26ec190964 virtiofsd: Do not use a thread pool by default
>>>
>>> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
>> Looks good. Our default used to be --thread-pool-size=64. But we changed
>> it to using no thread pool because on lower end of workloads it performed
>> better. When multiple threads are doing parallel I/O then, thread pool
>> helps. So people who want to do lots of parallel I/O should manually
>> enable thread pool.
>>
>> Acked-by: Vivek Goyal <vgoyal@redhat.com>
>>
>> Vivek
>>> ---
>>> docs/tools/virtiofsd.rst | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
>>> index 0c0560203c..33fed08c6f 100644
>>> --- a/docs/tools/virtiofsd.rst
>>> +++ b/docs/tools/virtiofsd.rst
>>> @@ -127,7 +127,7 @@ Options
>>> .. option:: --thread-pool-size=NUM
>>>
>>> Restrict the number of worker threads per request queue to NUM. The default
>>> - is 64.
>>> + is 0.
>>>
>>> .. option:: --cache=none|auto|always
>>>
>>> --
>>> 2.31.1
>>>
>>>
>>>
>>>
--
Best Regards.
Yiding Liu
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] docs: Correct the default thread-pool-size
2022-04-13 4:20 [PATCH] docs: Correct the default thread-pool-size Liu Yiding
2022-04-14 5:05 ` liuyd.fnst
2022-04-14 12:19 ` Vivek Goyal
@ 2022-05-09 15:23 ` Stefan Hajnoczi
2 siblings, 0 replies; 9+ messages in thread
From: Stefan Hajnoczi @ 2022-05-09 15:23 UTC (permalink / raw)
To: Liu Yiding; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
On Wed, Apr 13, 2022 at 12:20:54PM +0800, Liu Yiding wrote:
> Refer to 26ec190964 virtiofsd: Do not use a thread pool by default
>
> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
> ---
> docs/tools/virtiofsd.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Hi,
Sorry it took so long to apply this! Thanks, applied to my block-next
tree:
https://gitlab.com/stefanha/qemu/commits/block-next
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-05-09 15:26 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-13 4:20 [PATCH] docs: Correct the default thread-pool-size Liu Yiding
2022-04-14 5:05 ` liuyd.fnst
2022-04-14 10:03 ` liuyd.fnst
2022-04-14 12:19 ` Vivek Goyal
2022-04-21 10:24 ` liuyd.fnst
2022-04-21 10:24 ` [Virtio-fs] " liuyd.fnst
2022-04-27 1:12 ` liuyd.fnst
2022-05-06 2:09 ` liuyd.fnst
2022-05-09 15:23 ` Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.