* [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue
@ 2020-11-05 9:47 KuoHsiang Chou
2020-11-05 12:08 ` Thomas Zimmermann
2020-11-09 10:19 ` Thomas Zimmermann
0 siblings, 2 replies; 7+ messages in thread
From: KuoHsiang Chou @ 2020-11-05 9:47 UTC (permalink / raw)
To: dri-devel; +Cc: eich, tommy_huang, tzimmermann, jenmin_yuan, airlied, arc_sung
[Bug] Change the vertical synchroous polary of 1920x1080 @60Hz
from Negtive to Positive
Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>
---
drivers/gpu/drm/ast/ast_tables.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_tables.h b/drivers/gpu/drm/ast/ast_tables.h
index 8414e543f260..51efc5b4a55c 100644
--- a/drivers/gpu/drm/ast/ast_tables.h
+++ b/drivers/gpu/drm/ast/ast_tables.h
@@ -295,10 +295,10 @@ static const struct ast_vbios_enhtable res_1600x900[] = {
static const struct ast_vbios_enhtable res_1920x1080[] = {
{2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */
- (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
+ (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
AST2500PreCatchCRT), 60, 1, 0x38 },
{2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */
- (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
+ (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
AST2500PreCatchCRT), 0xFF, 1, 0x38 },
};
--
2.18.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue 2020-11-05 9:47 [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue KuoHsiang Chou @ 2020-11-05 12:08 ` Thomas Zimmermann 2020-11-05 12:21 ` Thomas Zimmermann 2020-11-06 0:31 ` Kuo-Hsiang Chou 2020-11-09 10:19 ` Thomas Zimmermann 1 sibling, 2 replies; 7+ messages in thread From: Thomas Zimmermann @ 2020-11-05 12:08 UTC (permalink / raw) To: KuoHsiang Chou, dri-devel Cc: jenmin_yuan, eich, tommy_huang, arc_sung, airlied [-- Attachment #1.1.1.1: Type: text/plain, Size: 2396 bytes --] Hi, please follow the advise we're giving you. Had you run scripts/checkpatch.pl on the patch file it would have told you <<< ERROR: patch seems to be corrupt (line wrapped?) #102: FILE: drivers/gpu/drm/ast/ast_tables.h:294: ERROR: DOS line endings #106: FILE: drivers/gpu/drm/ast/ast_tables.h:297: +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |^M$ ERROR: DOS line endings #110: FILE: drivers/gpu/drm/ast/ast_tables.h:300: +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |^M$ total: 3 errors, 0 warnings, 19 lines checked >>> As said before, the mail eich@suse.de is still not relevant any longer. But you did not add Daniel into CC. Did you run scripts/get_maintainers.pl? Best regards Thomas Am 05.11.20 um 10:47 schrieb KuoHsiang Chou: > [Bug] Change the vertical synchroous polary of 1920x1080 @60Hz > from Negtive to Positive > > Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com> > --- > drivers/gpu/drm/ast/ast_tables.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/ast/ast_tables.h b/drivers/gpu/drm/ast/ast_tables.h > index 8414e543f260..51efc5b4a55c 100644 > --- a/drivers/gpu/drm/ast/ast_tables.h > +++ b/drivers/gpu/drm/ast/ast_tables.h > @@ -295,10 +295,10 @@ static const struct ast_vbios_enhtable res_1600x900[] = { > > static const struct ast_vbios_enhtable res_1920x1080[] = { > {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */ > - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | > + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | > AST2500PreCatchCRT), 60, 1, 0x38 }, > {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */ > - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | > + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | > AST2500PreCatchCRT), 0xFF, 1, 0x38 }, > }; > > -- > 2.18.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [-- Attachment #1.1.1.2: OpenPGP_0x680DC11D530B7A23.asc --] [-- Type: application/pgp-keys, Size: 4259 bytes --] [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 495 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue 2020-11-05 12:08 ` Thomas Zimmermann @ 2020-11-05 12:21 ` Thomas Zimmermann 2020-11-06 1:18 ` Kuo-Hsiang Chou 2020-11-06 0:31 ` Kuo-Hsiang Chou 1 sibling, 1 reply; 7+ messages in thread From: Thomas Zimmermann @ 2020-11-05 12:21 UTC (permalink / raw) To: KuoHsiang Chou, dri-devel Cc: jenmin_yuan, eich, tommy_huang, arc_sung, airlied [-- Attachment #1.1.1.1: Type: text/plain, Size: 2834 bytes --] Hi Am 05.11.20 um 13:08 schrieb Thomas Zimmermann: > Hi, > > please follow the advise we're giving you. Had you run > scripts/checkpatch.pl on the patch file it would have told you > > <<< > ERROR: patch seems to be corrupt (line wrapped?) > #102: FILE: drivers/gpu/drm/ast/ast_tables.h:294: > > > ERROR: DOS line endings > #106: FILE: drivers/gpu/drm/ast/ast_tables.h:297: > +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |^M$ > > ERROR: DOS line endings > #110: FILE: drivers/gpu/drm/ast/ast_tables.h:300: > +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |^M$ > > total: 3 errors, 0 warnings, 19 lines checked >>>> > This might not be your fault but the result of my mail client. > As said before, the mail eich@suse.de is still not relevant any longer. > But you did not add Daniel into CC. Did you run scripts/get_maintainers.pl? This still applies. Best regards Thomas > > Best regards > Thomas > > Am 05.11.20 um 10:47 schrieb KuoHsiang Chou: >> [Bug] Change the vertical synchroous polary of 1920x1080 @60Hz >> from Negtive to Positive >> >> Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com> >> --- >> drivers/gpu/drm/ast/ast_tables.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/ast/ast_tables.h b/drivers/gpu/drm/ast/ast_tables.h >> index 8414e543f260..51efc5b4a55c 100644 >> --- a/drivers/gpu/drm/ast/ast_tables.h >> +++ b/drivers/gpu/drm/ast/ast_tables.h >> @@ -295,10 +295,10 @@ static const struct ast_vbios_enhtable res_1600x900[] = { >> >> static const struct ast_vbios_enhtable res_1920x1080[] = { >> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */ >> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | >> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | >> AST2500PreCatchCRT), 60, 1, 0x38 }, >> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */ >> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | >> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | >> AST2500PreCatchCRT), 0xFF, 1, 0x38 }, >> }; >> >> -- >> 2.18.4 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel >> > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [-- Attachment #1.1.1.2: OpenPGP_0x680DC11D530B7A23.asc --] [-- Type: application/pgp-keys, Size: 4259 bytes --] [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 495 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue 2020-11-05 12:21 ` Thomas Zimmermann @ 2020-11-06 1:18 ` Kuo-Hsiang Chou 0 siblings, 0 replies; 7+ messages in thread From: Kuo-Hsiang Chou @ 2020-11-06 1:18 UTC (permalink / raw) To: Thomas Zimmermann, dri-devel; +Cc: Jenmin Yuan, airlied, Tommy Huang, Arc Sung To Sir, Is the mail-address of "daniel.vetter@intel.com" correct for Daniel? Because, got the message of " The current directory does not appear to be a linux kernel source tree. " after running get_maintainers.pl So, find Daniel out by gitk /drivers/gpu/drm/ast Have a good day, Kuo-Hsiang Chou -----Original Message----- From: Thomas Zimmermann [mailto:tzimmermann@suse.de] Sent: Thursday, November 05, 2020 8:22 PM To: Kuo-Hsiang Chou <kuohsiang_chou@aspeedtech.com>; dri-devel@lists.freedesktop.org Cc: Jenmin Yuan <jenmin_yuan@aspeedtech.com>; eich@suse.com; Tommy Huang <tommy_huang@aspeedtech.com>; Arc Sung <arc_sung@aspeedtech.com>; airlied@redhat.com Subject: Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue Hi Am 05.11.20 um 13:08 schrieb Thomas Zimmermann: > Hi, > > please follow the advise we're giving you. Had you run > scripts/checkpatch.pl on the patch file it would have told you > > <<< > ERROR: patch seems to be corrupt (line wrapped?) > #102: FILE: drivers/gpu/drm/ast/ast_tables.h:294: > > > ERROR: DOS line endings > #106: FILE: drivers/gpu/drm/ast/ast_tables.h:297: > +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | > +NewModeInfo |^M$ > > ERROR: DOS line endings > #110: FILE: drivers/gpu/drm/ast/ast_tables.h:300: > +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | > +NewModeInfo |^M$ > > total: 3 errors, 0 warnings, 19 lines checked >>>> > This might not be your fault but the result of my mail client. > As said before, the mail eich@suse.de is still not relevant any longer. > But you did not add Daniel into CC. Did you run scripts/get_maintainers.pl? This still applies. Best regards Thomas > > Best regards > Thomas > > Am 05.11.20 um 10:47 schrieb KuoHsiang Chou: >> [Bug] Change the vertical synchroous polary of 1920x1080 @60Hz >> from Negtive to Positive >> >> Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com> >> --- >> drivers/gpu/drm/ast/ast_tables.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/ast/ast_tables.h >> b/drivers/gpu/drm/ast/ast_tables.h >> index 8414e543f260..51efc5b4a55c 100644 >> --- a/drivers/gpu/drm/ast/ast_tables.h >> +++ b/drivers/gpu/drm/ast/ast_tables.h >> @@ -295,10 +295,10 @@ static const struct ast_vbios_enhtable >> res_1600x900[] = { >> >> static const struct ast_vbios_enhtable res_1920x1080[] = { >> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */ >> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | >> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | >> +NewModeInfo | >> AST2500PreCatchCRT), 60, 1, 0x38 }, >> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */ >> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | >> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | >> +NewModeInfo | >> AST2500PreCatchCRT), 0xFF, 1, 0x38 }, }; >> >> -- >> 2.18.4 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel >> > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue 2020-11-05 12:08 ` Thomas Zimmermann 2020-11-05 12:21 ` Thomas Zimmermann @ 2020-11-06 0:31 ` Kuo-Hsiang Chou 2020-11-06 6:54 ` Thomas Zimmermann 1 sibling, 1 reply; 7+ messages in thread From: Kuo-Hsiang Chou @ 2020-11-06 0:31 UTC (permalink / raw) To: Thomas Zimmermann, dri-devel Cc: Jenmin Yuan, eich, Tommy Huang, Arc Sung, airlied To Sir Yes, I ran scripts/checkpatch.pl and cleared 3 errors about tailing spaces. OK, would you please give me the mail-address of Daniel? And <eich@suse.de> will be removed from CC. Because I ran get_maintainers.pl and got the result of " The current directory does not appear to be a linux kernel source tree. " So, I got the information from MAINTAINERS by keyword of "/drm/ast", likes as: DRM DRIVER FOR AST SERVER GRAPHICS CHIPS M: Dave Airlie <airlied@redhat.com> R: Thomas Zimmermann <tzimmermann@suse.de> L: dri-devel@lists.freedesktop.org S: Supported T: git git://anongit.freedesktop.org/drm/drm-misc F: drivers/gpu/drm/ast/ Thanks and Have a good day, Kuo-Hsiang Chou -----Original Message----- From: Thomas Zimmermann [mailto:tzimmermann@suse.de] Sent: Thursday, November 05, 2020 8:09 PM To: Kuo-Hsiang Chou <kuohsiang_chou@aspeedtech.com>; dri-devel@lists.freedesktop.org Cc: eich@suse.com; Tommy Huang <tommy_huang@aspeedtech.com>; Jenmin Yuan <jenmin_yuan@aspeedtech.com>; airlied@redhat.com; Arc Sung <arc_sung@aspeedtech.com> Subject: Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue Hi, please follow the advise we're giving you. Had you run scripts/checkpatch.pl on the patch file it would have told you <<< ERROR: patch seems to be corrupt (line wrapped?) #102: FILE: drivers/gpu/drm/ast/ast_tables.h:294: ERROR: DOS line endings #106: FILE: drivers/gpu/drm/ast/ast_tables.h:297: +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo +|^M$ ERROR: DOS line endings #110: FILE: drivers/gpu/drm/ast/ast_tables.h:300: +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo +|^M$ total: 3 errors, 0 warnings, 19 lines checked >>> As said before, the mail eich@suse.de is still not relevant any longer. But you did not add Daniel into CC. Did you run scripts/get_maintainers.pl? Best regards Thomas Am 05.11.20 um 10:47 schrieb KuoHsiang Chou: > [Bug] Change the vertical synchroous polary of 1920x1080 @60Hz > from Negtive to Positive > > Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com> > --- > drivers/gpu/drm/ast/ast_tables.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/ast/ast_tables.h > b/drivers/gpu/drm/ast/ast_tables.h > index 8414e543f260..51efc5b4a55c 100644 > --- a/drivers/gpu/drm/ast/ast_tables.h > +++ b/drivers/gpu/drm/ast/ast_tables.h > @@ -295,10 +295,10 @@ static const struct ast_vbios_enhtable > res_1600x900[] = { > > static const struct ast_vbios_enhtable res_1920x1080[] = { > {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */ > - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | > + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo > +| > AST2500PreCatchCRT), 60, 1, 0x38 }, > {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */ > - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | > + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo > +| > AST2500PreCatchCRT), 0xFF, 1, 0x38 }, }; > > -- > 2.18.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue 2020-11-06 0:31 ` Kuo-Hsiang Chou @ 2020-11-06 6:54 ` Thomas Zimmermann 0 siblings, 0 replies; 7+ messages in thread From: Thomas Zimmermann @ 2020-11-06 6:54 UTC (permalink / raw) To: Kuo-Hsiang Chou, dri-devel Cc: Jenmin Yuan, eich, Tommy Huang, Arc Sung, airlied [-- Attachment #1.1.1.1: Type: text/plain, Size: 4453 bytes --] Hi Am 06.11.20 um 01:31 schrieb Kuo-Hsiang Chou: > To Sir > > Yes, I ran scripts/checkpatch.pl and cleared 3 errors about tailing spaces. > > OK, would you please give me the mail-address of Daniel? It's <daniel.vetter@ffwll.ch> > And <eich@suse.de> will be removed from CC. Thanks! > Because I ran get_maintainers.pl and got the result of " The current directory does not appear to be a linux kernel source tree. " Strange, that sounds like a problem in your setup. Go to the actual directory where you checkout out the Linux source code; where the MAINTAINERS file is located. From there use scripts/get_maintainers.pl That should work. Best regards Thomas > So, I got the information from MAINTAINERS by keyword of "/drm/ast", likes as: > DRM DRIVER FOR AST SERVER GRAPHICS CHIPS > M: Dave Airlie <airlied@redhat.com> > R: Thomas Zimmermann <tzimmermann@suse.de> > L: dri-devel@lists.freedesktop.org > S: Supported > T: git git://anongit.freedesktop.org/drm/drm-misc > F: drivers/gpu/drm/ast/ > > Thanks and Have a good day, > Kuo-Hsiang Chou > > -----Original Message----- > From: Thomas Zimmermann [mailto:tzimmermann@suse.de] > Sent: Thursday, November 05, 2020 8:09 PM > To: Kuo-Hsiang Chou <kuohsiang_chou@aspeedtech.com>; dri-devel@lists.freedesktop.org > Cc: eich@suse.com; Tommy Huang <tommy_huang@aspeedtech.com>; Jenmin Yuan <jenmin_yuan@aspeedtech.com>; airlied@redhat.com; Arc Sung <arc_sung@aspeedtech.com> > Subject: Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue > > Hi, > > please follow the advise we're giving you. Had you run scripts/checkpatch.pl on the patch file it would have told you > > <<< > ERROR: patch seems to be corrupt (line wrapped?) > #102: FILE: drivers/gpu/drm/ast/ast_tables.h:294: > > > ERROR: DOS line endings > #106: FILE: drivers/gpu/drm/ast/ast_tables.h:297: > +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo > +|^M$ > > ERROR: DOS line endings > #110: FILE: drivers/gpu/drm/ast/ast_tables.h:300: > +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo > +|^M$ > > total: 3 errors, 0 warnings, 19 lines checked >>>> > > As said before, the mail eich@suse.de is still not relevant any longer. > But you did not add Daniel into CC. Did you run scripts/get_maintainers.pl? > > Best regards > Thomas > > Am 05.11.20 um 10:47 schrieb KuoHsiang Chou: >> [Bug] Change the vertical synchroous polary of 1920x1080 @60Hz >> from Negtive to Positive >> >> Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com> >> --- >> drivers/gpu/drm/ast/ast_tables.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/ast/ast_tables.h >> b/drivers/gpu/drm/ast/ast_tables.h >> index 8414e543f260..51efc5b4a55c 100644 >> --- a/drivers/gpu/drm/ast/ast_tables.h >> +++ b/drivers/gpu/drm/ast/ast_tables.h >> @@ -295,10 +295,10 @@ static const struct ast_vbios_enhtable >> res_1600x900[] = { >> >> static const struct ast_vbios_enhtable res_1920x1080[] = { >> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */ >> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | >> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo >> +| >> AST2500PreCatchCRT), 60, 1, 0x38 }, >> {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */ >> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | >> + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo >> +| >> AST2500PreCatchCRT), 0xFF, 1, 0x38 }, }; >> >> -- >> 2.18.4 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel >> > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > (HRB 36809, AG Nürnberg) > Geschäftsführer: Felix Imendörffer > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [-- Attachment #1.1.1.2: OpenPGP_0x680DC11D530B7A23.asc --] [-- Type: application/pgp-keys, Size: 4259 bytes --] [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 495 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue 2020-11-05 9:47 [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue KuoHsiang Chou 2020-11-05 12:08 ` Thomas Zimmermann @ 2020-11-09 10:19 ` Thomas Zimmermann 1 sibling, 0 replies; 7+ messages in thread From: Thomas Zimmermann @ 2020-11-09 10:19 UTC (permalink / raw) To: KuoHsiang Chou, dri-devel Cc: jenmin_yuan, airlied, tommy_huang, arc_sung, eich Hi Am 05.11.20 um 10:47 schrieb KuoHsiang Chou: > [Bug] Change the vertical synchroous polary of 1920x1080 @60Hz > from Negtive to Positive > > Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com> I've merged this patch. Thanks! Best regards Thomas > --- > drivers/gpu/drm/ast/ast_tables.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/ast/ast_tables.h b/drivers/gpu/drm/ast/ast_tables.h > index 8414e543f260..51efc5b4a55c 100644 > --- a/drivers/gpu/drm/ast/ast_tables.h > +++ b/drivers/gpu/drm/ast/ast_tables.h > @@ -295,10 +295,10 @@ static const struct ast_vbios_enhtable res_1600x900[] = { > > static const struct ast_vbios_enhtable res_1920x1080[] = { > {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */ > - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | > + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | > AST2500PreCatchCRT), 60, 1, 0x38 }, > {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */ > - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | > + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | > AST2500PreCatchCRT), 0xFF, 1, 0x38 }, > }; > > -- > 2.18.4 > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-11-09 10:19 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-11-05 9:47 [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue KuoHsiang Chou 2020-11-05 12:08 ` Thomas Zimmermann 2020-11-05 12:21 ` Thomas Zimmermann 2020-11-06 1:18 ` Kuo-Hsiang Chou 2020-11-06 0:31 ` Kuo-Hsiang Chou 2020-11-06 6:54 ` Thomas Zimmermann 2020-11-09 10:19 ` Thomas Zimmermann
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.