[Buildroot] [PATCH v2 1/1] package/guile: Add BR2_ENABLE_LOCALE as dependency.

[Buildroot] [PATCH v2 1/1] package/guile: Add BR2_ENABLE_LOCALE as dependency.

[Pedro Aguilar]

If it's not present, enable libiconv.

Signed-off-by: Pedro Aguilar <paguilar@paguilar.org>

---
Changes v1 -> v2:
  - Use BR2_ENABLE_LOCALE if selected, otherwise use libiconv
    as before (pointed out by Thomas and Giulio)
---
 package/guile/Config.in | 1 +
 package/guile/guile.mk  | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/package/guile/Config.in b/package/guile/Config.in
index b1182a4cee..f70e674018 100644
--- a/package/guile/Config.in
+++ b/package/guile/Config.in
@@ -9,6 +9,7 @@ config BR2_PACKAGE_GUILE
 	select BR2_PACKAGE_LIBFFI
 	select BR2_PACKAGE_GMP
 	select BR2_PACKAGE_BDWGC
+	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 	help
 	  Guile is an interpreter and compiler for the Scheme
 	  programming language, a clean and elegant dialect of Lisp.
diff --git a/package/guile/guile.mk b/package/guile/guile.mk
index 0f245fca76..03420407f8 100644
--- a/package/guile/guile.mk
+++ b/package/guile/guile.mk
@@ -18,6 +18,10 @@ GUILE_CPE_ID_VENDOR = gnu
 GUILE_DEPENDENCIES = host-guile libunistring libffi gmp bdwgc host-pkgconf
 HOST_GUILE_DEPENDENCIES = host-libunistring host-libffi host-gmp host-bdwgc host-flex host-pkgconf host-gettext
 
+ifeq ($(BR2_ENABLE_LOCALE),)
+GUILE_DEPENDENCIES += libiconv
+endif
+
 # The HAVE_GC* CFLAGS specify that we will use internal callbacks
 # instead of the ones provided by
 # bdwgc. Eg. HAVE_GC_SET_FINALIZER_NOTIFIER specifies that we won't
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] package/guile: Add BR2_ENABLE_LOCALE as dependency.

[Giulio Benetti]

Hi Pedro,

On 08/02/22 22:37, Pedro Aguilar wrote:
> If it's not present, enable libiconv.

Here it's missing:
Fixes:
URL to autobuilder failure

And also I can't find guile failing due to LIBICONV.

At least, I only find:
http://autobuild.buildroot.net/?reason=guile-3.0.7

But it seems to be about another problem(to be solved too).

Can you please point the autobuilder failure?
Otherwise I can't test/review your patch.

Thank you!
Best regards
-- 
Giulio Benetti
Benetti Engineering sas

> Signed-off-by: Pedro Aguilar <paguilar@paguilar.org>
> 
> ---
> Changes v1 -> v2:
>    - Use BR2_ENABLE_LOCALE if selected, otherwise use libiconv
>      as before (pointed out by Thomas and Giulio)
> ---
>   package/guile/Config.in | 1 +
>   package/guile/guile.mk  | 4 ++++
>   2 files changed, 5 insertions(+)
> 
> diff --git a/package/guile/Config.in b/package/guile/Config.in
> index b1182a4cee..f70e674018 100644
> --- a/package/guile/Config.in
> +++ b/package/guile/Config.in
> @@ -9,6 +9,7 @@ config BR2_PACKAGE_GUILE
>   	select BR2_PACKAGE_LIBFFI
>   	select BR2_PACKAGE_GMP
>   	select BR2_PACKAGE_BDWGC
> +	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
>   	help
>   	  Guile is an interpreter and compiler for the Scheme
>   	  programming language, a clean and elegant dialect of Lisp.
> diff --git a/package/guile/guile.mk b/package/guile/guile.mk
> index 0f245fca76..03420407f8 100644
> --- a/package/guile/guile.mk
> +++ b/package/guile/guile.mk
> @@ -18,6 +18,10 @@ GUILE_CPE_ID_VENDOR = gnu
>   GUILE_DEPENDENCIES = host-guile libunistring libffi gmp bdwgc host-pkgconf
>   HOST_GUILE_DEPENDENCIES = host-libunistring host-libffi host-gmp host-bdwgc host-flex host-pkgconf host-gettext
>   
> +ifeq ($(BR2_ENABLE_LOCALE),)
> +GUILE_DEPENDENCIES += libiconv
> +endif
> +
>   # The HAVE_GC* CFLAGS specify that we will use internal callbacks
>   # instead of the ones provided by
>   # bdwgc. Eg. HAVE_GC_SET_FINALIZER_NOTIFIER specifies that we won't

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] package/guile: Add BR2_ENABLE_LOCALE as dependency.

[Giulio Benetti]

Hi again Pedro,

I've reproduced the build failure with your previous attached .config 
file and this patch fixes it. So below...

On 08/02/22 23:06, Giulio Benetti wrote:
> Hi Pedro,
> 
> On 08/02/22 22:37, Pedro Aguilar wrote:
>> If it's not present, enable libiconv.
> Here it's missing:
> Fixes:
> URL to autobuilder failure

...please provide the autobuilder failure URL and if it doesn't exist 
than we don't need it.

So once done this I can give you my Review.

Waiting for V2 with improved commit log then.

Thank you!
Best regards
-- 
Giulio Benetti
Benetti Engineering sas

> 
> And also I can't find guile failing due to LIBICONV.
> 
> At least, I only find:
> http://autobuild.buildroot.net/?reason=guile-3.0.7
> 
> But it seems to be about another problem(to be solved too).
> 
> Can you please point the autobuilder failure?
> Otherwise I can't test/review your patch.
> 
> Thank you!
> Best regards
> -- Giulio Benetti Benetti Engineering sas
>> Signed-off-by: Pedro Aguilar<paguilar@paguilar.org>
>>
>> ---
>> Changes v1 -> v2:
>>     - Use BR2_ENABLE_LOCALE if selected, otherwise use libiconv
>>       as before (pointed out by Thomas and Giulio)
>> ---
>>    package/guile/Config.in | 1 +
>>    package/guile/guile.mk  | 4 ++++
>>    2 files changed, 5 insertions(+)
>>
>> diff --git a/package/guile/Config.in b/package/guile/Config.in
>> index b1182a4cee..f70e674018 100644
>> --- a/package/guile/Config.in
>> +++ b/package/guile/Config.in
>> @@ -9,6 +9,7 @@ config BR2_PACKAGE_GUILE
>>    	select BR2_PACKAGE_LIBFFI
>>    	select BR2_PACKAGE_GMP
>>    	select BR2_PACKAGE_BDWGC
>> +	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
>>    	help
>>    	  Guile is an interpreter and compiler for the Scheme
>>    	  programming language, a clean and elegant dialect of Lisp.
>> diff --git a/package/guile/guile.mk b/package/guile/guile.mk
>> index 0f245fca76..03420407f8 100644
>> --- a/package/guile/guile.mk
>> +++ b/package/guile/guile.mk
>> @@ -18,6 +18,10 @@ GUILE_CPE_ID_VENDOR = gnu
>>    GUILE_DEPENDENCIES = host-guile libunistring libffi gmp bdwgc host-pkgconf
>>    HOST_GUILE_DEPENDENCIES = host-libunistring host-libffi host-gmp host-bdwgc host-flex host-pkgconf host-gettext
>>    
>> +ifeq ($(BR2_ENABLE_LOCALE),)
>> +GUILE_DEPENDENCIES += libiconv
>> +endif
>> +
>>    # The HAVE_GC* CFLAGS specify that we will use internal callbacks
>>    # instead of the ones provided by
>>    # bdwgc. Eg. HAVE_GC_SET_FINALIZER_NOTIFIER specifies that we won't
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] package/guile: Add BR2_ENABLE_LOCALE as dependency.

[Giulio Benetti]

[-- Attachment #1.1: Type: text/plain, Size: 3127 bytes --]

Ah last thing,

please register on patchwork and mark your V1 and v2 patches as superseded:

https://patchwork.ozlabs.org/project/buildroot/list/?submitter=64998

Best regards
Giulio

Inviato da iPhone

> Il giorno 8 feb 2022, alle ore 23:54, Giulio Benetti <giulio.benetti@benettiengineering.com> ha scritto:
> 
> Hi again Pedro,
> 
> I've reproduced the build failure with your previous attached .config file and this patch fixes it. So below...
> 
>> On 08/02/22 23:06, Giulio Benetti wrote:
>> Hi Pedro,
>>> On 08/02/22 22:37, Pedro Aguilar wrote:
>>> If it's not present, enable libiconv.
>> Here it's missing:
>> Fixes:
>> URL to autobuilder failure
> 
> ...please provide the autobuilder failure URL and if it doesn't exist than we don't need it.
> 
> So once done this I can give you my Review.
> 
> Waiting for V2 with improved commit log then.
> 
> Thank you!
> Best regards
> -- 
> Giulio Benetti
> Benetti Engineering sas
> 
>> And also I can't find guile failing due to LIBICONV.
>> At least, I only find:
>> http://autobuild.buildroot.net/?reason=guile-3.0.7
>> But it seems to be about another problem(to be solved too).
>> Can you please point the autobuilder failure?
>> Otherwise I can't test/review your patch.
>> Thank you!
>> Best regards
>> -- Giulio Benetti Benetti Engineering sas
>>> Signed-off-by: Pedro Aguilar<paguilar@paguilar.org>
>>> 
>>> ---
>>> Changes v1 -> v2:
>>>    - Use BR2_ENABLE_LOCALE if selected, otherwise use libiconv
>>>      as before (pointed out by Thomas and Giulio)
>>> ---
>>>   package/guile/Config.in | 1 +
>>>   package/guile/guile.mk  | 4 ++++
>>>   2 files changed, 5 insertions(+)
>>> 
>>> diff --git a/package/guile/Config.in b/package/guile/Config.in
>>> index b1182a4cee..f70e674018 100644
>>> --- a/package/guile/Config.in
>>> +++ b/package/guile/Config.in
>>> @@ -9,6 +9,7 @@ config BR2_PACKAGE_GUILE
>>>       select BR2_PACKAGE_LIBFFI
>>>       select BR2_PACKAGE_GMP
>>>       select BR2_PACKAGE_BDWGC
>>> +    select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
>>>       help
>>>         Guile is an interpreter and compiler for the Scheme
>>>         programming language, a clean and elegant dialect of Lisp.
>>> diff --git a/package/guile/guile.mk b/package/guile/guile.mk
>>> index 0f245fca76..03420407f8 100644
>>> --- a/package/guile/guile.mk
>>> +++ b/package/guile/guile.mk
>>> @@ -18,6 +18,10 @@ GUILE_CPE_ID_VENDOR = gnu
>>>   GUILE_DEPENDENCIES = host-guile libunistring libffi gmp bdwgc host-pkgconf
>>>   HOST_GUILE_DEPENDENCIES = host-libunistring host-libffi host-gmp host-bdwgc host-flex host-pkgconf host-gettext
>>>   +ifeq ($(BR2_ENABLE_LOCALE),)
>>> +GUILE_DEPENDENCIES += libiconv
>>> +endif
>>> +
>>>   # The HAVE_GC* CFLAGS specify that we will use internal callbacks
>>>   # instead of the ones provided by
>>>   # bdwgc. Eg. HAVE_GC_SET_FINALIZER_NOTIFIER specifies that we won't
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

[-- Attachment #1.2: Type: text/html, Size: 8207 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] package/guile: Add BR2_ENABLE_LOCALE as dependency.

[Pedro Aguilar]

Hi Giulio,

On 2/8/22 23:54, Giulio Benetti wrote:
> Hi again Pedro,
> 
> I've reproduced the build failure with your previous attached .config 
> file and this patch fixes it. So below...
> 
> On 08/02/22 23:06, Giulio Benetti wrote:
>> Hi Pedro,
>>
>> On 08/02/22 22:37, Pedro Aguilar wrote:
>>> If it's not present, enable libiconv.
>> Here it's missing:
>> Fixes:
>> URL to autobuilder failure
> 
> ...please provide the autobuilder failure URL and if it doesn't exist 
> than we don't need it.

AFAIK, the build failure fixed by this patch was not reported by the 
autobuilder, so I'm afraid there isn't any URL to share.

In a previous email I wrongly mentioned that it fixed an autobuilder 
failure, but all those failures are linked to another issue that seems 
to be fixed by a patch sent by Fabrice, although I haven't tested it:

https://lists.buildroot.org/pipermail/buildroot/2022-February/636041.html

May be the commit message of the current v2 patch can remain as is.

Thanks!

> So once done this I can give you my Review.
> 
> Waiting for V2 with improved commit log then.
> 
> Thank you!
> Best regards

Regards,
-- 
Pedro Aguilar
https://paguilar.org
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] package/guile: Add BR2_ENABLE_LOCALE as dependency.

[Giulio Benetti]

Hi Pedro,

On 09/02/22 22:35, Pedro Aguilar wrote:
> Hi Giulio,
> 
> On 2/8/22 23:54, Giulio Benetti wrote:
>> Hi again Pedro,
>>
>> I've reproduced the build failure with your previous attached .config
>> file and this patch fixes it. So below...
>>
>> On 08/02/22 23:06, Giulio Benetti wrote:
>>> Hi Pedro,
>>>
>>> On 08/02/22 22:37, Pedro Aguilar wrote:
>>>> If it's not present, enable libiconv.
>>> Here it's missing:
>>> Fixes:
>>> URL to autobuilder failure
>>
>> ...please provide the autobuilder failure URL and if it doesn't exist
>> than we don't need it.
> 
> AFAIK, the build failure fixed by this patch was not reported by the
> autobuilder, so I'm afraid there isn't any URL to share.
> 
> In a previous email I wrongly mentioned that it fixed an autobuilder
> failure, but all those failures are linked to another issue that seems
> to be fixed by a patch sent by Fabrice, although I haven't tested it:
> 
> https://lists.buildroot.org/pipermail/buildroot/2022-February/636041.html

Ok, so no autobuilder failure.

> May be the commit message of the current v2 patch can remain as is.

Can you improve the commit log a bit? Try to 'git log --grep=' some file 
which has that fix, or git blame it so you can find the commit log and 
imitate it. That's the best way to learn how to write commit logs.

Because "Add BR2_ENABLE_LOCALE as dependency." doesn't mean that much,
and "If it's not present, enable libiconv." doesn't sound so good.

What about:
```
package/guile: fix build failure due to missing libiconv

When building package guile with BR2_ENABLE_LOCALE=n we get the 
following error:
```
In file included from filesys.c:95:
ports-internal.h:26:10: fatal error: iconv.h: No such file or directory
    26 | #include <iconv.h>
       |          ^~~~~~~~~
compilation terminated.
```

So let's fix it by selecting BR2_PACKAGE_LIBICONV and adding libiconv 
package as dependency.

Signed-off-by: Pedro...
```

Can you please a V3 with this also pointing the V1->V2, V2->V3 changes?

Thank you!

Best regards
-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot