* [PATCH 0/2] Fix spelling/formatting in fuzzing patches @ 2020-02-27 2:48 Alexander Bulekov 2020-02-27 2:48 ` [PATCH 1/2] fuzz: fix typos in linker-script comments Alexander Bulekov 2020-02-27 2:48 ` [PATCH 2/2] qtest: fix fuzzer-related 80-char limit violations Alexander Bulekov 0 siblings, 2 replies; 6+ messages in thread From: Alexander Bulekov @ 2020-02-27 2:48 UTC (permalink / raw) To: qemu-devel; +Cc: Alexander Bulekov, stefanha These patches fix some spelling and line-length violations introduced by the device-fuzzing changes: https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg05965.html Alexander Bulekov (2): fuzz: fix typos in linker-script comments qtest: fix fuzzer-related 80-char limit violations qtest.c | 3 ++- tests/qtest/fuzz/fork_fuzz.ld | 4 ++-- tests/qtest/fuzz/qos_fuzz.c | 5 ++++- 3 files changed, 8 insertions(+), 4 deletions(-) -- 2.25.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] fuzz: fix typos in linker-script comments 2020-02-27 2:48 [PATCH 0/2] Fix spelling/formatting in fuzzing patches Alexander Bulekov @ 2020-02-27 2:48 ` Alexander Bulekov 2020-02-27 2:55 ` Eric Blake 2020-02-27 2:48 ` [PATCH 2/2] qtest: fix fuzzer-related 80-char limit violations Alexander Bulekov 1 sibling, 1 reply; 6+ messages in thread From: Alexander Bulekov @ 2020-02-27 2:48 UTC (permalink / raw) To: qemu-devel Cc: Laurent Vivier, Thomas Huth, Alexander Bulekov, Bandan Das, stefanha, Paolo Bonzini Signed-off-by: Alexander Bulekov <alxndr@bu.edu> --- tests/qtest/fuzz/fork_fuzz.ld | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/fuzz/fork_fuzz.ld b/tests/qtest/fuzz/fork_fuzz.ld index b23a59f194..b5aad06f20 100644 --- a/tests/qtest/fuzz/fork_fuzz.ld +++ b/tests/qtest/fuzz/fork_fuzz.ld @@ -1,5 +1,5 @@ /* We adjust linker script modification to place all of the stuff that needs to - * persist across fuzzing runs into a contiguous seciton of memory. Then, it is + * persist across fuzzing runs into a contiguous section of memory. Then, it is * easy to re-map the counter-related memory as shared. */ @@ -32,6 +32,6 @@ SECTIONS __FUZZ_COUNTERS_END = .; } } -/* Dont overwrite the SECTIONS in the default linker script. Instead insert the +/* Don't overwrite the SECTIONS in the default linker script. Instead insert the * above into the default script */ INSERT AFTER .data; -- 2.25.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] fuzz: fix typos in linker-script comments 2020-02-27 2:48 ` [PATCH 1/2] fuzz: fix typos in linker-script comments Alexander Bulekov @ 2020-02-27 2:55 ` Eric Blake 2020-02-27 3:09 ` Alexander Bulekov 0 siblings, 1 reply; 6+ messages in thread From: Eric Blake @ 2020-02-27 2:55 UTC (permalink / raw) To: Alexander Bulekov, qemu-devel Cc: Laurent Vivier, Paolo Bonzini, Bandan Das, Thomas Huth, stefanha On 2/26/20 8:48 PM, Alexander Bulekov wrote: > Signed-off-by: Alexander Bulekov <alxndr@bu.edu> > --- > tests/qtest/fuzz/fork_fuzz.ld | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/qtest/fuzz/fork_fuzz.ld b/tests/qtest/fuzz/fork_fuzz.ld > index b23a59f194..b5aad06f20 100644 > --- a/tests/qtest/fuzz/fork_fuzz.ld > +++ b/tests/qtest/fuzz/fork_fuzz.ld > @@ -1,5 +1,5 @@ > /* We adjust linker script modification to place all of the stuff that needs to > - * persist across fuzzing runs into a contiguous seciton of memory. Then, it is > + * persist across fuzzing runs into a contiguous section of memory. Then, it is > * easy to re-map the counter-related memory as shared. > */ > > @@ -32,6 +32,6 @@ SECTIONS > __FUZZ_COUNTERS_END = .; > } > } > -/* Dont overwrite the SECTIONS in the default linker script. Instead insert the > +/* Don't overwrite the SECTIONS in the default linker script. Instead insert the > * above into the default script */ As long as you're touching these two comments, checkpatch is going to complain that they don't follow the usual style of: /* * Text starts here... * through here. */ If you fix that as well for these two comments, Reviewed-by: Eric Blake <eblake@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] fuzz: fix typos in linker-script comments 2020-02-27 2:55 ` Eric Blake @ 2020-02-27 3:09 ` Alexander Bulekov 0 siblings, 0 replies; 6+ messages in thread From: Alexander Bulekov @ 2020-02-27 3:09 UTC (permalink / raw) To: Eric Blake Cc: Laurent Vivier, Thomas Huth, qemu-devel, Bandan Das, stefanha, Paolo Bonzini On 200226 2055, Eric Blake wrote: > On 2/26/20 8:48 PM, Alexander Bulekov wrote: > > Signed-off-by: Alexander Bulekov <alxndr@bu.edu> > > --- > > tests/qtest/fuzz/fork_fuzz.ld | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tests/qtest/fuzz/fork_fuzz.ld b/tests/qtest/fuzz/fork_fuzz.ld > > index b23a59f194..b5aad06f20 100644 > > --- a/tests/qtest/fuzz/fork_fuzz.ld > > +++ b/tests/qtest/fuzz/fork_fuzz.ld > > @@ -1,5 +1,5 @@ > > /* We adjust linker script modification to place all of the stuff that needs to > > - * persist across fuzzing runs into a contiguous seciton of memory. Then, it is > > + * persist across fuzzing runs into a contiguous section of memory. Then, it is > > * easy to re-map the counter-related memory as shared. > > */ > > @@ -32,6 +32,6 @@ SECTIONS > > __FUZZ_COUNTERS_END = .; > > } > > } > > -/* Dont overwrite the SECTIONS in the default linker script. Instead insert the > > +/* Don't overwrite the SECTIONS in the default linker script. Instead insert the > > * above into the default script */ > > As long as you're touching these two comments, checkpatch is going to > complain that they don't follow the usual style of: > > /* > * Text starts here... > * through here. > */ > > If you fix that as well for these two comments, > Reviewed-by: Eric Blake <eblake@redhat.com> Must have missed it since the file has a .ld extension. Thanks! -Alex > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3226 > Virtualization: qemu.org | libvirt.org > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] qtest: fix fuzzer-related 80-char limit violations 2020-02-27 2:48 [PATCH 0/2] Fix spelling/formatting in fuzzing patches Alexander Bulekov 2020-02-27 2:48 ` [PATCH 1/2] fuzz: fix typos in linker-script comments Alexander Bulekov @ 2020-02-27 2:48 ` Alexander Bulekov 2020-02-27 2:56 ` Eric Blake 1 sibling, 1 reply; 6+ messages in thread From: Alexander Bulekov @ 2020-02-27 2:48 UTC (permalink / raw) To: qemu-devel Cc: Laurent Vivier, Thomas Huth, Alexander Bulekov, Bandan Das, stefanha, Paolo Bonzini Signed-off-by: Alexander Bulekov <alxndr@bu.edu> --- qtest.c | 3 ++- tests/qtest/fuzz/qos_fuzz.c | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/qtest.c b/qtest.c index 1af4e1b08d..5672b75c35 100644 --- a/qtest.c +++ b/qtest.c @@ -794,7 +794,8 @@ void qtest_server_init(const char *qtest_chrdev, const char *qtest_log, Error ** } } -void qtest_server_set_send_handler(void (*send)(void*, const char*), void *opaque) +void qtest_server_set_send_handler(void (*send)(void*, const char*), + void *opaque) { qtest_server_send = send; qtest_server_send_opaque = opaque; diff --git a/tests/qtest/fuzz/qos_fuzz.c b/tests/qtest/fuzz/qos_fuzz.c index bbb17470ff..1a99277d60 100644 --- a/tests/qtest/fuzz/qos_fuzz.c +++ b/tests/qtest/fuzz/qos_fuzz.c @@ -120,7 +120,10 @@ static void walk_path(QOSGraphNode *orig_path, int len) QOSGraphNode *path; QOSGraphEdge *edge; - /* etype set to QEDGE_CONSUMED_BY so that machine can add to the command line */ + /* + * etype set to QEDGE_CONSUMED_BY so that machine can add to the command + * line + */ QOSEdgeType etype = QEDGE_CONSUMED_BY; /* twice QOS_PATH_MAX_ELEMENT_SIZE since each edge can have its arg */ -- 2.25.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] qtest: fix fuzzer-related 80-char limit violations 2020-02-27 2:48 ` [PATCH 2/2] qtest: fix fuzzer-related 80-char limit violations Alexander Bulekov @ 2020-02-27 2:56 ` Eric Blake 0 siblings, 0 replies; 6+ messages in thread From: Eric Blake @ 2020-02-27 2:56 UTC (permalink / raw) To: Alexander Bulekov, qemu-devel Cc: Laurent Vivier, Paolo Bonzini, Thomas Huth, Bandan Das, stefanha On 2/26/20 8:48 PM, Alexander Bulekov wrote: > Signed-off-by: Alexander Bulekov <alxndr@bu.edu> > --- > qtest.c | 3 ++- > tests/qtest/fuzz/qos_fuzz.c | 5 ++++- > 2 files changed, 6 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com> > > diff --git a/qtest.c b/qtest.c > index 1af4e1b08d..5672b75c35 100644 > --- a/qtest.c > +++ b/qtest.c > @@ -794,7 +794,8 @@ void qtest_server_init(const char *qtest_chrdev, const char *qtest_log, Error ** > } > } > > -void qtest_server_set_send_handler(void (*send)(void*, const char*), void *opaque) > +void qtest_server_set_send_handler(void (*send)(void*, const char*), > + void *opaque) > { > qtest_server_send = send; > qtest_server_send_opaque = opaque; > diff --git a/tests/qtest/fuzz/qos_fuzz.c b/tests/qtest/fuzz/qos_fuzz.c > index bbb17470ff..1a99277d60 100644 > --- a/tests/qtest/fuzz/qos_fuzz.c > +++ b/tests/qtest/fuzz/qos_fuzz.c > @@ -120,7 +120,10 @@ static void walk_path(QOSGraphNode *orig_path, int len) > QOSGraphNode *path; > QOSGraphEdge *edge; > > - /* etype set to QEDGE_CONSUMED_BY so that machine can add to the command line */ > + /* > + * etype set to QEDGE_CONSUMED_BY so that machine can add to the command > + * line > + */ > QOSEdgeType etype = QEDGE_CONSUMED_BY; > > /* twice QOS_PATH_MAX_ELEMENT_SIZE since each edge can have its arg */ > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-27 3:10 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-02-27 2:48 [PATCH 0/2] Fix spelling/formatting in fuzzing patches Alexander Bulekov 2020-02-27 2:48 ` [PATCH 1/2] fuzz: fix typos in linker-script comments Alexander Bulekov 2020-02-27 2:55 ` Eric Blake 2020-02-27 3:09 ` Alexander Bulekov 2020-02-27 2:48 ` [PATCH 2/2] qtest: fix fuzzer-related 80-char limit violations Alexander Bulekov 2020-02-27 2:56 ` Eric Blake
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.