* [PATCH] clk: qcom: Fix SM_GPUCC_8650 dependencies
@ 2024-03-23 3:28 Yue Haibing
2024-03-25 14:10 ` neil.armstrong
2024-03-28 21:22 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2024-03-23 3:28 UTC (permalink / raw)
To: andersson, konrad.dybcio, mturquette, sboyd, dmitry.baryshkov,
neil.armstrong
Cc: linux-arm-msm, linux-clk, linux-kernel, yuehaibing
CONFIG_SM_GCC_8650 depends on ARM64 but it is selected by
CONFIG_SM_GPUCC_8650, which can be selected on ARM, resulting in a
Kconfig warning.
WARNING: unmet direct dependencies detected for SM_GCC_8650
Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n])
Selected by [m]:
- SM_GPUCC_8650 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y]
Add the same dependencies to CONFIG_SM_GPUCC_8650 to resolve the warning.
Fixes: 8676fd4f3874 ("clk: qcom: add the SM8650 GPU Clock Controller driver")
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
drivers/clk/qcom/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index 8ab08e7b5b6c..3e85df1514bd 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -1094,6 +1094,7 @@ config SM_GPUCC_8550
config SM_GPUCC_8650
tristate "SM8650 Graphics Clock Controller"
+ depends on ARM64 || COMPILE_TEST
select SM_GCC_8650
help
Support for the graphics clock controller on SM8650 devices.
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: qcom: Fix SM_GPUCC_8650 dependencies
2024-03-23 3:28 [PATCH] clk: qcom: Fix SM_GPUCC_8650 dependencies Yue Haibing
@ 2024-03-25 14:10 ` neil.armstrong
2024-03-28 21:22 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: neil.armstrong @ 2024-03-25 14:10 UTC (permalink / raw)
To: Yue Haibing, andersson, konrad.dybcio, mturquette, sboyd,
dmitry.baryshkov
Cc: linux-arm-msm, linux-clk, linux-kernel
On 23/03/2024 04:28, Yue Haibing wrote:
> CONFIG_SM_GCC_8650 depends on ARM64 but it is selected by
> CONFIG_SM_GPUCC_8650, which can be selected on ARM, resulting in a
> Kconfig warning.
>
> WARNING: unmet direct dependencies detected for SM_GCC_8650
> Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n])
> Selected by [m]:
> - SM_GPUCC_8650 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y]
>
> Add the same dependencies to CONFIG_SM_GPUCC_8650 to resolve the warning.
>
> Fixes: 8676fd4f3874 ("clk: qcom: add the SM8650 GPU Clock Controller driver")
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> drivers/clk/qcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 8ab08e7b5b6c..3e85df1514bd 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -1094,6 +1094,7 @@ config SM_GPUCC_8550
>
> config SM_GPUCC_8650
> tristate "SM8650 Graphics Clock Controller"
> + depends on ARM64 || COMPILE_TEST
> select SM_GCC_8650
> help
> Support for the graphics clock controller on SM8650 devices.
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: qcom: Fix SM_GPUCC_8650 dependencies
2024-03-23 3:28 [PATCH] clk: qcom: Fix SM_GPUCC_8650 dependencies Yue Haibing
2024-03-25 14:10 ` neil.armstrong
@ 2024-03-28 21:22 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2024-03-28 21:22 UTC (permalink / raw)
To: Yue Haibing, andersson, dmitry.baryshkov, konrad.dybcio,
mturquette, neil.armstrong
Cc: linux-arm-msm, linux-clk, linux-kernel, yuehaibing
Quoting Yue Haibing (2024-03-22 20:28:06)
> CONFIG_SM_GCC_8650 depends on ARM64 but it is selected by
> CONFIG_SM_GPUCC_8650, which can be selected on ARM, resulting in a
> Kconfig warning.
>
> WARNING: unmet direct dependencies detected for SM_GCC_8650
> Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n])
> Selected by [m]:
> - SM_GPUCC_8650 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y]
>
> Add the same dependencies to CONFIG_SM_GPUCC_8650 to resolve the warning.
>
> Fixes: 8676fd4f3874 ("clk: qcom: add the SM8650 GPU Clock Controller driver")
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
This is superseded by https://lore.kernel.org/r/20240318-fix-some-qcom-kconfig-deps-v1-2-ea0773e3df5a@kernel.org
Bjorn did you want me to pick that series up?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-28 21:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-23 3:28 [PATCH] clk: qcom: Fix SM_GPUCC_8650 dependencies Yue Haibing
2024-03-25 14:10 ` neil.armstrong
2024-03-28 21:22 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.