[PATCH] dmaengine: ioat: Make two symbols static

[PATCH] dmaengine: ioat: Make two symbols static

[Jason Yan]

This eliminates the following sparse warning:

drivers/dma/ioat/dma.c:29:5: warning: symbol 'completion_timeout' was
not declared. Should it be static?
drivers/dma/ioat/dma.c:33:5: warning: symbol 'idle_timeout' was not
declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/dma/ioat/dma.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
index a814b200299b..8cce4e059b7a 100644
--- a/drivers/dma/ioat/dma.c
+++ b/drivers/dma/ioat/dma.c
@@ -26,11 +26,11 @@
 
 #include "../dmaengine.h"
 
-int completion_timeout = 200;
+static int completion_timeout = 200;
 module_param(completion_timeout, int, 0644);
 MODULE_PARM_DESC(completion_timeout,
 		"set ioat completion timeout [msec] (default 200 [msec])");
-int idle_timeout = 2000;
+static int idle_timeout = 2000;
 module_param(idle_timeout, int, 0644);
 MODULE_PARM_DESC(idle_timeout,
 		"set ioat idel timeout [msec] (default 2000 [msec])");
-- 
2.25.4

RE: [PATCH] dmaengine: ioat: Make two symbols static

[Ravich, Leonid]

Looks good to me 

> From: dmaengine-owner@vger.kernel.org <dmaengine-
> Sent: Saturday, 12 September 2020 10:22
> 
> This eliminates the following sparse warning:
> 
> drivers/dma/ioat/dma.c:29:5: warning: symbol 'completion_timeout' was
> not declared. Should it be static?
> drivers/dma/ioat/dma.c:33:5: warning: symbol 'idle_timeout' was not
> declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  drivers/dma/ioat/dma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
> index a814b200299b..8cce4e059b7a 100644
> --- a/drivers/dma/ioat/dma.c
> +++ b/drivers/dma/ioat/dma.c
> @@ -26,11 +26,11 @@
> 
>  #include "../dmaengine.h"
> 
> -int completion_timeout = 200;
> +static int completion_timeout = 200;
>  module_param(completion_timeout, int, 0644);
>  MODULE_PARM_DESC(completion_timeout,
>  		"set ioat completion timeout [msec] (default 200 [msec])");
> -int idle_timeout = 2000;
> +static int idle_timeout = 2000;
>  module_param(idle_timeout, int, 0644);
>  MODULE_PARM_DESC(idle_timeout,
>  		"set ioat idel timeout [msec] (default 2000 [msec])");
> --
> 2.25.4

Re: [PATCH] dmaengine: ioat: Make two symbols static

[Dave Jiang]

On 9/12/2020 12:21 AM, Jason Yan wrote:
> This eliminates the following sparse warning:
> 
> drivers/dma/ioat/dma.c:29:5: warning: symbol 'completion_timeout' was
> not declared. Should it be static?
> drivers/dma/ioat/dma.c:33:5: warning: symbol 'idle_timeout' was not
> declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Acked-by: Dave Jiang <dave.jiang@intel.com>

> ---
>   drivers/dma/ioat/dma.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
> index a814b200299b..8cce4e059b7a 100644
> --- a/drivers/dma/ioat/dma.c
> +++ b/drivers/dma/ioat/dma.c
> @@ -26,11 +26,11 @@
>   
>   #include "../dmaengine.h"
>   
> -int completion_timeout = 200;
> +static int completion_timeout = 200;
>   module_param(completion_timeout, int, 0644);
>   MODULE_PARM_DESC(completion_timeout,
>   		"set ioat completion timeout [msec] (default 200 [msec])");
> -int idle_timeout = 2000;
> +static int idle_timeout = 2000;
>   module_param(idle_timeout, int, 0644);
>   MODULE_PARM_DESC(idle_timeout,
>   		"set ioat idel timeout [msec] (default 2000 [msec])");
>