Re: [PATCH 06/11] of/flattree: merge early_init_devtree() and early_init_move_devtree()

[Grant Likely <grant.likely@secretlab.ca>]

On Mon, Dec 7, 2009 at 12:08 AM, Jeremy Kerr <jeremy.kerr@canonical.com> wrote:
> Hi Grant,
>
>> +     /* Scan memory nodes and rebuild LMBs */
>> +     lmb_init();
>> +     of_scan_flat_dt(early_init_dt_scan_root, NULL);
>> +     of_scan_flat_dt(early_init_dt_scan_memory, NULL);
>> +
>> +     /* Save command line for /proc/cmdline and then parse parameters */
>> +     strlcpy(boot_command_line, cmd_line, COMMAND_LINE_SIZE);
>> +     parse_early_param();
>> +
>> +     /* This is in an arbitrary spot, but it is temporary.  After all
>> +      * the common code is merged, the structure of the early init
>> +      * code will be reevaluated and refactored */
>> +     early_init_devtree_arch();
>> +
>> +     lmb_analyze();
>> +     lmb_dump_all();
>
> So we're assuming that the arch has lmb support, or should we make this
> conditional on CONFIG_HAVE_LMB?

I'm not making any assumptions yet.  I'm just merging the code.  A lot
of it needs to be refactored after the merge.  Feel free to send
patches to rework want you need.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html