* [PATCH] hw/register: Document register_init_block @memory_size
@ 2020-07-07 6:23 Philippe Mathieu-Daudé
2020-07-07 16:00 ` Alistair Francis
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-07-07 6:23 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Alistair Francis, Philippe Mathieu-Daudé
Document the 'memory_size' argument of register_init_block().
Fixes: a74229597e ("register: Add block initialise helper")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
include/hw/register.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/hw/register.h b/include/hw/register.h
index 5d2c565ae0..fdac5e69b5 100644
--- a/include/hw/register.h
+++ b/include/hw/register.h
@@ -181,6 +181,7 @@ uint64_t register_read_memory(void *opaque, hwaddr addr, unsigned size);
* @data: Array to use for register data, must already be allocated
* @ops: Memory region ops to access registers.
* @debug enabled: turn on/off verbose debug information
+ * @memory_size: Size of the memory region
* returns: A structure containing all of the registers and an initialized
* memory region (r_array->mem) the caller should add to a container.
*/
--
2.21.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] hw/register: Document register_init_block @memory_size
2020-07-07 6:23 [PATCH] hw/register: Document register_init_block @memory_size Philippe Mathieu-Daudé
@ 2020-07-07 16:00 ` Alistair Francis
2020-07-08 12:42 ` Laurent Vivier
2020-08-31 17:42 ` Laurent Vivier
2 siblings, 0 replies; 7+ messages in thread
From: Alistair Francis @ 2020-07-07 16:00 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: QEMU Trivial, Alistair Francis, qemu-devel@nongnu.org Developers
On Mon, Jul 6, 2020 at 11:23 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Document the 'memory_size' argument of register_init_block().
>
> Fixes: a74229597e ("register: Add block initialise helper")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> include/hw/register.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/hw/register.h b/include/hw/register.h
> index 5d2c565ae0..fdac5e69b5 100644
> --- a/include/hw/register.h
> +++ b/include/hw/register.h
> @@ -181,6 +181,7 @@ uint64_t register_read_memory(void *opaque, hwaddr addr, unsigned size);
> * @data: Array to use for register data, must already be allocated
> * @ops: Memory region ops to access registers.
> * @debug enabled: turn on/off verbose debug information
> + * @memory_size: Size of the memory region
> * returns: A structure containing all of the registers and an initialized
> * memory region (r_array->mem) the caller should add to a container.
> */
> --
> 2.21.3
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] hw/register: Document register_init_block @memory_size
2020-07-07 6:23 [PATCH] hw/register: Document register_init_block @memory_size Philippe Mathieu-Daudé
2020-07-07 16:00 ` Alistair Francis
@ 2020-07-08 12:42 ` Laurent Vivier
2020-07-09 17:19 ` Alistair Francis
2020-08-31 17:42 ` Laurent Vivier
2 siblings, 1 reply; 7+ messages in thread
From: Laurent Vivier @ 2020-07-08 12:42 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: qemu-trivial, Alistair Francis
Le 07/07/2020 à 08:23, Philippe Mathieu-Daudé a écrit :
> Document the 'memory_size' argument of register_init_block().
>
> Fixes: a74229597e ("register: Add block initialise helper")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/hw/register.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/hw/register.h b/include/hw/register.h
> index 5d2c565ae0..fdac5e69b5 100644
> --- a/include/hw/register.h
> +++ b/include/hw/register.h
> @@ -181,6 +181,7 @@ uint64_t register_read_memory(void *opaque, hwaddr addr, unsigned size);
> * @data: Array to use for register data, must already be allocated
> * @ops: Memory region ops to access registers.
> * @debug enabled: turn on/off verbose debug information
> + * @memory_size: Size of the memory region
> * returns: A structure containing all of the registers and an initialized
> * memory region (r_array->mem) the caller should add to a container.
> */
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] hw/register: Document register_init_block @memory_size
2020-07-08 12:42 ` Laurent Vivier
@ 2020-07-09 17:19 ` Alistair Francis
2020-07-09 20:17 ` Laurent Vivier
0 siblings, 1 reply; 7+ messages in thread
From: Alistair Francis @ 2020-07-09 17:19 UTC (permalink / raw)
To: Laurent Vivier
Cc: QEMU Trivial, Alistair Francis, Philippe Mathieu-Daudé,
qemu-devel@nongnu.org Developers
On Wed, Jul 8, 2020 at 5:43 AM Laurent Vivier <laurent@vivier.eu> wrote:
>
> Le 07/07/2020 à 08:23, Philippe Mathieu-Daudé a écrit :
> > Document the 'memory_size' argument of register_init_block().
> >
> > Fixes: a74229597e ("register: Add block initialise helper")
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> > include/hw/register.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/hw/register.h b/include/hw/register.h
> > index 5d2c565ae0..fdac5e69b5 100644
> > --- a/include/hw/register.h
> > +++ b/include/hw/register.h
> > @@ -181,6 +181,7 @@ uint64_t register_read_memory(void *opaque, hwaddr addr, unsigned size);
> > * @data: Array to use for register data, must already be allocated
> > * @ops: Memory region ops to access registers.
> > * @debug enabled: turn on/off verbose debug information
> > + * @memory_size: Size of the memory region
> > * returns: A structure containing all of the registers and an initialized
> > * memory region (r_array->mem) the caller should add to a container.
> > */
> >
>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Can this go via the trivial tree?
Alistair
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] hw/register: Document register_init_block @memory_size
2020-07-09 17:19 ` Alistair Francis
@ 2020-07-09 20:17 ` Laurent Vivier
2020-07-10 9:51 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 7+ messages in thread
From: Laurent Vivier @ 2020-07-09 20:17 UTC (permalink / raw)
To: Alistair Francis
Cc: QEMU Trivial, Alistair Francis, Philippe Mathieu-Daudé,
qemu-devel@nongnu.org Developers
Le 09/07/2020 à 19:19, Alistair Francis a écrit :
> On Wed, Jul 8, 2020 at 5:43 AM Laurent Vivier <laurent@vivier.eu> wrote:
>>
>> Le 07/07/2020 à 08:23, Philippe Mathieu-Daudé a écrit :
>>> Document the 'memory_size' argument of register_init_block().
>>>
>>> Fixes: a74229597e ("register: Add block initialise helper")
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> include/hw/register.h | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/include/hw/register.h b/include/hw/register.h
>>> index 5d2c565ae0..fdac5e69b5 100644
>>> --- a/include/hw/register.h
>>> +++ b/include/hw/register.h
>>> @@ -181,6 +181,7 @@ uint64_t register_read_memory(void *opaque, hwaddr addr, unsigned size);
>>> * @data: Array to use for register data, must already be allocated
>>> * @ops: Memory region ops to access registers.
>>> * @debug enabled: turn on/off verbose debug information
>>> + * @memory_size: Size of the memory region
>>> * returns: A structure containing all of the registers and an initialized
>>> * memory region (r_array->mem) the caller should add to a container.
>>> */
>>>
>>
>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>
> Can this go via the trivial tree?
>
Yes, I will try to do a PR before the hard freeze.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] hw/register: Document register_init_block @memory_size
2020-07-09 20:17 ` Laurent Vivier
@ 2020-07-10 9:51 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-07-10 9:51 UTC (permalink / raw)
To: Laurent Vivier, Alistair Francis
Cc: QEMU Trivial, Alistair Francis, qemu-devel@nongnu.org Developers
On 7/9/20 10:17 PM, Laurent Vivier wrote:
> Le 09/07/2020 à 19:19, Alistair Francis a écrit :
>> On Wed, Jul 8, 2020 at 5:43 AM Laurent Vivier <laurent@vivier.eu> wrote:
>>>
>>> Le 07/07/2020 à 08:23, Philippe Mathieu-Daudé a écrit :
>>>> Document the 'memory_size' argument of register_init_block().
>>>>
>>>> Fixes: a74229597e ("register: Add block initialise helper")
>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> ---
>>>> include/hw/register.h | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/include/hw/register.h b/include/hw/register.h
>>>> index 5d2c565ae0..fdac5e69b5 100644
>>>> --- a/include/hw/register.h
>>>> +++ b/include/hw/register.h
>>>> @@ -181,6 +181,7 @@ uint64_t register_read_memory(void *opaque, hwaddr addr, unsigned size);
>>>> * @data: Array to use for register data, must already be allocated
>>>> * @ops: Memory region ops to access registers.
>>>> * @debug enabled: turn on/off verbose debug information
>>>> + * @memory_size: Size of the memory region
>>>> * returns: A structure containing all of the registers and an initialized
>>>> * memory region (r_array->mem) the caller should add to a container.
>>>> */
>>>>
>>>
>>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>>
>> Can this go via the trivial tree?
>>
>
> Yes, I will try to do a PR before the hard freeze.
No rush, if there is nothing else in your queue
you can safely keep this for 5.2 ;)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] hw/register: Document register_init_block @memory_size
2020-07-07 6:23 [PATCH] hw/register: Document register_init_block @memory_size Philippe Mathieu-Daudé
2020-07-07 16:00 ` Alistair Francis
2020-07-08 12:42 ` Laurent Vivier
@ 2020-08-31 17:42 ` Laurent Vivier
2 siblings, 0 replies; 7+ messages in thread
From: Laurent Vivier @ 2020-08-31 17:42 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: qemu-trivial, Alistair Francis
Le 07/07/2020 à 08:23, Philippe Mathieu-Daudé a écrit :
> Document the 'memory_size' argument of register_init_block().
>
> Fixes: a74229597e ("register: Add block initialise helper")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/hw/register.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/hw/register.h b/include/hw/register.h
> index 5d2c565ae0..fdac5e69b5 100644
> --- a/include/hw/register.h
> +++ b/include/hw/register.h
> @@ -181,6 +181,7 @@ uint64_t register_read_memory(void *opaque, hwaddr addr, unsigned size);
> * @data: Array to use for register data, must already be allocated
> * @ops: Memory region ops to access registers.
> * @debug enabled: turn on/off verbose debug information
> + * @memory_size: Size of the memory region
> * returns: A structure containing all of the registers and an initialized
> * memory region (r_array->mem) the caller should add to a container.
> */
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-08-31 17:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-07 6:23 [PATCH] hw/register: Document register_init_block @memory_size Philippe Mathieu-Daudé
2020-07-07 16:00 ` Alistair Francis
2020-07-08 12:42 ` Laurent Vivier
2020-07-09 17:19 ` Alistair Francis
2020-07-09 20:17 ` Laurent Vivier
2020-07-10 9:51 ` Philippe Mathieu-Daudé
2020-08-31 17:42 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.