From: Huang Jiachai <hjc@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>, "David Airlie" <airlied@linux.ie>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel@ffwll.ch>,
huangtao@rock-chips.com, andy.yan@rock-chips.com,
linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org, kever.yang@rock-chips.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled
Date: Wed, 2 Sep 2020 19:56:01 +0800 [thread overview]
Message-ID: <fc4aab7b-c1e5-4469-8ccd-4529055e05a1@rock-chips.com> (raw)
In-Reply-To: <12d1b648-81d1-df48-4435-b7b88dd72b30@rock-chips.com>
Hi David Airlie,
Please help to confirm whether this modification is reasonable when
you are free, thanks.
在 2020/8/13 14:31, Huang Jiachai 写道:
> ping...
>
> 在 2020/7/23 3:01, Heiko Stübner 写道:
>> Am Dienstag, 7. Juli 2020, 13:25:26 CEST schrieb Sandy Huang:
>>> don't mask possible_crtcs if remote-point is disabled.
>>>
>>> Signed-off-by: Sandy Huang <hjc@rock-chips.com>
>> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>>
>> changes in v2:
>> - drop additional of_node_put, as ep will be put with the next
>> iteration of for_each_endpoint_of_node()
>>
>>
>> As this touches a pretty central function is there something
>> to keep in mind in regards to other DRM drivers?
>> [question for the broader audience ;-) ]
>>
>> Heiko
>>
>>> ---
>>> drivers/gpu/drm/drm_of.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
>>> index fdb05fbf72a0..565f05f5f11b 100644
>>> --- a/drivers/gpu/drm/drm_of.c
>>> +++ b/drivers/gpu/drm/drm_of.c
>>> @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct
>>> drm_device *dev,
>>> uint32_t possible_crtcs = 0;
>>> for_each_endpoint_of_node(port, ep) {
>>> + if (!of_device_is_available(ep))
>>> + continue;
>>> +
>>> remote_port = of_graph_get_remote_port(ep);
>>> if (!remote_port) {
>>> of_node_put(ep);
>>>
>>
>>
>>
>>
>>
--
Best Regard
黄家钗
Sandy Huang
Addr: 福州市鼓楼区铜盘路软件大道89号福州软件园A区21号楼(350003)
No. 21 Building, A District, No.89,software Boulevard Fuzhou,Fujian,PRC
Tel:+86 0591-87884919 8690
E-mail:hjc@rock-chips.com
WARNING: multiple messages have this Message-ID (diff)
From: Huang Jiachai <hjc@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>, "David Airlie" <airlied@linux.ie>
Cc: huangtao@rock-chips.com, Thomas Zimmermann <tzimmermann@suse.de>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
kever.yang@rock-chips.com, Maxime Ripard <mripard@kernel.org>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
andy.yan@rock-chips.com
Subject: Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled
Date: Wed, 2 Sep 2020 19:56:01 +0800 [thread overview]
Message-ID: <fc4aab7b-c1e5-4469-8ccd-4529055e05a1@rock-chips.com> (raw)
In-Reply-To: <12d1b648-81d1-df48-4435-b7b88dd72b30@rock-chips.com>
Hi David Airlie,
Please help to confirm whether this modification is reasonable when
you are free, thanks.
在 2020/8/13 14:31, Huang Jiachai 写道:
> ping...
>
> 在 2020/7/23 3:01, Heiko Stübner 写道:
>> Am Dienstag, 7. Juli 2020, 13:25:26 CEST schrieb Sandy Huang:
>>> don't mask possible_crtcs if remote-point is disabled.
>>>
>>> Signed-off-by: Sandy Huang <hjc@rock-chips.com>
>> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>>
>> changes in v2:
>> - drop additional of_node_put, as ep will be put with the next
>> iteration of for_each_endpoint_of_node()
>>
>>
>> As this touches a pretty central function is there something
>> to keep in mind in regards to other DRM drivers?
>> [question for the broader audience ;-) ]
>>
>> Heiko
>>
>>> ---
>>> drivers/gpu/drm/drm_of.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
>>> index fdb05fbf72a0..565f05f5f11b 100644
>>> --- a/drivers/gpu/drm/drm_of.c
>>> +++ b/drivers/gpu/drm/drm_of.c
>>> @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct
>>> drm_device *dev,
>>> uint32_t possible_crtcs = 0;
>>> for_each_endpoint_of_node(port, ep) {
>>> + if (!of_device_is_available(ep))
>>> + continue;
>>> +
>>> remote_port = of_graph_get_remote_port(ep);
>>> if (!remote_port) {
>>> of_node_put(ep);
>>>
>>
>>
>>
>>
>>
--
Best Regard
黄家钗
Sandy Huang
Addr: 福州市鼓楼区铜盘路软件大道89号福州软件园A区21号楼(350003)
No. 21 Building, A District, No.89,software Boulevard Fuzhou,Fujian,PRC
Tel:+86 0591-87884919 8690
E-mail:hjc@rock-chips.com
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Huang Jiachai <hjc@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>, "David Airlie" <airlied@linux.ie>
Cc: huangtao@rock-chips.com, Thomas Zimmermann <tzimmermann@suse.de>,
kever.yang@rock-chips.com, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org, andy.yan@rock-chips.com
Subject: Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled
Date: Wed, 2 Sep 2020 19:56:01 +0800 [thread overview]
Message-ID: <fc4aab7b-c1e5-4469-8ccd-4529055e05a1@rock-chips.com> (raw)
In-Reply-To: <12d1b648-81d1-df48-4435-b7b88dd72b30@rock-chips.com>
Hi David Airlie,
Please help to confirm whether this modification is reasonable when
you are free, thanks.
在 2020/8/13 14:31, Huang Jiachai 写道:
> ping...
>
> 在 2020/7/23 3:01, Heiko Stübner 写道:
>> Am Dienstag, 7. Juli 2020, 13:25:26 CEST schrieb Sandy Huang:
>>> don't mask possible_crtcs if remote-point is disabled.
>>>
>>> Signed-off-by: Sandy Huang <hjc@rock-chips.com>
>> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>>
>> changes in v2:
>> - drop additional of_node_put, as ep will be put with the next
>> iteration of for_each_endpoint_of_node()
>>
>>
>> As this touches a pretty central function is there something
>> to keep in mind in regards to other DRM drivers?
>> [question for the broader audience ;-) ]
>>
>> Heiko
>>
>>> ---
>>> drivers/gpu/drm/drm_of.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
>>> index fdb05fbf72a0..565f05f5f11b 100644
>>> --- a/drivers/gpu/drm/drm_of.c
>>> +++ b/drivers/gpu/drm/drm_of.c
>>> @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct
>>> drm_device *dev,
>>> uint32_t possible_crtcs = 0;
>>> for_each_endpoint_of_node(port, ep) {
>>> + if (!of_device_is_available(ep))
>>> + continue;
>>> +
>>> remote_port = of_graph_get_remote_port(ep);
>>> if (!remote_port) {
>>> of_node_put(ep);
>>>
>>
>>
>>
>>
>>
--
Best Regard
黄家钗
Sandy Huang
Addr: 福州市鼓楼区铜盘路软件大道89号福州软件园A区21号楼(350003)
No. 21 Building, A District, No.89,software Boulevard Fuzhou,Fujian,PRC
Tel:+86 0591-87884919 8690
E-mail:hjc@rock-chips.com
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-09-02 11:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 11:25 [PATCH v2] drm/of: Consider the state in which the ep is disabled Sandy Huang
2020-07-07 11:25 ` Sandy Huang
2020-07-07 11:33 ` Heiko Stübner
2020-07-07 11:33 ` Heiko Stübner
2020-07-22 19:01 ` Heiko Stübner
2020-07-22 19:01 ` Heiko Stübner
2020-08-13 6:31 ` Huang Jiachai
2020-08-13 6:31 ` Huang Jiachai
2020-08-13 6:31 ` Huang Jiachai
2020-09-02 11:56 ` Huang Jiachai [this message]
2020-09-02 11:56 ` Huang Jiachai
2020-09-02 11:56 ` Huang Jiachai
2020-10-14 1:48 ` Kever Yang
2020-10-14 1:48 ` Kever Yang
2020-10-14 1:48 ` Kever Yang
2020-10-15 15:23 ` Daniel Vetter
2020-10-15 15:23 ` Daniel Vetter
2020-10-15 15:23 ` Daniel Vetter
2020-10-19 3:43 ` Kever Yang
2020-10-19 3:43 ` Kever Yang
2020-10-19 3:43 ` Kever Yang
2020-10-20 8:13 ` Daniel Vetter
2020-10-20 8:13 ` Daniel Vetter
2020-10-20 8:13 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc4aab7b-c1e5-4469-8ccd-4529055e05a1@rock-chips.com \
--to=hjc@rock-chips.com \
--cc=airlied@linux.ie \
--cc=andy.yan@rock-chips.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.