All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Wen Gong <wgong@codeaurora.org>, ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/9] cfg80211: add power type definition for 6G Hz
Date: Fri, 23 Jul 2021 11:22:07 +0200	[thread overview]
Message-ID: <fccc9724374281d2d95e1ef52391788892552268.camel@sipsolutions.net> (raw)
In-Reply-To: <20210517201932.8860-2-wgong@codeaurora.org> (sfid-20210517_222034_404094_2413CDB0)

Hi,

Sorry it took me so long to look at this. I started earlier, but then
found some questions and then ... sorry.

> 
> +/**
> + * enum nl80211_ap_reg_power - regulatory power for a Access Point
> + *
> + * @NL80211_REG_UNSET_AP: Access Point has no regulatory power mode
> + * @NL80211_REG_LPI: Indoor Access Point
> + * @NL80211_REG_SP: Standard power Access Point
> + * @NL80211_REG_VLP: Very low power Access Point
> + */
> +enum nl80211_ap_reg_power {
> +	NL80211_REG_UNSET_AP,
> +	NL80211_REG_LPI_AP,
> +	NL80211_REG_SP_AP,
> +	NL80211_REG_VLP_AP,
> +	NL80211_REG_MAX_AP_TYPE = 3,

That last one is missing docs. Also, why should it be numbered
explicitly? Better add something like

	NUM_NL80211_REG_POWER_TYPE,
	NL80211_REG_MAX_TYPE = NUM_NL80211_REG_POWER_TYPE - 1

or something?


> +enum nl80211_client_reg_power {
> +	NL80211_REG_UNSET_CLIENT,
> +	NL80211_REG_DEFAULT_CLIENT,
> +	NL80211_REG_SUBORDINATE_CLIENT,
> +	NL80211_REG_MAX_CLIENT_TYPE = 2,

same here.

johannes


WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Wen Gong <wgong@codeaurora.org>, ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/9] cfg80211: add power type definition for 6G Hz
Date: Fri, 23 Jul 2021 11:22:07 +0200	[thread overview]
Message-ID: <fccc9724374281d2d95e1ef52391788892552268.camel@sipsolutions.net> (raw)
In-Reply-To: <20210517201932.8860-2-wgong@codeaurora.org> (sfid-20210517_222034_404094_2413CDB0)

Hi,

Sorry it took me so long to look at this. I started earlier, but then
found some questions and then ... sorry.

> 
> +/**
> + * enum nl80211_ap_reg_power - regulatory power for a Access Point
> + *
> + * @NL80211_REG_UNSET_AP: Access Point has no regulatory power mode
> + * @NL80211_REG_LPI: Indoor Access Point
> + * @NL80211_REG_SP: Standard power Access Point
> + * @NL80211_REG_VLP: Very low power Access Point
> + */
> +enum nl80211_ap_reg_power {
> +	NL80211_REG_UNSET_AP,
> +	NL80211_REG_LPI_AP,
> +	NL80211_REG_SP_AP,
> +	NL80211_REG_VLP_AP,
> +	NL80211_REG_MAX_AP_TYPE = 3,

That last one is missing docs. Also, why should it be numbered
explicitly? Better add something like

	NUM_NL80211_REG_POWER_TYPE,
	NL80211_REG_MAX_TYPE = NUM_NL80211_REG_POWER_TYPE - 1

or something?


> +enum nl80211_client_reg_power {
> +	NL80211_REG_UNSET_CLIENT,
> +	NL80211_REG_DEFAULT_CLIENT,
> +	NL80211_REG_SUBORDINATE_CLIENT,
> +	NL80211_REG_MAX_CLIENT_TYPE = 2,

same here.

johannes


-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2021-07-23  9:22 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 20:19 [PATCH 0/9] cfg80211/mac80211: Add support for 6GHZ STA for various modes : LPI, SP and VLP Wen Gong
2021-05-17 20:19 ` Wen Gong
2021-05-17 20:19 ` [PATCH 1/9] cfg80211: add power type definition for 6G Hz Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-07-23  9:22   ` Johannes Berg [this message]
2021-07-23  9:22     ` Johannes Berg
2021-05-17 20:19 ` [PATCH 2/9] mac80211: add definition of regulatory info in 6G Hz operation information Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-05-17 20:19 ` [PATCH 3/9] mac80211: add parse " Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-07-23  9:23   ` Johannes Berg
2021-07-23  9:23     ` Johannes Berg
2021-05-17 20:19 ` [PATCH 4/9] cfg80211: add definition for 6G power spectral density(psd) Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-07-23  9:24   ` Johannes Berg
2021-07-23  9:24     ` Johannes Berg
2021-07-30 10:00     ` Wen Gong
2021-07-30 10:00       ` Wen Gong
2021-05-17 20:19 ` [PATCH 5/9] cfg80211: save power spectral density(psd) of regulatory rule Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-07-23  9:27   ` Johannes Berg
2021-07-23  9:27     ` Johannes Berg
2021-07-30 10:06     ` Wen Gong
2021-07-30 10:06       ` Wen Gong
2021-05-17 20:19 ` [PATCH 6/9] mac80211: add definition for transmit power envelope element Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-07-23  9:29   ` Johannes Berg
2021-07-23  9:29     ` Johannes Berg
2021-07-23  9:31   ` Johannes Berg
2021-07-23  9:31     ` Johannes Berg
2021-07-30 10:27     ` Wen Gong
2021-07-30 10:27       ` Wen Gong
2021-05-17 20:19 ` [PATCH 7/9] mac80211: add parse " Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-07-23  9:33   ` Johannes Berg
2021-07-23  9:33     ` Johannes Berg
2021-07-30 10:16     ` Wen Gong
2021-07-30 10:16       ` Wen Gong
2021-05-17 20:19 ` [PATCH 8/9] mac80211: add transmit power envelope element and power constraint in bss_conf Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-07-23  9:33   ` Johannes Berg
2021-07-23  9:33     ` Johannes Berg
2021-05-17 20:19 ` [PATCH 9/9] mac80211: save transmit power envelope element and power constraint Wen Gong
2021-05-17 20:19   ` Wen Gong
2021-07-23  9:38   ` Johannes Berg
2021-07-23  9:38     ` Johannes Berg
2021-07-30 10:47     ` Wen Gong
2021-07-30 10:47       ` Wen Gong
2021-08-03  8:53       ` Wen Gong
2021-08-03  8:53         ` Wen Gong
2021-08-13  7:19       ` Johannes Berg
2021-08-13  7:19         ` Johannes Berg
2021-08-13  7:25         ` Johannes Berg
2021-08-13  7:25           ` Johannes Berg
2021-08-13  8:47           ` Wen Gong
2021-08-13  8:47             ` Wen Gong
2021-08-13  8:53             ` Johannes Berg
2021-08-13  8:53               ` Johannes Berg
2021-08-13  9:16               ` Wen Gong
2021-08-13  9:16                 ` Wen Gong
2021-08-13 10:11                 ` Johannes Berg
2021-08-13 10:11                   ` Johannes Berg
2021-08-13 10:29                   ` Wen Gong
2021-08-13 10:29                     ` Wen Gong
2021-08-13  8:13         ` Wen Gong
2021-08-13  8:13           ` Wen Gong
2021-05-25 10:04 ` [PATCH 0/9] cfg80211/mac80211: Add support for 6GHZ STA for various modes : LPI, SP and VLP Wen Gong
2021-05-25 10:04   ` Wen Gong
2021-06-15  8:52   ` Wen Gong
2021-06-15  8:52     ` Wen Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fccc9724374281d2d95e1ef52391788892552268.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wgong@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.