* [PATCH] drm/i915: Add not fenceable reason to not enable FBC
@ 2019-03-22 0:42 José Roberto de Souza
2019-03-22 0:47 ` Souza, Jose
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: José Roberto de Souza @ 2019-03-22 0:42 UTC (permalink / raw)
To: intel-gfx; +Cc: Paulo Zanoni
There is some kms_frontbuffer_tracking failures due FBC being
disabled with the reason "framebuffer not tiled or fenced".
Although the test is setting up everything correctly to have
FBC enabled sporadically it is failing, due the alignment and size
restrictions in __i915_vma_set_map_and_fenceable().
So lets add another FBC failure reason and skip tests when that is
set and keep "framebuffer not tiled or fenced" as error as it
indicates that buffer is not tiled due wrong setup of the test.
Also fixing close typos.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108040
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/intel_fbc.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index 656e684e7c9a..2980a3b579e0 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++ b/drivers/gpu/drm/i915/intel_fbc.c
@@ -726,19 +726,30 @@ static bool intel_fbc_can_activate(struct intel_crtc *crtc)
* by the CPU to the scanout and trigger updates to the FBC.
*
* Note that is possible for a tiled surface to be unmappable (and
- * so have no fence associated with it) due to aperture constaints
+ * so have no fence associated with it) due to aperture constraints
* at the time of pinning.
*
* FIXME with 90/270 degree rotation we should use the fence on
* the normal GTT view (the rotated view doesn't even have a
* fence). Would need changes to the FBC fence Y offset as well.
- * For now this will effecively disable FBC with 90/270 degree
+ * For now this will effectively disable FBC with 90/270 degree
* rotation.
*/
+ if (!(cache->vma->flags & I915_VMA_CAN_FENCE)) {
+ /* Requirements not meet see __i915_vma_set_map_and_fenceable() */
+ fbc->no_fbc_reason = "framebuffer is not fenceable";
+ return false;
+ }
+
if (!(cache->flags & PLANE_HAS_FENCE)) {
+ /*
+ * If framebuffer can have fence but don't has it, it is
+ * because buffer is not tiled.
+ */
fbc->no_fbc_reason = "framebuffer not tiled or fenced";
return false;
}
+
if (INTEL_GEN(dev_priv) <= 4 && !IS_G4X(dev_priv) &&
cache->plane.rotation != DRM_MODE_ROTATE_0) {
fbc->no_fbc_reason = "rotation unsupported";
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Add not fenceable reason to not enable FBC
2019-03-22 0:42 [PATCH] drm/i915: Add not fenceable reason to not enable FBC José Roberto de Souza
@ 2019-03-22 0:47 ` Souza, Jose
2019-03-22 3:22 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Souza, Jose @ 2019-03-22 0:47 UTC (permalink / raw)
To: intel-gfx; +Cc: Zanoni, Paulo R
[-- Attachment #1.1: Type: text/plain, Size: 2764 bytes --]
After sent I notice that the commit descriptions feels strange to read,
maybe changing to "drm/i915: Add 'not fenceable' reason to not enable
FBC" makes it better, any tips?
On Thu, 2019-03-21 at 17:42 -0700, José Roberto de Souza wrote:
> There is some kms_frontbuffer_tracking failures due FBC being
> disabled with the reason "framebuffer not tiled or fenced".
> Although the test is setting up everything correctly to have
> FBC enabled sporadically it is failing, due the alignment and size
> restrictions in __i915_vma_set_map_and_fenceable().
>
> So lets add another FBC failure reason and skip tests when that is
> set and keep "framebuffer not tiled or fenced" as error as it
> indicates that buffer is not tiled due wrong setup of the test.
>
> Also fixing close typos.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108040
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/intel_fbc.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_fbc.c
> b/drivers/gpu/drm/i915/intel_fbc.c
> index 656e684e7c9a..2980a3b579e0 100644
> --- a/drivers/gpu/drm/i915/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/intel_fbc.c
> @@ -726,19 +726,30 @@ static bool intel_fbc_can_activate(struct
> intel_crtc *crtc)
> * by the CPU to the scanout and trigger updates to the FBC.
> *
> * Note that is possible for a tiled surface to be unmappable
> (and
> - * so have no fence associated with it) due to aperture
> constaints
> + * so have no fence associated with it) due to aperture
> constraints
> * at the time of pinning.
> *
> * FIXME with 90/270 degree rotation we should use the fence on
> * the normal GTT view (the rotated view doesn't even have a
> * fence). Would need changes to the FBC fence Y offset as
> well.
> - * For now this will effecively disable FBC with 90/270 degree
> + * For now this will effectively disable FBC with 90/270 degree
> * rotation.
> */
> + if (!(cache->vma->flags & I915_VMA_CAN_FENCE)) {
> + /* Requirements not meet see
> __i915_vma_set_map_and_fenceable() */
> + fbc->no_fbc_reason = "framebuffer is not fenceable";
> + return false;
> + }
> +
> if (!(cache->flags & PLANE_HAS_FENCE)) {
> + /*
> + * If framebuffer can have fence but don't has it, it
> is
> + * because buffer is not tiled.
> + */
> fbc->no_fbc_reason = "framebuffer not tiled or fenced";
> return false;
> }
> +
> if (INTEL_GEN(dev_priv) <= 4 && !IS_G4X(dev_priv) &&
> cache->plane.rotation != DRM_MODE_ROTATE_0) {
> fbc->no_fbc_reason = "rotation unsupported";
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Add not fenceable reason to not enable FBC
2019-03-22 0:42 [PATCH] drm/i915: Add not fenceable reason to not enable FBC José Roberto de Souza
2019-03-22 0:47 ` Souza, Jose
@ 2019-03-22 3:22 ` Patchwork
2019-03-22 7:06 ` [PATCH] " Chris Wilson
2019-03-22 22:24 ` ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-03-22 3:22 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Add not fenceable reason to not enable FBC
URL : https://patchwork.freedesktop.org/series/58390/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5792 -> Patchwork_12565
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58390/revisions/1/mbox/
Known issues
------------
Here are the changes found in Patchwork_12565 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic-files:
- fi-gdg-551: NOTRUN -> SKIP [fdo#109271] +106
* igt@gem_exec_basic@readonly-bsd2:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +76
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: PASS -> FAIL [fdo#108511]
* igt@kms_busy@basic-flip-c:
- fi-gdg-551: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_psr@primary_mmap_gtt:
- fi-blb-e6850: NOTRUN -> SKIP [fdo#109271] +27
* igt@kms_psr@primary_page_flip:
- fi-apl-guc: NOTRUN -> SKIP [fdo#109271] +50
* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: NOTRUN -> FAIL [fdo#103182]
#### Possible fixes ####
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
Participating hosts (40 -> 37)
------------------------------
Additional (3): fi-gdg-551 fi-apl-guc fi-pnv-d510
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_5792 -> Patchwork_12565
CI_DRM_5792: 109336adf97713e8d6f693a56f22f334b9f64ce9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4897: e12d69496a6bef09ac6c0f792b8d60a65cf5e0bf @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12565: aa83d1e2c5d5711deaa572a32c8b15d8f0b602b0 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
aa83d1e2c5d5 drm/i915: Add not fenceable reason to not enable FBC
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12565/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Add not fenceable reason to not enable FBC
2019-03-22 0:42 [PATCH] drm/i915: Add not fenceable reason to not enable FBC José Roberto de Souza
2019-03-22 0:47 ` Souza, Jose
2019-03-22 3:22 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-03-22 7:06 ` Chris Wilson
2019-03-26 1:11 ` Souza, Jose
2019-03-22 22:24 ` ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2019-03-22 7:06 UTC (permalink / raw)
To: José Roberto de Souza, intel-gfx; +Cc: Paulo Zanoni
Quoting José Roberto de Souza (2019-03-22 00:42:59)
> There is some kms_frontbuffer_tracking failures due FBC being
> disabled with the reason "framebuffer not tiled or fenced".
> Although the test is setting up everything correctly to have
> FBC enabled sporadically it is failing, due the alignment and size
> restrictions in __i915_vma_set_map_and_fenceable().
>
> So lets add another FBC failure reason and skip tests when that is
> set and keep "framebuffer not tiled or fenced" as error as it
> indicates that buffer is not tiled due wrong setup of the test.
>
> Also fixing close typos.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108040
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/intel_fbc.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
> index 656e684e7c9a..2980a3b579e0 100644
> --- a/drivers/gpu/drm/i915/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/intel_fbc.c
> @@ -726,19 +726,30 @@ static bool intel_fbc_can_activate(struct intel_crtc *crtc)
> * by the CPU to the scanout and trigger updates to the FBC.
> *
> * Note that is possible for a tiled surface to be unmappable (and
> - * so have no fence associated with it) due to aperture constaints
> + * so have no fence associated with it) due to aperture constraints
> * at the time of pinning.
> *
> * FIXME with 90/270 degree rotation we should use the fence on
> * the normal GTT view (the rotated view doesn't even have a
> * fence). Would need changes to the FBC fence Y offset as well.
> - * For now this will effecively disable FBC with 90/270 degree
> + * For now this will effectively disable FBC with 90/270 degree
> * rotation.
> */
> + if (!(cache->vma->flags & I915_VMA_CAN_FENCE)) {
if (!i915_vma_is_map_and_fenceable(cache->vma)) {
> + /* Requirements not meet see __i915_vma_set_map_and_fenceable() */
I would suggest pointing at intel_pin_and_fence_fb and
i915_gem_object_pin_to_display_plane as to why it chose not to require
a fence.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Add not fenceable reason to not enable FBC
2019-03-22 0:42 [PATCH] drm/i915: Add not fenceable reason to not enable FBC José Roberto de Souza
` (2 preceding siblings ...)
2019-03-22 7:06 ` [PATCH] " Chris Wilson
@ 2019-03-22 22:24 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-03-22 22:24 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Add not fenceable reason to not enable FBC
URL : https://patchwork.freedesktop.org/series/58390/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5792_full -> Patchwork_12565_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12565_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@preempt-other-chain-blt:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +35
* igt@gem_exec_schedule@promotion-bsd2:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +4
* igt@gem_pread@stolen-uncached:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +70
* igt@i915_pm_backlight@fade_with_suspend:
- shard-iclb: NOTRUN -> FAIL [fdo#107847]
* igt@i915_pm_rps@reset:
- shard-iclb: NOTRUN -> FAIL [fdo#108059]
* igt@kms_atomic_transition@3x-modeset-transitions-fencing:
- shard-iclb: NOTRUN -> SKIP [fdo#109278] +1
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-apl: PASS -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-modeset-hang-newfb-render-d:
- shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +5
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-iclb: NOTRUN -> DMESG-WARN [fdo#110222]
* igt@kms_busy@extended-modeset-hang-oldfb-render-e:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +6
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
- shard-glk: PASS -> DMESG-WARN [fdo#110222]
* igt@kms_chamelium@hdmi-crc-single:
- shard-iclb: NOTRUN -> SKIP [fdo#109284]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] +7
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-iclb: PASS -> FAIL [fdo#103355]
* igt@kms_dp_dsc@basic-dsc-enable-dp:
- shard-iclb: NOTRUN -> SKIP [fdo#109349]
* igt@kms_flip@plain-flip-fb-recreate:
- shard-skl: PASS -> FAIL [fdo#100368]
* igt@kms_force_connector_basic@force-edid:
- shard-iclb: NOTRUN -> SKIP [fdo#109285]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt:
- shard-skl: NOTRUN -> SKIP [fdo#109271] +77
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-iclb: PASS -> FAIL [fdo#103167] +4
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-move:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +9
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-wc:
- shard-iclb: PASS -> FAIL [fdo#105682] / [fdo#109247]
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc:
- shard-iclb: PASS -> FAIL [fdo#109247] +27
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render:
- shard-iclb: NOTRUN -> FAIL [fdo#109247]
* igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes:
- shard-iclb: NOTRUN -> SKIP [fdo#109289]
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparant-fb:
- shard-kbl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-kbl: NOTRUN -> FAIL [fdo#108145] / [fdo#108590]
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-skl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_scaling@pipe-c-scaler-with-rotation:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_psr@cursor_mmap_gtt:
- shard-iclb: PASS -> FAIL [fdo#107383] / [fdo#110215] +5
* igt@kms_psr@no_drrs:
- shard-iclb: PASS -> FAIL [fdo#108341]
* igt@kms_psr@primary_blt:
- shard-iclb: NOTRUN -> FAIL [fdo#107383] / [fdo#110215]
* igt@kms_psr@psr2_dpms:
- shard-iclb: PASS -> SKIP [fdo#109441] +2
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: NOTRUN -> SKIP [fdo#109441]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: PASS -> FAIL [fdo#109016]
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +5
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-iclb: PASS -> FAIL [fdo#104894]
* igt@prime_nv_pcopy@test1_micro:
- shard-iclb: NOTRUN -> SKIP [fdo#109291] +1
* igt@prime_vgem@fence-read-hang:
- shard-iclb: NOTRUN -> SKIP [fdo#109295]
#### Possible fixes ####
* igt@gem_busy@close-race:
- shard-apl: FAIL -> PASS
* igt@gem_create@create-clear:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS
* igt@gem_exec_schedule@wide-vebox:
- shard-iclb: FAIL [fdo#109633] -> PASS
* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-iclb: INCOMPLETE [fdo#109801] -> PASS
* igt@gem_softpin@noreloc-s3:
- shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] -> PASS
* igt@gem_tiled_pread_pwrite:
- shard-iclb: TIMEOUT [fdo#109673] -> PASS
* igt@gem_tiled_swapping@non-threaded:
- shard-iclb: INCOMPLETE [fdo#110197] -> PASS
* igt@i915_suspend@sysfs-reader:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-iclb: FAIL [fdo#103355] -> PASS
* igt@kms_fbcon_fbt@fbc:
- shard-iclb: DMESG-WARN [fdo#109593] -> PASS
* igt@kms_flip@flip-vs-expired-vblank:
- shard-iclb: FAIL [fdo#105363] -> PASS
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: INCOMPLETE [fdo#109507] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: FAIL [fdo#103167] -> PASS +3
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-pwrite:
- shard-iclb: FAIL [fdo#105682] / [fdo#109247] -> PASS +2
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-fullscreen:
- shard-iclb: FAIL [fdo#109247] -> PASS +25
* {igt@kms_plane@pixel-format-pipe-c-planes-source-clamping}:
- shard-glk: SKIP [fdo#109271] -> PASS
- shard-iclb: INCOMPLETE [fdo#110036 ] -> PASS
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-apl: FAIL [fdo#108145] -> PASS
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: FAIL [fdo#107815] -> PASS +1
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: SKIP [fdo#109642] -> PASS
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: SKIP [fdo#109441] -> PASS
* igt@kms_psr@sprite_mmap_gtt:
- shard-iclb: FAIL [fdo#107383] / [fdo#110215] -> PASS +5
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
* igt@perf@oa-exponents:
- shard-glk: FAIL [fdo#105483] -> PASS
#### Warnings ####
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-skl: SKIP [fdo#109271] -> INCOMPLETE [fdo#107807]
* igt@i915_selftest@live_contexts:
- shard-iclb: INCOMPLETE [fdo#108569] -> DMESG-FAIL [fdo#108569]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105483]: https://bugs.freedesktop.org/show_bug.cgi?id=105483
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107847]: https://bugs.freedesktop.org/show_bug.cgi?id=107847
[fdo#108059]: https://bugs.freedesktop.org/show_bug.cgi?id=108059
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108590]: https://bugs.freedesktop.org/show_bug.cgi?id=108590
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#109593]: https://bugs.freedesktop.org/show_bug.cgi?id=109593
[fdo#109633]: https://bugs.freedesktop.org/show_bug.cgi?id=109633
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
[fdo#109801]: https://bugs.freedesktop.org/show_bug.cgi?id=109801
[fdo#110036 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110036
[fdo#110197]: https://bugs.freedesktop.org/show_bug.cgi?id=110197
[fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 9)
------------------------------
Missing (1): shard-hsw
Build changes
-------------
* Linux: CI_DRM_5792 -> Patchwork_12565
CI_DRM_5792: 109336adf97713e8d6f693a56f22f334b9f64ce9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4897: e12d69496a6bef09ac6c0f792b8d60a65cf5e0bf @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12565: aa83d1e2c5d5711deaa572a32c8b15d8f0b602b0 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12565/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Add not fenceable reason to not enable FBC
2019-03-22 7:06 ` [PATCH] " Chris Wilson
@ 2019-03-26 1:11 ` Souza, Jose
0 siblings, 0 replies; 6+ messages in thread
From: Souza, Jose @ 2019-03-26 1:11 UTC (permalink / raw)
To: intel-gfx, chris; +Cc: Zanoni, Paulo R
[-- Attachment #1.1: Type: text/plain, Size: 2913 bytes --]
On Fri, 2019-03-22 at 07:06 +0000, Chris Wilson wrote:
> Quoting José Roberto de Souza (2019-03-22 00:42:59)
> > There is some kms_frontbuffer_tracking failures due FBC being
> > disabled with the reason "framebuffer not tiled or fenced".
> > Although the test is setting up everything correctly to have
> > FBC enabled sporadically it is failing, due the alignment and size
> > restrictions in __i915_vma_set_map_and_fenceable().
> >
> > So lets add another FBC failure reason and skip tests when that is
> > set and keep "framebuffer not tiled or fenced" as error as it
> > indicates that buffer is not tiled due wrong setup of the test.
> >
> > Also fixing close typos.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108040
> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_fbc.c | 15 +++++++++++++--
> > 1 file changed, 13 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_fbc.c
> > b/drivers/gpu/drm/i915/intel_fbc.c
> > index 656e684e7c9a..2980a3b579e0 100644
> > --- a/drivers/gpu/drm/i915/intel_fbc.c
> > +++ b/drivers/gpu/drm/i915/intel_fbc.c
> > @@ -726,19 +726,30 @@ static bool intel_fbc_can_activate(struct
> > intel_crtc *crtc)
> > * by the CPU to the scanout and trigger updates to the
> > FBC.
> > *
> > * Note that is possible for a tiled surface to be
> > unmappable (and
> > - * so have no fence associated with it) due to aperture
> > constaints
> > + * so have no fence associated with it) due to aperture
> > constraints
> > * at the time of pinning.
> > *
> > * FIXME with 90/270 degree rotation we should use the
> > fence on
> > * the normal GTT view (the rotated view doesn't even have
> > a
> > * fence). Would need changes to the FBC fence Y offset as
> > well.
> > - * For now this will effecively disable FBC with 90/270
> > degree
> > + * For now this will effectively disable FBC with 90/270
> > degree
> > * rotation.
> > */
> > + if (!(cache->vma->flags & I915_VMA_CAN_FENCE)) {
>
> if (!i915_vma_is_map_and_fenceable(cache->vma)) {
Thanks
>
> > + /* Requirements not meet see
> > __i915_vma_set_map_and_fenceable() */
>
> I would suggest pointing at intel_pin_and_fence_fb and
> i915_gem_object_pin_to_display_plane as to why it chose not to
> require
> a fence.
Oh so even if i915_vma_is_map_and_fenceable() returns true in
intel_pin_and_fence_fb_obj() it could still fail to set the fence in
i915_vma_pin_fence() because there is no fences available.
So I guess is better not add 'framebuffer is not fenceable' and skip
tests when 'framebuffer not tiled or fenced' is set, what do you think?
> -Chris
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-26 1:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-22 0:42 [PATCH] drm/i915: Add not fenceable reason to not enable FBC José Roberto de Souza
2019-03-22 0:47 ` Souza, Jose
2019-03-22 3:22 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-03-22 7:06 ` [PATCH] " Chris Wilson
2019-03-26 1:11 ` Souza, Jose
2019-03-22 22:24 ` ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.