All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Chenyang Li <lichenyang@loongson.cn>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h
Date: Thu, 24 Dec 2020 22:52:25 +0100	[thread overview]
Message-ID: <ff33467b-a7b9-fa34-6f63-a9c323184f95@molgen.mpg.de> (raw)
In-Reply-To: <20201223011926.15924-1-lichenyang@loongson.cn>

Dear Chenyang,


Am 23.12.20 um 02:19 schrieb Chenyang Li:
> In line 24 "_AMDGPU_TRACE_H" is missing an underscore.

Nice catch. Could you please update the commit message summary, by 
adding a space after the prefix (colon), and using imperative mood [1]?

> drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition

If you can also add a Fixes tag, that would be even better.

Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")

> Signed-off-by: Chenyang Li <lichenyang@loongson.cn>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

[…]


Kind regards,

Paul


[1]: https://chris.beams.io/posts/git-commit/
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Chenyang Li <lichenyang@loongson.cn>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h
Date: Thu, 24 Dec 2020 22:52:25 +0100	[thread overview]
Message-ID: <ff33467b-a7b9-fa34-6f63-a9c323184f95@molgen.mpg.de> (raw)
In-Reply-To: <20201223011926.15924-1-lichenyang@loongson.cn>

Dear Chenyang,


Am 23.12.20 um 02:19 schrieb Chenyang Li:
> In line 24 "_AMDGPU_TRACE_H" is missing an underscore.

Nice catch. Could you please update the commit message summary, by 
adding a space after the prefix (colon), and using imperative mood [1]?

> drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition

If you can also add a Fixes tag, that would be even better.

Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")

> Signed-off-by: Chenyang Li <lichenyang@loongson.cn>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

[…]


Kind regards,

Paul


[1]: https://chris.beams.io/posts/git-commit/
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2020-12-24 21:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23  1:19 [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h Chenyang Li
2020-12-23  1:19 ` Chenyang Li
2020-12-24  2:20 ` Chen, Guchun
2020-12-24  2:20   ` Chen, Guchun
2020-12-24 21:52 ` Paul Menzel [this message]
2020-12-24 21:52   ` Paul Menzel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff33467b-a7b9-fa34-6f63-a9c323184f95@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lichenyang@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.