All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h
@ 2020-12-23  1:19 ` Chenyang Li
  0 siblings, 0 replies; 6+ messages in thread
From: Chenyang Li @ 2020-12-23  1:19 UTC (permalink / raw)
  To: Alex Deucher, amd-gfx, dri-devel

In line 24 "_AMDGPU_TRACE_H" is missing an underscore.

Signed-off-by: Chenyang Li <lichenyang@loongson.cn>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
index ee9480d14cbc..86cfb3d55477 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
@@ -21,7 +21,7 @@
  *
  */
 
-#if !defined(_AMDGPU_TRACE_H) || defined(TRACE_HEADER_MULTI_READ)
+#if !defined(_AMDGPU_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ)
 #define _AMDGPU_TRACE_H_
 
 #include <linux/stringify.h>
-- 
2.29.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h
@ 2020-12-23  1:19 ` Chenyang Li
  0 siblings, 0 replies; 6+ messages in thread
From: Chenyang Li @ 2020-12-23  1:19 UTC (permalink / raw)
  To: Alex Deucher, amd-gfx, dri-devel

In line 24 "_AMDGPU_TRACE_H" is missing an underscore.

Signed-off-by: Chenyang Li <lichenyang@loongson.cn>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
index ee9480d14cbc..86cfb3d55477 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
@@ -21,7 +21,7 @@
  *
  */
 
-#if !defined(_AMDGPU_TRACE_H) || defined(TRACE_HEADER_MULTI_READ)
+#if !defined(_AMDGPU_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ)
 #define _AMDGPU_TRACE_H_
 
 #include <linux/stringify.h>
-- 
2.29.2

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* RE: [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h
  2020-12-23  1:19 ` Chenyang Li
@ 2020-12-24  2:20   ` Chen, Guchun
  -1 siblings, 0 replies; 6+ messages in thread
From: Chen, Guchun @ 2020-12-24  2:20 UTC (permalink / raw)
  To: Chenyang Li, Deucher, Alexander, amd-gfx, dri-devel

[AMD Public Use]

Nice catch and the patch is:

Reviewed-by: Guchun Chen <guchun.chen@amd.com>

Regards,
Guchun

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Chenyang Li
Sent: Wednesday, December 23, 2020 9:19 AM
To: Deucher, Alexander <Alexander.Deucher@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Subject: [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h

In line 24 "_AMDGPU_TRACE_H" is missing an underscore.

Signed-off-by: Chenyang Li <lichenyang@loongson.cn>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
index ee9480d14cbc..86cfb3d55477 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
@@ -21,7 +21,7 @@
  *
  */
 
-#if !defined(_AMDGPU_TRACE_H) || defined(TRACE_HEADER_MULTI_READ)
+#if !defined(_AMDGPU_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ)
 #define _AMDGPU_TRACE_H_
 
 #include <linux/stringify.h>
-- 
2.29.2

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7Cguchun.chen%40amd.com%7C8d902bda929a44a4eac508d8a7114368%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637443040220638596%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&amp;sdata=%2ByVfo1XiGQKDHkf354Kpi2edjFzsUT3FIlAXAM6O6AE%3D&amp;reserved=0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* RE: [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h
@ 2020-12-24  2:20   ` Chen, Guchun
  0 siblings, 0 replies; 6+ messages in thread
From: Chen, Guchun @ 2020-12-24  2:20 UTC (permalink / raw)
  To: Chenyang Li, Deucher, Alexander, amd-gfx, dri-devel

[AMD Public Use]

Nice catch and the patch is:

Reviewed-by: Guchun Chen <guchun.chen@amd.com>

Regards,
Guchun

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Chenyang Li
Sent: Wednesday, December 23, 2020 9:19 AM
To: Deucher, Alexander <Alexander.Deucher@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Subject: [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h

In line 24 "_AMDGPU_TRACE_H" is missing an underscore.

Signed-off-by: Chenyang Li <lichenyang@loongson.cn>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
index ee9480d14cbc..86cfb3d55477 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
@@ -21,7 +21,7 @@
  *
  */
 
-#if !defined(_AMDGPU_TRACE_H) || defined(TRACE_HEADER_MULTI_READ)
+#if !defined(_AMDGPU_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ)
 #define _AMDGPU_TRACE_H_
 
 #include <linux/stringify.h>
-- 
2.29.2

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7Cguchun.chen%40amd.com%7C8d902bda929a44a4eac508d8a7114368%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637443040220638596%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&amp;sdata=%2ByVfo1XiGQKDHkf354Kpi2edjFzsUT3FIlAXAM6O6AE%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h
  2020-12-23  1:19 ` Chenyang Li
@ 2020-12-24 21:52   ` Paul Menzel
  -1 siblings, 0 replies; 6+ messages in thread
From: Paul Menzel @ 2020-12-24 21:52 UTC (permalink / raw)
  To: Chenyang Li; +Cc: Alex Deucher, dri-devel, amd-gfx

Dear Chenyang,


Am 23.12.20 um 02:19 schrieb Chenyang Li:
> In line 24 "_AMDGPU_TRACE_H" is missing an underscore.

Nice catch. Could you please update the commit message summary, by 
adding a space after the prefix (colon), and using imperative mood [1]?

> drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition

If you can also add a Fixes tag, that would be even better.

Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")

> Signed-off-by: Chenyang Li <lichenyang@loongson.cn>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

[…]


Kind regards,

Paul


[1]: https://chris.beams.io/posts/git-commit/
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h
@ 2020-12-24 21:52   ` Paul Menzel
  0 siblings, 0 replies; 6+ messages in thread
From: Paul Menzel @ 2020-12-24 21:52 UTC (permalink / raw)
  To: Chenyang Li; +Cc: Alex Deucher, dri-devel, amd-gfx

Dear Chenyang,


Am 23.12.20 um 02:19 schrieb Chenyang Li:
> In line 24 "_AMDGPU_TRACE_H" is missing an underscore.

Nice catch. Could you please update the commit message summary, by 
adding a space after the prefix (colon), and using imperative mood [1]?

> drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition

If you can also add a Fixes tag, that would be even better.

Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")

> Signed-off-by: Chenyang Li <lichenyang@loongson.cn>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

[…]


Kind regards,

Paul


[1]: https://chris.beams.io/posts/git-commit/
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-24 21:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-23  1:19 [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h Chenyang Li
2020-12-23  1:19 ` Chenyang Li
2020-12-24  2:20 ` Chen, Guchun
2020-12-24  2:20   ` Chen, Guchun
2020-12-24 21:52 ` Paul Menzel
2020-12-24 21:52   ` Paul Menzel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.