From: Julien Grall <julien.grall@arm.com> To: Marc Zyngier <marc.zyngier@arm.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu Cc: Kees Cook <keescook@chromium.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Christoffer Dall <christoffer.dall@arm.com>, Andy Lutomirski <luto@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Thomas Gleixner <tglx@linutronix.de> Subject: Re: [PATCH 03/14] arm64: Add per-cpu infrastructure to call ARCH_WORKAROUND_2 Date: Wed, 23 May 2018 11:03:03 +0100 [thread overview] Message-ID: <ffe33a66-0979-6bfa-995e-f474a46831b6@arm.com> (raw) In-Reply-To: <20180522150648.28297-4-marc.zyngier@arm.com> Hi Marc, On 05/22/2018 04:06 PM, Marc Zyngier wrote: > In a heterogeneous system, we can end up with both affected and > unaffected CPUs. Let's check their status before calling into the > firmware. > > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> Reviewed-by: Julien Grall <julien.grall@arm.com> Cheers, > --- > arch/arm64/kernel/cpu_errata.c | 2 ++ > arch/arm64/kernel/entry.S | 11 +++++++---- > 2 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c > index 46b3aafb631a..0288d6cf560e 100644 > --- a/arch/arm64/kernel/cpu_errata.c > +++ b/arch/arm64/kernel/cpu_errata.c > @@ -233,6 +233,8 @@ enable_smccc_arch_workaround_1(const struct arm64_cpu_capabilities *entry) > #endif /* CONFIG_HARDEN_BRANCH_PREDICTOR */ > > #ifdef CONFIG_ARM64_SSBD > +DEFINE_PER_CPU_READ_MOSTLY(u64, arm64_ssbd_callback_required); > + > void __init arm64_update_smccc_conduit(struct alt_instr *alt, > __le32 *origptr, __le32 *updptr, > int nr_inst) > diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S > index f33e6aed3037..29ad672a6abd 100644 > --- a/arch/arm64/kernel/entry.S > +++ b/arch/arm64/kernel/entry.S > @@ -140,8 +140,10 @@ alternative_else_nop_endif > > // This macro corrupts x0-x3. It is the caller's duty > // to save/restore them if required. > - .macro apply_ssbd, state > + .macro apply_ssbd, state, targ, tmp1, tmp2 > #ifdef CONFIG_ARM64_SSBD > + ldr_this_cpu \tmp2, arm64_ssbd_callback_required, \tmp1 > + cbz \tmp2, \targ > mov w0, #ARM_SMCCC_ARCH_WORKAROUND_2 > mov w1, #\state > alternative_cb arm64_update_smccc_conduit > @@ -176,12 +178,13 @@ alternative_cb_end > ldr x19, [tsk, #TSK_TI_FLAGS] // since we can unmask debug > disable_step_tsk x19, x20 // exceptions when scheduling. > > - apply_ssbd 1 > + apply_ssbd 1, 1f, x22, x23 > > #ifdef CONFIG_ARM64_SSBD > ldp x0, x1, [sp, #16 * 0] > ldp x2, x3, [sp, #16 * 1] > #endif > +1: > > mov x29, xzr // fp pointed to user-space > .else > @@ -323,8 +326,8 @@ alternative_if ARM64_WORKAROUND_845719 > alternative_else_nop_endif > #endif > 3: > - apply_ssbd 0 > - > + apply_ssbd 0, 5f, x0, x1 > +5: > .endif > > msr elr_el1, x21 // set up the return data > -- Julien Grall
WARNING: multiple messages have this Message-ID (diff)
From: julien.grall@arm.com (Julien Grall) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 03/14] arm64: Add per-cpu infrastructure to call ARCH_WORKAROUND_2 Date: Wed, 23 May 2018 11:03:03 +0100 [thread overview] Message-ID: <ffe33a66-0979-6bfa-995e-f474a46831b6@arm.com> (raw) In-Reply-To: <20180522150648.28297-4-marc.zyngier@arm.com> Hi Marc, On 05/22/2018 04:06 PM, Marc Zyngier wrote: > In a heterogeneous system, we can end up with both affected and > unaffected CPUs. Let's check their status before calling into the > firmware. > > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> Reviewed-by: Julien Grall <julien.grall@arm.com> Cheers, > --- > arch/arm64/kernel/cpu_errata.c | 2 ++ > arch/arm64/kernel/entry.S | 11 +++++++---- > 2 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c > index 46b3aafb631a..0288d6cf560e 100644 > --- a/arch/arm64/kernel/cpu_errata.c > +++ b/arch/arm64/kernel/cpu_errata.c > @@ -233,6 +233,8 @@ enable_smccc_arch_workaround_1(const struct arm64_cpu_capabilities *entry) > #endif /* CONFIG_HARDEN_BRANCH_PREDICTOR */ > > #ifdef CONFIG_ARM64_SSBD > +DEFINE_PER_CPU_READ_MOSTLY(u64, arm64_ssbd_callback_required); > + > void __init arm64_update_smccc_conduit(struct alt_instr *alt, > __le32 *origptr, __le32 *updptr, > int nr_inst) > diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S > index f33e6aed3037..29ad672a6abd 100644 > --- a/arch/arm64/kernel/entry.S > +++ b/arch/arm64/kernel/entry.S > @@ -140,8 +140,10 @@ alternative_else_nop_endif > > // This macro corrupts x0-x3. It is the caller's duty > // to save/restore them if required. > - .macro apply_ssbd, state > + .macro apply_ssbd, state, targ, tmp1, tmp2 > #ifdef CONFIG_ARM64_SSBD > + ldr_this_cpu \tmp2, arm64_ssbd_callback_required, \tmp1 > + cbz \tmp2, \targ > mov w0, #ARM_SMCCC_ARCH_WORKAROUND_2 > mov w1, #\state > alternative_cb arm64_update_smccc_conduit > @@ -176,12 +178,13 @@ alternative_cb_end > ldr x19, [tsk, #TSK_TI_FLAGS] // since we can unmask debug > disable_step_tsk x19, x20 // exceptions when scheduling. > > - apply_ssbd 1 > + apply_ssbd 1, 1f, x22, x23 > > #ifdef CONFIG_ARM64_SSBD > ldp x0, x1, [sp, #16 * 0] > ldp x2, x3, [sp, #16 * 1] > #endif > +1: > > mov x29, xzr // fp pointed to user-space > .else > @@ -323,8 +326,8 @@ alternative_if ARM64_WORKAROUND_845719 > alternative_else_nop_endif > #endif > 3: > - apply_ssbd 0 > - > + apply_ssbd 0, 5f, x0, x1 > +5: > .endif > > msr elr_el1, x21 // set up the return data > -- Julien Grall
next prev parent reply other threads:[~2018-05-23 10:03 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-22 15:06 [PATCH 00/14] arm64 SSBD (aka Spectre-v4) mitigation Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-22 15:06 ` [PATCH 01/14] arm/arm64: smccc: Add SMCCC-specific return codes Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-24 10:55 ` Mark Rutland 2018-05-24 10:55 ` Mark Rutland 2018-05-22 15:06 ` [PATCH 02/14] arm64: Call ARCH_WORKAROUND_2 on transitions between EL0 and EL1 Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-23 9:23 ` Julien Grall 2018-05-23 9:23 ` Julien Grall 2018-05-24 10:52 ` Mark Rutland 2018-05-24 10:52 ` Mark Rutland 2018-05-24 12:10 ` Robin Murphy 2018-05-24 12:10 ` Robin Murphy 2018-05-24 11:00 ` Mark Rutland 2018-05-24 11:00 ` Mark Rutland 2018-05-24 11:23 ` Mark Rutland 2018-05-24 11:23 ` Mark Rutland 2018-05-24 11:28 ` Marc Zyngier 2018-05-24 11:28 ` Marc Zyngier 2018-05-22 15:06 ` [PATCH 03/14] arm64: Add per-cpu infrastructure to call ARCH_WORKAROUND_2 Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-23 10:03 ` Julien Grall [this message] 2018-05-23 10:03 ` Julien Grall 2018-05-24 11:14 ` Mark Rutland 2018-05-24 11:14 ` Mark Rutland 2018-05-22 15:06 ` [PATCH 04/14] arm64: Add ARCH_WORKAROUND_2 probing Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-23 10:06 ` Julien Grall 2018-05-23 10:06 ` Julien Grall 2018-05-24 9:58 ` Suzuki K Poulose 2018-05-24 9:58 ` Suzuki K Poulose 2018-05-24 11:39 ` Will Deacon 2018-05-24 11:39 ` Will Deacon 2018-05-24 13:34 ` Suzuki K Poulose 2018-05-24 13:34 ` Suzuki K Poulose 2018-05-24 11:27 ` Mark Rutland 2018-05-24 11:27 ` Mark Rutland 2018-05-22 15:06 ` [PATCH 05/14] arm64: Add 'ssbd' command-line option Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-22 15:29 ` Randy Dunlap 2018-05-22 15:29 ` Randy Dunlap 2018-05-22 15:29 ` Randy Dunlap 2018-05-23 10:08 ` Julien Grall 2018-05-23 10:08 ` Julien Grall 2018-05-24 11:40 ` Mark Rutland 2018-05-24 11:40 ` Mark Rutland 2018-05-24 11:52 ` Marc Zyngier 2018-05-24 11:52 ` Marc Zyngier 2018-05-22 15:06 ` [PATCH 06/14] arm64: ssbd: Add global mitigation state accessor Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-23 10:11 ` Julien Grall 2018-05-23 10:11 ` Julien Grall 2018-05-24 11:41 ` Mark Rutland 2018-05-24 11:41 ` Mark Rutland 2018-05-22 15:06 ` [PATCH 07/14] arm64: ssbd: Skip apply_ssbd if not using dynamic mitigation Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-23 10:13 ` Julien Grall 2018-05-23 10:13 ` Julien Grall 2018-05-24 11:43 ` Mark Rutland 2018-05-24 11:43 ` Mark Rutland 2018-05-22 15:06 ` [PATCH 08/14] arm64: ssbd: Disable mitigation on CPU resume if required by user Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-23 10:52 ` Julien Grall 2018-05-23 10:52 ` Julien Grall 2018-05-24 11:55 ` Mark Rutland 2018-05-24 11:55 ` Mark Rutland 2018-05-22 15:06 ` [PATCH 09/14] arm64: ssbd: Introduce thread flag to control userspace mitigation Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-24 12:01 ` Mark Rutland 2018-05-24 12:01 ` Mark Rutland 2018-05-24 12:16 ` Marc Zyngier 2018-05-24 12:16 ` Marc Zyngier 2018-05-24 12:19 ` Will Deacon 2018-05-24 12:19 ` Will Deacon 2018-05-24 12:36 ` Marc Zyngier 2018-05-24 12:36 ` Marc Zyngier 2018-05-22 15:06 ` [PATCH 10/14] arm64: ssbd: Add prctl interface for per-thread mitigation Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-22 15:48 ` Dominik Brodowski 2018-05-22 15:48 ` Dominik Brodowski 2018-05-22 16:30 ` Marc Zyngier 2018-05-22 16:30 ` Marc Zyngier 2018-05-22 16:30 ` Marc Zyngier 2018-05-24 12:10 ` Mark Rutland 2018-05-24 12:10 ` Mark Rutland 2018-05-24 12:24 ` Will Deacon 2018-05-24 12:24 ` Will Deacon 2018-05-22 15:06 ` [PATCH 11/14] arm64: KVM: Add HYP per-cpu accessors Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-24 12:11 ` Mark Rutland 2018-05-24 12:11 ` Mark Rutland 2018-05-22 15:06 ` [PATCH 12/14] arm64: KVM: Add ARCH_WORKAROUND_2 support for guests Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-24 12:15 ` Mark Rutland 2018-05-24 12:15 ` Mark Rutland 2018-05-22 15:06 ` [PATCH 13/14] arm64: KVM: Handle guest's ARCH_WORKAROUND_2 requests Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-24 12:22 ` Mark Rutland 2018-05-24 12:22 ` Mark Rutland 2018-05-22 15:06 ` [PATCH 14/14] arm64: KVM: Add ARCH_WORKAROUND_2 discovery through ARCH_FEATURES_FUNC_ID Marc Zyngier 2018-05-22 15:06 ` Marc Zyngier 2018-05-24 12:25 ` Mark Rutland 2018-05-24 12:25 ` Mark Rutland 2018-07-20 9:47 [PATCH 00/14] arm64: 4.17 backport of the SSBD mitigation patches Marc Zyngier 2018-07-20 9:47 ` [PATCH 03/14] arm64: Add per-cpu infrastructure to call ARCH_WORKAROUND_2 Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ffe33a66-0979-6bfa-995e-f474a46831b6@arm.com \ --to=julien.grall@arm.com \ --cc=catalin.marinas@arm.com \ --cc=christoffer.dall@arm.com \ --cc=gregkh@linuxfoundation.org \ --cc=keescook@chromium.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@kernel.org \ --cc=marc.zyngier@arm.com \ --cc=tglx@linutronix.de \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.