From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) To: Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Cc: bastian-yyjItF7Rl6lg9hUCZPvPmw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>, roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org Subject: Re: [RFC][PATCH 4/6][v3] Define siginfo_from_ancestor_ns() Date: Mon, 22 Dec 2008 16:32:16 -0800 [thread overview] Message-ID: <m13agf68a7.fsf@frodo.ebiederm.org> (raw) In-Reply-To: <20081223002215.GA7984-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> (Oleg Nesterov's message of "Tue, 23 Dec 2008 01:22:15 +0100") Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> writes: >> I was going through the ->si_pid assignments to try and fix them at >> source (like the mqueue patch I sent last week). > > OK. Note. When a signal goes to a process group (or similar) we can't fix si_pid at the source. We have to fix it when only a single destination process is known. It doesn't mean that fixing it at the source is hopeless but... >> The two cases that don't fit the model are sys_kill() and sys_tkill(). >> For that I was hoping we could use siginfo_from_user() again. i.e >> >> if (siginfo_from_user()) >> masquerade_si_pid() >> >> in the default: case of send_signal(). To be safe, masquerade_si_pid() >> could do it only iff si_code is either SI_USER or SI_TKILL. >> >> IOW, with some tweaks, I am trying to see if we can use siginfo_from_user() >> in place of the SIG_FROM_USER. > > sys_rt_sigqueueinfo(). > > But, perhaps we can just ignore the problems with sigqueueinfo() (and > document them). Yes. I don't think si_pid is valid in that case anyway. It is the kernel signals where si_pid is a reliable field that are important. Eric
WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman) To: Oleg Nesterov <oleg@redhat.com> Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>, ebiederm@xmission.com, roland@redhat.com, bastian@waldi.eu.org, daniel@hozac.com, xemul@openvz.org, containers@lists.osdl.org, linux-kernel@vger.kernel.org, sukadev@us.ibm.com Subject: Re: [RFC][PATCH 4/6][v3] Define siginfo_from_ancestor_ns() Date: Mon, 22 Dec 2008 16:32:16 -0800 [thread overview] Message-ID: <m13agf68a7.fsf@frodo.ebiederm.org> (raw) In-Reply-To: <20081223002215.GA7984@redhat.com> (Oleg Nesterov's message of "Tue, 23 Dec 2008 01:22:15 +0100") Oleg Nesterov <oleg@redhat.com> writes: >> I was going through the ->si_pid assignments to try and fix them at >> source (like the mqueue patch I sent last week). > > OK. Note. When a signal goes to a process group (or similar) we can't fix si_pid at the source. We have to fix it when only a single destination process is known. It doesn't mean that fixing it at the source is hopeless but... >> The two cases that don't fit the model are sys_kill() and sys_tkill(). >> For that I was hoping we could use siginfo_from_user() again. i.e >> >> if (siginfo_from_user()) >> masquerade_si_pid() >> >> in the default: case of send_signal(). To be safe, masquerade_si_pid() >> could do it only iff si_code is either SI_USER or SI_TKILL. >> >> IOW, with some tweaks, I am trying to see if we can use siginfo_from_user() >> in place of the SIG_FROM_USER. > > sys_rt_sigqueueinfo(). > > But, perhaps we can just ignore the problems with sigqueueinfo() (and > document them). Yes. I don't think si_pid is valid in that case anyway. It is the kernel signals where si_pid is a reliable field that are important. Eric
next prev parent reply other threads:[~2008-12-23 0:32 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-12-21 0:51 [RFC][PATCH 0/6][v3] Container-init signal semantics Sukadev Bhattiprolu 2008-12-21 0:52 ` [RFC][PATCH 1/6][v3] Remove 'handler' parameter to tracehook functions Sukadev Bhattiprolu 2008-12-23 19:30 ` Roland McGrath 2008-12-21 0:53 ` [RFC][PATCH 2/6][v3] Protect init from unwanted signals more Sukadev Bhattiprolu [not found] ` <20081221005319.GB5025-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> 2008-12-23 19:31 ` Roland McGrath 2008-12-23 19:31 ` Roland McGrath [not found] ` <20081221005106.GA4912-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> 2008-12-21 0:53 ` [RFC][PATCH 3/6][v3] Define/set SIGNAL_UNKILLABLE_FROM_NS Sukadev Bhattiprolu 2008-12-21 0:53 ` Sukadev Bhattiprolu 2008-12-21 0:54 ` [RFC][PATCH 4/6][v3] Define siginfo_from_ancestor_ns() Sukadev Bhattiprolu 2008-12-22 22:26 ` Oleg Nesterov [not found] ` <20081222222604.GA1536-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2008-12-22 23:01 ` Oleg Nesterov 2008-12-22 23:01 ` Oleg Nesterov 2008-12-22 23:58 ` Sukadev Bhattiprolu 2008-12-23 0:22 ` Oleg Nesterov [not found] ` <20081223002215.GA7984-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2008-12-23 0:32 ` Eric W. Biederman [this message] 2008-12-23 0:32 ` Eric W. Biederman 2008-12-23 4:47 ` Sukadev Bhattiprolu 2008-12-22 23:45 ` Sukadev Bhattiprolu 2008-12-22 23:54 ` Oleg Nesterov 2008-12-21 0:54 ` [RFC][PATCH 5/6][v3] Protect cinit from unblocked SIG_DFL signals Sukadev Bhattiprolu 2008-12-22 22:46 ` Oleg Nesterov 2008-12-21 0:55 ` [RFC][PATCH 6/6][v3] Protect cinit from blocked fatal signals Sukadev Bhattiprolu [not found] ` <20081221005529.GF5025-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> 2008-12-22 22:58 ` Oleg Nesterov 2008-12-22 22:58 ` Oleg Nesterov 2008-12-22 23:38 ` Sukadev Bhattiprolu [not found] ` <20081222233855.GA13079-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> 2008-12-23 0:03 ` Oleg Nesterov 2008-12-23 0:03 ` Oleg Nesterov 2008-12-22 10:55 ` [RFC][PATCH 0/6][v3] Container-init signal semantics Eric W. Biederman 2008-12-22 19:47 ` Sukadev Bhattiprolu [not found] ` <20081222194737.GC9085-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> 2008-12-23 0:27 ` Eric W. Biederman 2008-12-23 0:27 ` Eric W. Biederman 2008-12-23 2:12 ` Sukadev Bhattiprolu 2008-12-23 16:51 ` Serge E. Hallyn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=m13agf68a7.fsf@frodo.ebiederm.org \ --to=ebiederm-as9lmozglivwk0htik3j/w@public.gmane.org \ --cc=bastian-yyjItF7Rl6lg9hUCZPvPmw@public.gmane.org \ --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \ --cc=xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.