* [PATCH] tty: fix vt_compat_ioctl
@ 2009-09-28 18:10 Andreas Schwab
2009-09-28 18:33 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2009-09-28 18:10 UTC (permalink / raw)
To: linux-kernel; +Cc: Greg Kroah-Hartman
Call compat_unimap_ioctl, not do_unimap_ioctl.
Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
---
drivers/char/vt_ioctl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/vt_ioctl.c b/drivers/char/vt_ioctl.c
index 29c651a..431c5c3 100644
--- a/drivers/char/vt_ioctl.c
+++ b/drivers/char/vt_ioctl.c
@@ -1530,7 +1530,7 @@ long vt_compat_ioctl(struct tty_struct *tty, struct file * file,
case PIO_UNIMAP:
case GIO_UNIMAP:
- ret = do_unimap_ioctl(cmd, up, perm, vc);
+ ret = compat_unimap_ioctl(cmd, up, perm, vc);
break;
/*
--
1.6.4.4
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] tty: fix vt_compat_ioctl
2009-09-28 18:10 [PATCH] tty: fix vt_compat_ioctl Andreas Schwab
@ 2009-09-28 18:33 ` Greg KH
2009-09-28 19:21 ` Andreas Schwab
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2009-09-28 18:33 UTC (permalink / raw)
To: Andreas Schwab; +Cc: linux-kernel
On Mon, Sep 28, 2009 at 08:10:02PM +0200, Andreas Schwab wrote:
> Call compat_unimap_ioctl, not do_unimap_ioctl.
That's a nice description of what the patch does, but why do we need to
do that? What is the problem here? What caused it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tty: fix vt_compat_ioctl
2009-09-28 18:33 ` Greg KH
@ 2009-09-28 19:21 ` Andreas Schwab
2009-09-28 23:56 ` Florian Mickler
2009-09-29 12:49 ` Arnd Bergmann
0 siblings, 2 replies; 5+ messages in thread
From: Andreas Schwab @ 2009-09-28 19:21 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel
Greg KH <gregkh@suse.de> writes:
> On Mon, Sep 28, 2009 at 08:10:02PM +0200, Andreas Schwab wrote:
>> Call compat_unimap_ioctl, not do_unimap_ioctl.
>
> That's a nice description of what the patch does, but why do we need to
> do that?
It's a compat ioctl handler, so lets call the compat ioctl handler.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tty: fix vt_compat_ioctl
2009-09-28 19:21 ` Andreas Schwab
@ 2009-09-28 23:56 ` Florian Mickler
2009-09-29 12:49 ` Arnd Bergmann
1 sibling, 0 replies; 5+ messages in thread
From: Florian Mickler @ 2009-09-28 23:56 UTC (permalink / raw)
To: Andreas Schwab, linux-kernel, Greg KH
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
Hi!
On Mon, 28 Sep 2009 21:21:14 +0200
Andreas Schwab <schwab@linux-m68k.org> wrote:
> Greg KH <gregkh@suse.de> writes:
>
> > On Mon, Sep 28, 2009 at 08:10:02PM +0200, Andreas Schwab wrote:
> >> Call compat_unimap_ioctl, not do_unimap_ioctl.
> >
> > That's a nice description of what the patch does, but why do we need to
> > do that?
>
> It's a compat ioctl handler, so lets call the compat ioctl handler.
>
> Andreas.
>
Any other reasons? Why not rename the call then? That would be a
functional no-op with the same effect...
Sincerely,
Florian
p.s. maybe it is obvious if one looks at the code (i didnt), but it
should be described nonetheless in the commit-log!
--
A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
>> A: Top-posting.
>>> Q: What is the most annoying thing in e-mail?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tty: fix vt_compat_ioctl
2009-09-28 19:21 ` Andreas Schwab
2009-09-28 23:56 ` Florian Mickler
@ 2009-09-29 12:49 ` Arnd Bergmann
1 sibling, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2009-09-29 12:49 UTC (permalink / raw)
To: Andreas Schwab; +Cc: Greg KH, linux-kernel
On Monday 28 September 2009, Andreas Schwab wrote:
> Greg KH <gregkh@suse.de> writes:
>
> > On Mon, Sep 28, 2009 at 08:10:02PM +0200, Andreas Schwab wrote:
> >> Call compat_unimap_ioctl, not do_unimap_ioctl.
> >
> > That's a nice description of what the patch does, but why do we need to
> > do that?
>
> It's a compat ioctl handler, so lets call the compat ioctl handler.
>
My bad, sorry.
I broke it in e9216651 evidently, thanks for debugging this.
The compat_unimap_ioctl was originally called do_unimap_ioctl in
fs/compat_ioctl.h which got moved to drivers/char/vt_ioctl.c.
In that patch, the caller was not updated and consequently called
the native handler.
Acked-by: Arnd Bergmann <arnd@arndb.de>
Arnd <><
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-09-29 12:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-28 18:10 [PATCH] tty: fix vt_compat_ioctl Andreas Schwab
2009-09-28 18:33 ` Greg KH
2009-09-28 19:21 ` Andreas Schwab
2009-09-28 23:56 ` Florian Mickler
2009-09-29 12:49 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.