[Qemu-devel] [PATCH 0/2] Yet more gcc warnings fixes

[Qemu-devel] [PATCH 0/2] Yet more gcc warnings fixes

[Juan Quintela]

More places that have write only variables.

Once here, why we have clovvered arg7 is a good question (TM)

abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
                    abi_long arg2, abi_long arg3, abi_long arg4,
                    abi_long arg5, abi_long arg6, abi_long arg7,
                    abi_long arg8)
{

	.....
            abi_ulong arg_sigset, *arg7;
	....

Using a different name could be a good idea.

Please, apply.

Later, Juan.

Juan Quintela (2):
  xen_mapcache: remove unused variable
  syscall: pselect arg_sigsize variable was write only

 linux-user/syscall.c |    3 +--
 xen-mapcache.c       |    3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

-- 
1.7.6

[Qemu-devel] [PATCH 1/2] xen_mapcache: remove unused variable

[Juan Quintela]

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 xen-mapcache.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/xen-mapcache.c b/xen-mapcache.c
index fac47cd..e2e324d 100644
--- a/xen-mapcache.c
+++ b/xen-mapcache.c
@@ -232,7 +232,7 @@ uint8_t *qemu_map_cache(target_phys_addr_t phys_addr, target_phys_addr_t size, u

 ram_addr_t qemu_ram_addr_from_mapcache(void *ptr)
 {
-    MapCacheEntry *entry = NULL, *pentry = NULL;
+    MapCacheEntry *entry = NULL;
     MapCacheRev *reventry;
     target_phys_addr_t paddr_index;
     target_phys_addr_t size;
@@ -258,7 +258,6 @@ ram_addr_t qemu_ram_addr_from_mapcache(void *ptr)

     entry = &mapcache->entry[paddr_index % mapcache->nr_buckets];
     while (entry && (entry->paddr_index != paddr_index || entry->size != size)) {
-        pentry = entry;
         entry = entry->next;
     }
     if (!entry) {
-- 
1.7.6

Re: [Qemu-devel] [PATCH 1/2] xen_mapcache: remove unused variable

[Stefano Stabellini]

On Mon, 11 Jul 2011, Juan Quintela wrote:
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>


Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

> ---
>  xen-mapcache.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/xen-mapcache.c b/xen-mapcache.c
> index fac47cd..e2e324d 100644
> --- a/xen-mapcache.c
> +++ b/xen-mapcache.c
> @@ -232,7 +232,7 @@ uint8_t *qemu_map_cache(target_phys_addr_t phys_addr, target_phys_addr_t size, u
> 
>  ram_addr_t qemu_ram_addr_from_mapcache(void *ptr)
>  {
> -    MapCacheEntry *entry = NULL, *pentry = NULL;
> +    MapCacheEntry *entry = NULL;
>      MapCacheRev *reventry;
>      target_phys_addr_t paddr_index;
>      target_phys_addr_t size;
> @@ -258,7 +258,6 @@ ram_addr_t qemu_ram_addr_from_mapcache(void *ptr)
> 
>      entry = &mapcache->entry[paddr_index % mapcache->nr_buckets];
>      while (entry && (entry->paddr_index != paddr_index || entry->size != size)) {
> -        pentry = entry;
>          entry = entry->next;
>      }
>      if (!entry) {
> -- 
> 1.7.6
> 
> 

Re: [Qemu-devel] [PATCH 1/2] xen_mapcache: remove unused variable

[Stefan Berger]

On 07/11/2011 12:15 PM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela<quintela@redhat.com>
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>

Been pointed to this patch after having posted the same.

    Stefan

> ---
>   xen-mapcache.c |    3 +--
>   1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/xen-mapcache.c b/xen-mapcache.c
> index fac47cd..e2e324d 100644
> --- a/xen-mapcache.c
> +++ b/xen-mapcache.c
> @@ -232,7 +232,7 @@ uint8_t *qemu_map_cache(target_phys_addr_t phys_addr, target_phys_addr_t size, u
>
>   ram_addr_t qemu_ram_addr_from_mapcache(void *ptr)
>   {
> -    MapCacheEntry *entry = NULL, *pentry = NULL;
> +    MapCacheEntry *entry = NULL;
>       MapCacheRev *reventry;
>       target_phys_addr_t paddr_index;
>       target_phys_addr_t size;
> @@ -258,7 +258,6 @@ ram_addr_t qemu_ram_addr_from_mapcache(void *ptr)
>
>       entry =&mapcache->entry[paddr_index % mapcache->nr_buckets];
>       while (entry&&  (entry->paddr_index != paddr_index || entry->size != size)) {
> -        pentry = entry;
>           entry = entry->next;
>       }
>       if (!entry) {

Re: [Qemu-devel] [PATCH 1/2] xen_mapcache: remove unused variable

[Stefan Hajnoczi]

On Mon, Jul 11, 2011 at 06:15:11PM +0200, Juan Quintela wrote:
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  xen-mapcache.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)

Since Stefano has acked it but it was not merged into qemu.git yet...

Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches

Stefan

[Qemu-devel] [PATCH 2/2] syscall: pselect arg_sigsize variable was write only

[Juan Quintela]

Remove it.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 linux-user/syscall.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index fed7a8f..35bbe36 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5634,7 +5634,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
                 size_t size;
             } sig, *sig_ptr;

-            abi_ulong arg_sigset, arg_sigsize, *arg7;
+            abi_ulong arg_sigset, *arg7;
             target_sigset_t *target_sigset;

             n = arg1;
@@ -5679,7 +5679,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
                     goto efault;
                 }
                 arg_sigset = tswapl(arg7[0]);
-                arg_sigsize = tswapl(arg7[1]);
                 unlock_user(arg7, arg6, 0);

                 if (arg_sigset) {
-- 
1.7.6

Re: [Qemu-devel] [PATCH 2/2] syscall: pselect arg_sigsize variable was write only

[Peter Maydell]

On 11 July 2011 17:15, Juan Quintela <quintela@redhat.com> wrote:
> Remove it.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>

http://patchwork.ozlabs.org/patch/104232/ in the current linux-user
pullreq is a fix for this.

-- PMM

Re: [Qemu-devel] [PATCH 2/2] syscall: pselect arg_sigsize variable was write only

[Juan Quintela]

Juan Quintela <quintela@redhat.com> wrote:
> Remove it.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>

/me nacks himself

Peter one is better, it even makes sense, go figure O:-)