Re: [PATCH v2 2/2] leds/powernv: Add driver for PowerNV platform

From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: mpe@ellerman.id.au
Cc: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>,
	Jacek Anaszewski <j.anaszewski@samsung.com>,
	linuxppc-dev@lists.ozlabs.org, linux-leds@vger.kernel.org,
	cooloney@gmail.com, rpurdie@rpsys.net,
	khandual@linux.vnet.ibm.com
Subject: Re: [PATCH v2 2/2] leds/powernv: Add driver for PowerNV platform
Date: Wed, 22 Apr 2015 09:03:36 +1000	[thread overview]
Message-ID: <m3sibtozhz.fsf@oc8180480414.ibm.com> (raw)
In-Reply-To: <552F437E.4020409@linux.vnet.ibm.com>

Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes:
> On 04/16/2015 12:20 AM, Stewart Smith wrote:
>> Jacek Anaszewski <j.anaszewski@samsung.com> writes:
>>>> +static struct platform_driver powernv_led_driver = {
>>>> +	.probe	= powernv_led_probe,
>>>> +	.remove = powernv_led_remove,
>>>> +	.driver = {
>>>> +		.name = "powernv-led-driver",
>>>> +		.owner = THIS_MODULE,
>>>> +		.of_match_table = powernv_led_match,
>>>
>>> Is somewhere DT documentation available for these leds?
>> 
>> https://github.com/open-power/skiboot/blob/master/doc/device-tree/ibm%2Copal/led.txt
>> 
>> We've been documenting things in firmware source, and I'm open to if we
>> should mirror this somewhere (somewhere in linux Documentation/ ?).
>
> Stewart,
>
> I'm adding Documentation/devicetree/bindings/leds/leds-powernv.txt ...which is
> pretty much similar to the device tree documentation we have in OPAL side.

Michael,

I know we've kind of discussed this in the past, but perhaps we should
come up with a conistent way of doing this for OPAL related docs.